On Mon, Jun 10, 2019 at 10:08:21AM +0530, Nishka Dasgupta wrote:
> On 09/06/19 4:32 PM, Greg KH wrote:
> > On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
> > > Remove variables that are declared and assigned values but not otherwise
> > > used.
> > > Issue found with Coccinelle.
This patch makes 4 symbols static as suggested by Sparse tool.
Signed-off-by: Rishiraj Manwatkar
---
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
Since whitespace should not appear between asterisk and
variable name in a declaration statement, remove it and
fix checkpatch.pl error "foo * bar" should be "foo *bar".
Signed-off-by: Naoto Kobayashi
---
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
1 file changed, 1 insertion(+), 1
On 09/06/19 4:32 PM, Greg KH wrote:
On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
Remove variables that are declared and assigned values but not otherwise
used.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |
On 07/06/19 7:45 PM, Dan Carpenter wrote:
Probably you sent this patch unintentionally. The subject doesn't make
any sort of sense. :P
So the problem with the subject line is that git send-email and vim (as
configured on my laptop) tend to line-wrap even the subject line. Since
I have two
On 2019-06-08 12:55, Wolfram Sang wrote:
> While preparing a refactoring series, I noticed that some drivers use a
> complicated way of determining the adapter of a client. The easy way is
> to use the intended pointer: client->adapter
>
> These drivers do:
>
This patch fixes below issues reported by checkpatch
CHECK: spaces preferred around that '-' (ctx:VxV)
+ skb_copy_bits(pfile->pkt, pfile->buf_len-pfile->pkt_len,
rmem, len);
CHECK: spaces preferred around that '*' (ctx:VxV)
+#define WMM_XMIT_THRESHOLD (NR_XMITFRAME*2/5)
this patch fixes below issue reported by checkpatch
CHECK: Using comparison to true is error prone
+ if (res == true)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch fixes below issue reported by checkpatch
CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf"
+ if (pxmitbuf->pallocated_buf == NULL)
Signed-off-by: Hariprasad Kelam
---
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
1 file changed, 1
In halbtc8723b2ant_TdmaDurationAdjust function,below piece of code is
repeated many times.
halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val);
pCoexDm->psTdmaDuAdjType = val;
So replace the same with "HAL_BTC8723B2ANT_DMA_DURATION_ADJUST" MACRO.
Signed-off-by: Hariprasad Kelam
-
On Sat, Jun 08, 2019 at 01:45:05PM +, Geordan Neukum wrote:
> On Sat, Jun 08, 2019 at 03:27:46PM +0800, Hao Xu wrote:
> > modify void* to void * for #define inb_p(a) readq((void*)a)
> > and #define outb_p(d,a) writeq(d,(void*)a)
> >
> > Signed-off-by: Hao Xu
> > ---
> >
Fixed a coding style issue.
Signed-off-by: Harold André
---
drivers/staging/ralink-gdma/ralink-gdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ralink-gdma/ralink-gdma.c
index de3e357b2640..5854551d0a52
On Fri, Jun 07, 2019 at 12:41:23PM +0530, Nishka Dasgupta wrote:
> Remove variables that are declared and assigned values but not otherwise
> used.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 -
> 1 file
On Sun, Jun 09, 2019 at 11:07:41AM +0530, Hariprasad Kelam wrote:
> fix below issues reported by checkpatch
>
> CHECK: Please don't use multiple blank lines
> WARNING: space prohibited between function name and open parenthesis '('
> +void _rtw_open_pktfile (_pkt *pktptr, struct pkt_file *pfile)
On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol
> 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese
> ---
>
On Sun, Jun 09, 2019 at 12:24:59AM +, Rishiraj Manwatkar wrote:
> Made hysdn_proc_entry static as suggested by Sparse tool.
Why is this indented?
>
> Signed-off-by: Rishiraj Manwatkar
> ---
> drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Sun, Jun 09, 2019 at 04:02:32PM +0530, Hariprasad Kelam wrote:
>
> As part of halbtc8723b2ant_TdmaDurationAdjust function below
> piece of code is used many times.
>
> halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val);
> pCoexDm->psTdmaDuAdjType = val;
>
> This
As part of halbtc8723b2ant_TdmaDurationAdjust function below
piece of code is used many times.
halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val);
pCoexDm->psTdmaDuAdjType = val;
This patch replaces this common code with MACRO
18 matches
Mail list logo
