[PATCH] media: imx7-media-csi: Remove unneeded break after return

This patch fixes the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: Chinmaya Krishnan Mahesh --- drivers/staging/media/imx/imx7-media-csi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c

Re: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote: Hello Hari Prasad, Please add the recommended reviewers mentioned in the TODO file of rtl8723bs directory. I see the following emails in the TODO file. Greg Kroah-Hartman , Hans de Goede and Larry Finger > fix below issues

Re: [PATCH] Staging: most: fix coding style issues

On Sat, 2019-06-29 at 16:44 -0700, Gabriel Beauchamp wrote: > This is a patch for the core.[ch] files that fixes up warnings > found with the checkpatch.pl tool. [] > diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c [] > @@ -303,7 +303,8 @@ static ssize_t

[PATCH] Staging: most: fix coding style issues

This is a patch for the core.[ch] files that fixes up warnings found with the checkpatch.pl tool. Signed-off-by: Gabriel Beauchamp --- drivers/staging/most/core.c | 4 +++- drivers/staging/most/core.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

good day

I am Vice Chairman of Hang Seng Bank, I have Important Matter to Discuss with you concerning my late client, Died without a NEXT OF KIN. Send me your private email for full details information. email me at (infocar...@aim.com) Mail:infocar...@aim.com Regards Dr.Raymond Chien Kuo Fung

good day

I am Vice Chairman of Hang Seng Bank, I have Important Matter to Discuss with you concerning my late client, Died without a NEXT OF KIN. Send me your private email for full details information. email me at (infocar...@aim.com) Mail:infocar...@aim.com Regards Dr.Raymond Chien Kuo Fung

[PATCH V2 26/29] staging: bcm2835-camera: Fix stride on RGB3/BGR3 formats

From: Dave Stevenson RGB3/BGR3 end up being 3 bytes per pixel, which meant that the alignment code ended up trying to align using bitmasking with a mask of 96. That doesn't work, so switch to an arithmetic alignment for those formats. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren

[PATCH V2 28/29] staging: bcm2835-camera: Set the field value within each buffer

From: Dave Stevenson Fixes a v4l2-compliance failure v4l2-test-buffers.cpp(415): g_field() == V4L2_FIELD_ANY The driver only ever produces progresive frames, so field should always be set to V4L2_FIELD_NONE. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil

[PATCH V2 25/29] staging: mmal-vchiq: Avoid use of bool in structures

From: Dave Stevenson Fixes up a checkpatch error "Avoid using bool structure members because of possible alignment issues". Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 29/29] staging: bcm2835-camera: Correct ctrl min/max/step/def to 64bit

From: Dave Stevenson The V4L2 control API was expanded to take 64 bit values in commit 0ba2aeb6dab (Apr 16 2014), but as this driver wasn't in the mainline kernel at that point this was overlooked. Update to use 64 bit values. This also fixes a couple of warnings in 64 bit builds.

[PATCH V2 27/29] staging: bcm2835-camera: Add sanity checks for queue_setup/CREATE_BUFS

From: Dave Stevenson Fixes a v4l2-compliance failure when passed a buffer that is too small. queue_setup wasn't handling the case where *nplanes != 0, as used from CREATE_BUFS and requiring the driver to sanity check the provided buffer parameters. It was assuming that it was always being used

[PATCH] staging/media/davinci_vpfe: Add null check post kmalloc

Add NULL check post memory operations Signed-off-by: Hariprasad Kelam --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index

[PATCH] staging: netlogic: Change GFP_ATOMIC to GFP_KERNEL

Below is data path of xlr_config_spill xlr_net_probe -->xlr_config_fifo_spill_area --->xlr_config_spill We can use GFP_KERNEL as this function is getting called from xlr_net_probe and there are no locks. Signed-off-by: Hariprasad Kelam --- drivers/staging/netlogic/xlr_net.c | 2 +- 1 file

[PATCH] staging/rtl8188eu/os_dep: Remove unneeded variable ret

Below list of functions returns 0 in success and -EINVAL in failure. So directly return 0 on Success. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH V2 19/29] staging: bcm2835-camera: Unify header inclusion defines

From: Dave Stevenson Most of the headers use ifndef FOO_H, whilst mmal-parameters.h used ifndef __FOO_H. Revise mmal-parameters.h to drop the underscores and make the headers all consistent. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro

[PATCH V2 20/29] staging: bcm2835-camera: Fix multiple assignments should be avoided

From: Dave Stevenson Clear checkpatch complaints of "multiple assignments should be avoided" Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 5 +++-- 1 file

[PATCH V2 17/29] staging: bcm2835-camera: Set sequence number correctly

From: Dave Stevenson Set the sequence number in vb2_v4l2_buffer mainly so the latest v4l2-ctl reports the frame rate correctly. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 18/29] staging: bcm2835-camera: Add multiple inclusion protection to headers

From: Dave Stevenson mmal-common.h and mmal-msg.h didn't have the normal ifndef FOO / define FOO / endif protection to stop it being included multiple times. Add it. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 24/29] staging: bcm2835-camera: Remove/amend some obsolete comments

From: Dave Stevenson Remove a todo which has been done. Remove a template line that was redundant. Make a comment clearer as to the non-obvious meaning of a field. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 21/29] staging: bcm2835-camera: Fix up mmal-parameters.h

From: Dave Stevenson Fixes up all the checkpatch error "line over 80 characters" in mmal-parameters.h Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- .../vc04_services/bcm2835-camera/mmal-parameters.h | 261

[PATCH V2 16/29] staging: bcm2835-camera: Handle empty EOS buffers whilst streaming

From: Dave Stevenson The change to mapping V4L2 to MMAL buffers 1:1 didn't handle the condition we get with raw pixel buffers (eg YUV and RGB) direct from the camera's stills port. That sends the pixel buffer and then an empty buffer with the EOS flag set. The EOS buffer wasn't handled and

[PATCH V2 23/29] staging: bcm2835-camera: Correct V4L2_CID_COLORFX_CBCR behaviour

From: Dave Stevenson With V4L2_CID_COLORFX_CBCR calling ctrl_set_colfx it was incorrectly assigning the colour values to the enable field of dev->colourfx instead of the u and v fields. Correct the assignments. Reported as a Coverity issue Detected by CoverityScan CID#1419711 ("Unused value")

[PATCH V2 22/29] staging: bcm2835-camera: Use enums for max value in controls

From: Dave Stevenson Controls of type MMAL_CONTROL_TYPE_STD_MENU call v4l2_ctrl_new_std_menu with a max value and a mask. The max value is one of the defined values for the control, however in the config array there are several entries where raw numbers have been used instead. Replace these with

[PATCH V2 09/29] staging: bcm2835-camera: Reduce length of enum names

From: Dave Stevenson We have numerous lines over 80 chars, or oddly split. Many of these are due to using long enum names such as MMAL_COMPONENT_CAMERA. Reduce the length of these enum names. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro

[PATCH V2 00/29] staging: bcm2835-camera: Improvements

This is an attempt to help Dave Stevenson to get all the fixes and improvements of the bcm2835-camera driver into mainline. Mostly i only polished the commit logs for upstream. The series based on the latest bugfix V2 of staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate().

[PATCH V2 13/29] staging: bcm2835-camera: Fix open parenthesis alignment

From: Dave Stevenson Fix checkpatch "Alignment should match open parenthesis" errors. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 9

[PATCH V2 05/29] staging: bcm2835-camera: Return early on errors

From: Dave Stevenson Fix several instances where it is easier to return early on error conditions than handle it as an else clause. As requested by Mauro. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 03/29] staging: bcm2835-camera: Do not bulk receive from service thread

From: Dave Stevenson vchi_bulk_queue_receive will queue up to a default of 4 bulk receives on a connection before blocking. If called from the VCHI service_callback thread, then that thread is unable to service the VCHI_CALLBACK_BULK_RECEIVED events that would enable the queue call to succeed.

[PATCH V2 10/29] staging: bcm2835-camera: Fix multiple line dereference errors

From: Dave Stevenson Fix checkpatch errors "Avoid multiple line dereference" Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 11 --- 1 file changed,

[PATCH V2 01/29] staging: bcm2835-camera: Check the error for REPEAT_SEQ_HEADER

From: Dave Stevenson When handling for V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER was added the firmware would reject the setting if H264 hadn't already been selected. This was fixed in the firmware at that point, but to enable backwards compatibility the returned error was ignored. That was Dec

[PATCH V2 04/29] staging: bcm2835-camera: Correctly denote key frames in encoded data

From: Dave Stevenson Forward MMAL key frame flags to the V4L2 buffers. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +++ 1 file changed, 3

[PATCH V2 12/29] staging: bcm2835-camera: Fix missing lines between items

From: Dave Stevenson Fix checkpatch errors for missing blank lines after variable or structure declarations. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h |

[PATCH V2 11/29] staging: bcm2835-camera: Fix brace style issues.

From: Dave Stevenson Fix mismatched or missing brace issues flagged by checkpatch. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 ++-

[PATCH V2 15/29] staging: bcm2835-camera: Remove check of the number of buffers supplied

From: Dave Stevenson Before commit "staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping" there was a need to ensure that there were sufficient buffers supplied from the user to cover those being sent to the VPU (always 1). Now the buffers are linked 1:1 between MMAL and V4L2, therefore

[PATCH V2 06/29] staging: bcm2835-camera: Remove dead email addresses

From: Dave Stevenson None of the listed author email addresses were valid. Keep list of authors and the companies they represented. Update my email address. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab ---

[PATCH V2 02/29] staging: bcm2835-camera: Replace spinlock protecting context_map with mutex

From: Dave Stevenson The commit "staging: bcm2835-camera: Replace open-coded idr with a struct idr." replaced an internal implementation of an idr with the standard functions and a spinlock. idr_alloc(GFP_KERNEL) can sleep whilst calling kmem_cache_alloc to allocate the new node, but this is not

[PATCH V2 14/29] staging: bcm2835-camera: Ensure all buffers are returned on disable

From: Dave Stevenson With the recent change to match MMAL and V4L2 buffers there is a need to wait for all MMAL buffers to be returned during stop_streaming. Fixes: 938416707071 ("staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping") Signed-off-by: Dave Stevenson Signed-off-by: Stefan

[PATCH V2 08/29] staging: bcm2835-camera: Fix spacing around operators

From: Dave Stevenson Fix checkpatch warnings over spaces around operators. Many were around operations that can be replaced with the BIT(x) macro, so replace with that where appropriate. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro

[PATCH V2 07/29] staging: bcm2835-camera: Fix comment style violations.

From: Dave Stevenson Fix comment style violations in the header files. Signed-off-by: Dave Stevenson Signed-off-by: Stefan Wahren Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- .../vc04_services/bcm2835-camera/mmal-msg-format.h | 95 ---

Re: [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

On Sat, Jun 29, 2019 at 03:57:22PM +0530, Hariprasad Kelam wrote: Please ignore this patch > fix below issues reported by checkpatch > > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > --- >

[PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 09/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_phy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

You sent 10 patches with the same subject. Btw, I can't recall ever seeing a bug caused by a true false comparison. I agree on style principles with the checkpatch warning, but I do think it over states the risk (which is as far as I can see is zero). regards, dan carpenter

Re: [PATCH 00/31] staging: bcm2835-camera: Improvements

Hi Dave, Am 28.06.19 um 19:29 schrieb Dave Stevenson: > Hi Stefan > > Could you try running > v4l2-ctl -v width=640,height=480,pixelformat=YU12 > before running v4l2-compliance? The default format is JPEG, and I just > wonder if there is an issue lurking in the compression side. yes, this is

[PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 06/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 05/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 04/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 03/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

good day

I am Vice Chairman of Hang Seng Bank, I have Important Matter to Discuss with you concerning my late client, Died without a NEXT OF KIN. Send me your private email for full details information. email me at (infocar...@aim.com) Mail:infocar...@aim.com Regards Dr.Raymond Chien Kuo Fung

Re: [PATCH] staging: erofs: don't check special inode layout

On 2019/6/28 12:19, Yue Hu wrote: > On Fri, 28 Jun 2019 11:50:21 +0800 > Gao Xiang wrote: > >> Hi Yue, >> >> On 2019/6/28 11:42, Yue Hu wrote: >>> From: Yue Hu >>> >>> Currently, we will check if inode layout is compression or inline if >>> the inode is special in fill_inode(). Also set