On 2019-07-06 12:02:53 [+0200], Greg Kroah-Hartman wrote:
> On Thu, Jul 04, 2019 at 05:38:00PM +0200, Sebastian Andrzej Siewior wrote:
> > For spinlocks the type spinlock_t should be used instead of "struct
> > spinlock".
>
> Why?
>
> > Use spinlock_t for spinlock's definition.
>
> Why? I
On Fri, 15 Mar 2019 20:18:31 -0700
Greg Kroah-Hartman wrote:
> On Fri, Mar 15, 2019 at 01:01:27PM +, Okash Khawaja wrote:
> > Hi,
> >
> > We have made progress on the items in TODO file of speakup driver in
> > staging directory and wanted to get some clarity on the remaining
> > items.
Hi Brett,
On Sat, Jul 6, 2019 at 3:43 PM Brett Neumeier wrote:
>
> On Sat, Jul 6, 2019 at 4:00 AM Sergio Paracuellos
> wrote:
> > > Out of curiosity, if it's not too complex an answer to go into, what's
> > > the benefit of the staging-next driver? Is there a reason to prefer it
> > > to the
On Sat, Jul 6, 2019 at 4:00 AM Sergio Paracuellos
wrote:
> > Out of curiosity, if it's not too complex an answer to go into, what's
> > the benefit of the staging-next driver? Is there a reason to prefer it
> > to the 4.2 driver?
>
> In terms of stability, the driver which is in staging-next now
Quoting Sergio Paracuellos :
Hi Sergio,
Hi René,
On Fri, Jul 5, 2019 at 10:35 PM René van Dorst wrote:
In commit 802a2f7b2fe3 ("staging: mt7621-pci: factor out
'mt7621_pcie_enable_port' function"), slot = port->slot; line was removed.
Also other dev_err() print parameter was changed from
Hi René,
On Fri, Jul 5, 2019 at 10:35 PM René van Dorst wrote:
>
> In commit 802a2f7b2fe3 ("staging: mt7621-pci: factor out
> 'mt7621_pcie_enable_port' function"), slot = port->slot; line was removed.
> Also other dev_err() print parameter was changed from slot to port->slot.
> So the same
On Thu, Jul 04, 2019 at 05:38:00PM +0200, Sebastian Andrzej Siewior wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
Why?
> Use spinlock_t for spinlock's definition.
Why? I agree it makes the code smaller, but why is this required?
thanks,
greg k-h
On Sat, Jul 06, 2019 at 11:00:19AM +0200, Samuel Thibault wrote:
> Markus Elfring, le sam. 06 juil. 2019 10:15:30 +0200, a ecrit:
> > From: Markus Elfring
> > Date: Sat, 6 Jul 2019 10:03:56 +0200
> >
> > Avoid an extra function call by using a ternary operator instead of
> > a conditional
Markus Elfring, le sam. 06 juil. 2019 10:15:30 +0200, a ecrit:
> From: Markus Elfring
> Date: Sat, 6 Jul 2019 10:03:56 +0200
>
> Avoid an extra function call by using a ternary operator instead of
> a conditional statement.
>
> This issue was detected by using the Coccinelle software.
>
>
Hi Brett,
On Fri, Jul 5, 2019 at 8:44 PM Brett Neumeier wrote:
>
> On Wed, Jun 26, 2019 at 7:45 AM Sergio Paracuellos
> wrote:
> > No problem, I also miss them rewritting code. That is bad :((.
> > > BTW, I applied that on top of your other recent fixes (that ones
> > > you pushed to gregkh
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:48:23 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/octeon/ethernet.c | 9 ++---
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:48:23 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/octeon/ethernet.c | 9 ++---
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:03:56 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/speakup/main.c | 7 +++
1
13 matches
Mail list logo
