Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Gao Xiang
On 2019/7/21 12:05, Al Viro wrote: > On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: > >> It is for debugging use as you said below, mainly for our internal >> testers whose jobs are >> to read kmsg logs and catch kernel problems. sb->s_id (device number) >> maybe not >> straight-for

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Al Viro
On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: > It is for debugging use as you said below, mainly for our internal > testers whose jobs are > to read kmsg logs and catch kernel problems. sb->s_id (device number) > maybe not > straight-forward for them compared with dev_name... Huh? -

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Gao Xiang
Hi Al, On 2019/7/21 6:49, Al Viro wrote: > On Thu, Jul 11, 2019 at 10:57:34PM +0800, Gao Xiang wrote: >> This commit adds erofs super block operations, including (u)mount, >> remount_fs, show_options, statfs, in addition to some private >> icache management functions. > Could you explain what'

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-20 Thread Al Viro
On Thu, Jul 11, 2019 at 10:57:34PM +0800, Gao Xiang wrote: > This commit adds erofs super block operations, including (u)mount, > remount_fs, show_options, statfs, in addition to some private > icache management functions. Could you explain what's the point of this > + /* save the device name

[PATCH] rtl8192_init_priv_variable: null check is missing for kzalloc

2019-07-20 Thread Navid Emamdoost
Allocation for priv->pFirmware may fail, so a null check is necessary. priv->pFirmware is accessed at line 2743. I added the check and made appropriate changes to propagate the errno to the caller. Signed-off-by: Navid Emamdoost --- drivers/staging/rtl8192u/r8192U_core.c | 13 +++-- 1 fi

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-20 Thread Bharath Vedartham
On Fri, Jul 19, 2019 at 08:59:02PM +, Matt Sickler wrote: > >From: Bharath Vedartham > >Changes since v2 > >- Added back PageResevered check as suggested by John Hubbard. > > > >The PageReserved check needs a closer look and is not worth messing > >around with for now. > > > >Matt, Cou

[PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-20 Thread Bharath Vedartham
For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Ira Weiny Cc: John Hub

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-20 Thread Bharath Vedartham
On Fri, Jul 19, 2019 at 02:28:39PM -0700, John Hubbard wrote: > On 7/19/19 1:02 PM, Bharath Vedartham wrote: > > There have been issues with coordination of various subsystems using > > get_user_pages. These issues are better described in [1]. > > > > An implementation of tracking get_user_pages i

[PATCH] staging: mt7621-pci: avoid use 'err' local variable

2019-07-20 Thread Sergio Paracuellos
Function 'mt7621_pcie_request_resources' is using 'err' local variable to get value returned from 'devm_request_pci_bus_resources' and returning after that. This is not needed at all. Instead of that just directly return returned value by the function which is also returning zero on success. Signe