Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Gao Xiang
Hi Greg, On 2019/7/22 13:05, Greg Kroah-Hartman wrote: > On Mon, Jul 22, 2019 at 01:26:16PM +1000, Stephen Rothwell wrote: >> Hi Gao, >> >> On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote: >>> >>> diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h >>> new file mode 100644 >>> index

Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2019 at 01:26:16PM +1000, Stephen Rothwell wrote: > Hi Gao, > > On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote: > > > > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h > > new file mode 100644 > > index ..e418725abfd6 > > --- /dev/null > > +++

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Gao Xiang
Hi Amir, On 2019/7/22 12:39, Amir Goldstein wrote: > On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: >> >> Currently kernel has scattered tagged pointer usages >> hacked by hand in plain code, without a unique and >> portable functionset to highlight the tagged pointer >> itself and wrap these

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Amir Goldstein
On Mon, Jul 22, 2019 at 5:54 AM Gao Xiang wrote: > > Currently kernel has scattered tagged pointer usages > hacked by hand in plain code, without a unique and > portable functionset to highlight the tagged pointer > itself and wrap these hacked code in order to clean up > all over meaningless

Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Stephen Rothwell
Hi Gao, On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote: > > diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h > new file mode 100644 > index ..e418725abfd6 > --- /dev/null > +++ b/fs/erofs/erofs_fs.h > @@ -0,0 +1,316 @@ > +/* SPDX-License-Identifier: GPL-2.0 OR Apache-2.0 */

Re: [PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Gao Xiang
Hi Stephen, On 2019/7/22 11:26, Stephen Rothwell wrote: > Hi Gao, > > On Mon, 22 Jul 2019 10:50:20 +0800 Gao Xiang wrote: >> >> diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h >> new file mode 100644 >> index ..e418725abfd6 >> --- /dev/null >> +++ b/fs/erofs/erofs_fs.h >> @@

[PATCH v3 15/24] erofs: introduce erofs shrinker

2019-07-21 Thread Gao Xiang
This patch adds a dedicated shrinker targeting to free unneeded memory consumed by a number of erofs in-memory data structures. Like F2FS and UBIFS, it also adds: - sbi->umount_mutex to avoid races on shrinker and put_super; - sbi->shrinker_run_no to not revisit recently scanned objects.

[PATCH v3 22/24] erofs: introduce the decompression frontend

2019-07-21 Thread Gao Xiang
This patch introduces the basic inplace fixed-sized output decompression implementation for erofs filesystem. In constant to fixed-sized input compression, it has fixed-sized capacity for each compressed cluster to contain compressed data with the following advantages: 1) improved storage

[PATCH v3 13/24] erofs: add compression indexes support

2019-07-21 Thread Gao Xiang
This patch adds EROFS compression indexes support, including legacy and compacted 2/4B indexes. In addition, it introduces an iterable L2P mapping operation called 'z_erofs_map_blocks_iter'. Compared with 'erofs_map_blocks', it avoids a number of redundant 'release and regrab' processes if they

[PATCH v3 09/24] erofs: support tracepoint

2019-07-21 Thread Gao Xiang
Add basic tracepoints for ->readpage{,s}, ->lookup, ->destroy_inode, fill_inode and map_blocks. Signed-off-by: Gao Xiang --- include/trace/events/erofs.h | 241 +++ 1 file changed, 241 insertions(+) create mode 100644 include/trace/events/erofs.h diff --git

[PATCH v3 11/24] erofs: introduce xattr & posixacl support

2019-07-21 Thread Gao Xiang
This implements xattr and posixacl functionalities. 1) Inline and shared xattrs are introduced for flexibility. Specifically, if the same xattr is used for a large number of inodes or the size of a xattr is so large that unsuitable to inline, a shared xattr will be used instead in xattr

[PATCH v3 24/24] erofs: add document

2019-07-21 Thread Gao Xiang
This documents key features, usage, and on-disk design of erofs. Signed-off-by: Gao Xiang --- Documentation/filesystems/erofs.txt | 211 1 file changed, 211 insertions(+) create mode 100644 Documentation/filesystems/erofs.txt diff --git

[PATCH v3 02/24] erofs: add erofs in-memory stuffs

2019-07-21 Thread Gao Xiang
- erofs_sb_info: contains erofs-specific in-memory information. - erofs_vnode: contains vfs_inode and other fs-specific information. same as super block, the only one in-memory definition exists. - erofs_map_blocks Logical to physical block mapping, used by erofs_map_blocks().

[PATCH v3 18/24] erofs: introduce pagevec for decompression subsystem

2019-07-21 Thread Gao Xiang
For each physical cluster, there is a straight-forward way of allocating a fixed or variable-sized array to record the corresponding file pages for its decompression if we decide to decompress these pages asynchronously (eg. read-ahead case), however it will take variable-sized on-heap memory

[PATCH v3 06/24] erofs: support special inode

2019-07-21 Thread Gao Xiang
This patch adds to support special inode, such as block dev, char, socket, pipe inode. Signed-off-by: Gao Xiang --- fs/erofs/inode.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index

[PATCH v3 07/24] erofs: add directory operations

2019-07-21 Thread Gao Xiang
This adds functions for directory, mainly readdir. Signed-off-by: Gao Xiang --- fs/erofs/dir.c | 147 + 1 file changed, 147 insertions(+) create mode 100644 fs/erofs/dir.c diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c new file mode 100644 index

[PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-21 Thread Gao Xiang
Currently kernel has scattered tagged pointer usages hacked by hand in plain code, without a unique and portable functionset to highlight the tagged pointer itself and wrap these hacked code in order to clean up all over meaningless magic masks. This patch introduces simple generic methods to

[PATCH v3 16/24] erofs: introduce workstation for decompression

2019-07-21 Thread Gao Xiang
This patch introduces another concept used by decompress subsystem called 'workstation'. It can be seen as a sparse array that stores pointers pointed to data structures related to the corresponding physical clusters. All lookups are protected by RCU read lock. Besides, reference count and

[PATCH v3 01/24] erofs: add on-disk layout

2019-07-21 Thread Gao Xiang
This commit adds the on-disk layout header file of erofs. On-disk format is compatible with erofs-staging added in 4.19. In addition, add EROFS_SUPER_MAGIC_V1 to magic.h. Signed-off-by: Gao Xiang --- fs/erofs/erofs_fs.h| 316 +

[PATCH v3 20/24] erofs: introduce generic decompression backend

2019-07-21 Thread Gao Xiang
This patch adds decompression backend to EROFS, which supports uncompressed and LZ4 compressed data. For compressed data, it uses the following strategy: 1) If outputsize is very small (totally less than a threshold), decompress to the per-CPU buffer and do memcpy directly in order to avoid

[PATCH v3 23/24] erofs: introduce cached decompression

2019-07-21 Thread Gao Xiang
This patch adds strategies which can be selected by users in order to cache both incomplete ends of compressed physical clusters as a complement of in-place I/O in order to boost random read, but it costs more memory than the in-place I/O only. Signed-off-by: Gao Xiang --- fs/erofs/Kconfig|

[PATCH v3 21/24] erofs: introduce LZ4 decompression inplace

2019-07-21 Thread Gao Xiang
compressed data will be usually loaded into last pages of the extent (the last page for 4k) for in-place decompression (more specifically, in-place IO), as ilustration below, start of compressed logical extent | end of this logical extent |

[PATCH v3 17/24] erofs: introduce per-CPU buffers implementation

2019-07-21 Thread Gao Xiang
This patch introduces per-CPU buffers in order for the upcoming generic decompression framework to use. Note that I tried to use in-kernel per-CPU buffer or per-CPU page approaches to clean up further, however noticeable performanace regression (about 2% for sequential read) was observed. Let's

[PATCH v3 05/24] erofs: add inode operations

2019-07-21 Thread Gao Xiang
This adds core functions to get, read an inode. It adds statx support as well. Signed-off-by: Gao Xiang --- fs/erofs/inode.c | 291 +++ 1 file changed, 291 insertions(+) create mode 100644 fs/erofs/inode.c diff --git a/fs/erofs/inode.c

[PATCH v3 19/24] erofs: add erofs_allocpage()

2019-07-21 Thread Gao Xiang
This patch introduces an temporary _on-stack_ page pool to reuse the freed page directly as much as it can for better performance and release all pages at a time, it also slightly reduces the possibility of the potential memory allocation failure. Signed-off-by: Gao Xiang ---

[PATCH v3 04/24] erofs: add raw address_space operations

2019-07-21 Thread Gao Xiang
This commit adds functions for meta and raw data, and also provides address_space_operations for raw data access. Signed-off-by: Gao Xiang --- fs/erofs/data.c | 423 1 file changed, 423 insertions(+) create mode 100644 fs/erofs/data.c diff

[PATCH v3 08/24] erofs: add namei functions

2019-07-21 Thread Gao Xiang
This commit adds functions that transfer names to inodes. Signed-off-by: Gao Xiang --- fs/erofs/namei.c | 246 +++ 1 file changed, 246 insertions(+) create mode 100644 fs/erofs/namei.c diff --git a/fs/erofs/namei.c b/fs/erofs/namei.c new file mode

[PATCH v3 00/24] erofs: promote erofs from staging

2019-07-21 Thread Gao Xiang
Changelog from v2: o kill sbi->dev_name and clean up all failure handling in fill_super() suggested by Al. Note that the initialzation of managed_cache is now moved after s_root is assigned since it's more preferred to iput() in .put_super() and all inodes should be evicted before

[PATCH v3 10/24] erofs: update Kconfig and Makefile

2019-07-21 Thread Gao Xiang
This commit adds Makefile and Kconfig for erofs, and updates Makefile and Kconfig files in the fs directory. Signed-off-by: Gao Xiang --- fs/Kconfig| 1 + fs/Makefile | 1 + fs/erofs/Kconfig | 45 + fs/erofs/Makefile | 9 + 4

[PATCH v3 14/24] erofs: introduce superblock registration

2019-07-21 Thread Gao Xiang
In order to introducing shrinker solution for erofs, let's manage all mounted erofs instances at first. Signed-off-by: Gao Xiang --- fs/erofs/Makefile | 2 +- fs/erofs/internal.h | 13 + fs/erofs/super.c| 9 + fs/erofs/utils.c| 32

[PATCH v3 03/24] erofs: add super block operations

2019-07-21 Thread Gao Xiang
This commit adds erofs super block operations, including (u)mount, remount_fs, show_options, statfs, in addition to some private icache management functions. Signed-off-by: Gao Xiang --- fs/erofs/super.c | 438 +++ 1 file changed, 438 insertions(+)

Re: [PATCH v2 03/24] erofs: add super block operations

2019-07-21 Thread Gao Xiang
On 2019/7/21 ??12:12, Gao Xiang wrote: > > > On 2019/7/21 12:05, Al Viro wrote: >> On Sun, Jul 21, 2019 at 11:08:42AM +0800, Gao Xiang wrote: >> >>> It is for debugging use as you said below, mainly for our internal >>> testers whose jobs are >>> to read kmsg logs and catch kernel

[PATCH] staging: rtl8723bs: remove unused file hal_phy.c

2019-07-21 Thread Michael Straube
Remove the unused file hal_phy.c. No function from this file is used in the driver code and it is not listed in the Makefile. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_phy.c | 157 1 file changed, 157 deletions(-) delete mode 100644

[PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'

2019-07-21 Thread Christophe JAILLET
Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has updated the parameters of 'poll_for_irq()' but not the comment above the function. Update the comment and fix a typo. s/visronic/visornic/ Signed-off-by: Christophe JAILLET --- drivers/staging/unisys/visornic/visornic_main.c

Re: [PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings.

2019-07-21 Thread Hennie Muller
On Sun, Jul 21, 2019 at 11:29:19AM +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 21, 2019 at 11:13:26AM +0200, Hennie Muller wrote: > > Reindent multiline function calls to be tab aligned, instead of open brace > > aligned. This fixes multiple "WARNING: line over 80 characters" generated > > by

[PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings.

2019-07-21 Thread Hennie Muller
Reindent multiline function calls to be tab aligned, instead of open brace aligned. This fixes multiple "WARNING: line over 80 characters" generated by checkpatch. Signed-off-by: Hennie Muller --- drivers/staging/wlan-ng/cfg80211.c| 55 ++--- drivers/staging/wlan-ng/hfa384x_usb.c | 282

Re: [PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings.

2019-07-21 Thread Greg Kroah-Hartman
On Sun, Jul 21, 2019 at 11:13:26AM +0200, Hennie Muller wrote: > Reindent multiline function calls to be tab aligned, instead of open brace > aligned. This fixes multiple "WARNING: line over 80 characters" generated > by checkpatch. > > Signed-off-by: Hennie Muller > --- >