Re: [PATCH 3/5] dt: bindings: add mt7621-pll dt binding documentation

2019-07-22 Thread Stephen Boyd
Quoting Chuanhong Guo (2019-07-09 11:20:16) > This commit adds device tree binding documentation for MT7621 > PLL controller. > > Signed-off-by: Chuanhong Guo > --- > .../bindings/clock/mediatek,mt7621-pll.txt| 19 +++ > 1 file changed, 19 insertions(+) > create mode 100644

Re: [PATCH 2/5] MIPS: ralink: fix cpu clock of mt7621 and add dt clk devices

2019-07-22 Thread Stephen Boyd
Quoting Chuanhong Guo (2019-07-09 11:20:15) > For a long time the mt7621 uses a fixed cpu clock which causes a problem > if the cpu frequency is not 880MHz. > > This patch fixes the cpu clock calculation and adds the cpu/bus clkdev > which will be used in dts. > > Ported from OpenWrt: > c7ca22429

Re: [PATCH 1/5] MIPS: ralink: add dt binding header for mt7621-pll

2019-07-22 Thread Stephen Boyd
The subject of this patch is confusing. Not sure what it has to do with "MIPS:" so maybe remove that and prefix it "dt-bindings: clock:" instead. Quoting Chuanhong Guo (2019-07-09 11:20:14) > This patch adds dt binding header for mediatek,mt7621-pll > > Signed-off-by: Weijie Gao > Signed-off-by:

[PATCH v2] staging: wilc1000: flush the workqueue before deinit the host

2019-07-22 Thread Adham.Abozaeid
From: Adham Abozaeid Before deinitializing the host interface, the workqueue should be flushed to handle any pending deferred work Signed-off-by: Adham Abozaeid --- changes in v2: - Regenerated patch from branch's head drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed,

[PATCH] staging: wilc1000: flush the workqueue before deinit the host ifc

2019-07-22 Thread Adham.Abozaeid
From: Adham Abozaeid Before deinitializing the host interface, the workqueue should be flushed to handle any pending deferred work Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wi

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Gao Xiang
On 2019/7/23 12:35, Steven Rostedt wrote: > On Mon, 22 Jul 2019 23:33:53 +0800 > Gao Xiang wrote: > >> Hi Steven, >> >> On 2019/7/22 10:40, Steven Rostedt wrote: > and I'm not sure Al could accept __fdget conversion (I just wanted to > give a example then...) > > There

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
On 2019/7/22 11:12, Theodore Y. Ts'o wrote: > On Mon, Jul 22, 2019 at 10:16:44PM +0800, Gao Xiang wrote: >> OK, I will give a try. One point I think is how to deal with the case >> if there is already cached information when remounting as well as you said. >> >> As the first step, maybe the

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Steven Rostedt
On Mon, 22 Jul 2019 23:33:53 +0800 Gao Xiang wrote: > Hi Steven, > > On 2019/7/22 10:40, Steven Rostedt wrote: > >>> and I'm not sure Al could accept __fdget conversion (I just wanted to > >>> give a example then...) > >>> > >>> Therefore, I tend to keep silence and just promote EROFS... so

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Sakari Ailus
On Mon, Jul 22, 2019 at 07:14:08PM +0530, Nishka Dasgupta wrote: > On 22/07/19 5:54 PM, Paul Kocialkowski wrote: > > Hi, > > > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > > Typecast as bool the return value of cedrus_find_for

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Gao Xiang
Hi Steven, On 2019/7/22 10:40, Steven Rostedt wrote: >>> and I'm not sure Al could accept __fdget conversion (I just wanted to give >>> a example then...) >>> >>> Therefore, I tend to keep silence and just promote EROFS... some better >>> ideas?... >>> >> Writing example conversion patches

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 10:16:44PM +0800, Gao Xiang wrote: > OK, I will give a try. One point I think is how to deal with the case > if there is already cached information when remounting as well as you said. > > As the first step, maybe the mount option can be defined as > allowing/forbiding cachi

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Paul Kocialkowski
Hi, On Mon 22 Jul 19, 19:14, Nishka Dasgupta wrote: > On 22/07/19 5:54 PM, Paul Kocialkowski wrote: > > Hi, > > > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > > Typecast as bool the return value of cedrus_find_format in > > >

Re: [PATCH v3 12/24] erofs: introduce tagged pointer

2019-07-22 Thread Steven Rostedt
On Mon, 22 Jul 2019 09:16:22 +0300 Amir Goldstein wrote: > CC kernel/trace maintainers for RB_PAGE_HEAD/RB_PAGE_UPDATE > and kernel/locking maintainers for RT_MUTEX_HAS_WAITERS Interesting. > > > (Is there some use scenerios in overlayfs and fanotify?...) > > We had one in overlayfs once. I

Re: [PATCH v6 0/5] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-07-22 Thread Hans Verkuil
On 7/22/19 3:17 PM, Paul Kocialkowski wrote: > Hi, > > Any feedback on this series? I think it was pretty much ready for merge > regarding the comments received so far. > > I could craft a rebased v7, with or without additional changes, if needed. Just gave feedback. A v7 is needed in any case s

Re: [PATCH v6 3/5] media: v4l: Add definitions for the HEVC slice controls

2019-07-22 Thread Hans Verkuil
On 6/14/19 4:38 PM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slices extracted from the bitstream. > > They are not exported to

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
Hi Ted, On 2019/7/22 9:25, Theodore Y. Ts'o wrote, > On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: >>> The number of individual Kconfig options is quite high, are you sure you >>> need them to be split like that? >> >> You mean the above? these are 3 cache strategies, which impact

[PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

2019-07-22 Thread YueHaibing
If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUPPORT" in the Kconfig, for example, CONFIG_TEGRA_VDE is set to y but IOMMU_IOVA is m, then the building fails like this: drivers/staging/media/tegra-vde/iommu.o: In fun

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Nishka Dasgupta
On 22/07/19 5:54 PM, Paul Kocialkowski wrote: Hi, On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated l

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Theodore Y. Ts'o
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote: > > The number of individual Kconfig options is quite high, are you sure you > > need them to be split like that? > > You mean the above? these are 3 cache strategies, which impact the > runtime memory consumption and performance. I tend t

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Jeremy Sowden
On 2019-07-22, at 14:24:38 +0200, Paul Kocialkowski wrote: > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > > Typecast as bool the return value of cedrus_find_format in > > > cedrus_check_format as the return value of cedrus_check_form

Re: [PATCH v6 0/5] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-07-22 Thread Paul Kocialkowski
Hi, Any feedback on this series? I think it was pretty much ready for merge regarding the comments received so far. I could craft a rebased v7, with or without additional changes, if needed. What do you think? Cheers, Paul On Fri 14 Jun 19, 16:38, Paul Kocialkowski wrote: > This is early supp

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Paul Kocialkowski
Hi, On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > > Typecast as bool the return value of cedrus_find_format in > > cedrus_check_format as the return value of cedrus_check_format is > > always treated like a boolean value. > > > > Signed-

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-22 Thread Jeremy Sowden
On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: > Typecast as bool the return value of cedrus_find_format in > cedrus_check_format as the return value of cedrus_check_format is > always treated like a boolean value. > > Signed-off-by: Nishka Dasgupta > --- > Changes in v2: > - Add !! to t

[PATCH 11/22] docs: isdn: convert to ReST and add to kAPI bookset

2019-07-22 Thread Mauro Carvalho Chehab
The ISDN documentation is a mix of admin guide, uAPI and kAPI. Ideally, it should be split. Yet, not sure if it would worth the troble. Anyway, we have the same kind of mix on several drivers specific documentation. So, just like the others, keep the directory at the root Documentation/ tree, just

[PATCH 00/22] ReST conversion of text files without .txt extension

2019-07-22 Thread Mauro Carvalho Chehab
This series converts the text files under Documentation with doesn't end neither .txt or .rst and are not part of ABI or features[1]. This series is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=rst_for_5_4_v2.1 And comes after the pending patches I had for v5.13 (some not a

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread Gao Xiang
Hi David, On 2019/7/22 6:18, David Sterba wrote: > On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: >> +choice >> +prompt "EROFS Data Decompression mode" >> +depends on EROFS_FS_ZIP >> +default EROFS_FS_ZIP_CACHE_READAROUND >> +help >> + EROFS supports three opti

Re: [PATCH 4/4] ipvs: reduce kernel stack usage

2019-07-22 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 9:59 PM Willem de Bruijn wrote: > On Fri, Jun 28, 2019 at 8:40 AM Arnd Bergmann wrote: > > > > With the new CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL option, the stack > > usage in the ipvs debug output grows because each instance of > > IP_VS_DBG_BUF() now has its own buffer

Re: [PATCH v3 23/24] erofs: introduce cached decompression

2019-07-22 Thread David Sterba
On Mon, Jul 22, 2019 at 10:50:42AM +0800, Gao Xiang wrote: > +choice > + prompt "EROFS Data Decompression mode" > + depends on EROFS_FS_ZIP > + default EROFS_FS_ZIP_CACHE_READAROUND > + help > + EROFS supports three options for decompression. > + "In-place I/O Only" cons

Re: [PATCH 4/4] ipvs: reduce kernel stack usage

2019-07-22 Thread Arnd Bergmann
On Sun, Jun 30, 2019 at 10:37 PM Julian Anastasov wrote: > On Fri, 28 Jun 2019, Arnd Bergmann wrote: > > struct ip_vs_conn *ctl_cp = cp->control; > > if (!ctl_cp) { > > - IP_VS_ERR_BUF("request control DEL for uncontrolled: " > > - "%s:%d to %s:%d

Re: [OSSNA] Intro to kernel hacking tutorial

2019-07-22 Thread Tobin C. Harding
On Fri, Jul 19, 2019 at 12:36:58PM +0300, Dan Carpenter wrote: > On Fri, Jul 05, 2019 at 12:50:55PM +1000, Tobin C. Harding wrote: > > Outcome will (hopefully) be a small patch set into drivers/staging/. > > (Don't worry Greg only one group got to this stage last time, you > > won't get flooded wit

[PATCH 5/8] staging: rtl8712: init_mp_priv(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change return values of init_mp_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Remove label that returns the required value and return the values directly as they are set. Consequently remove now-unnecessary return variable. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x

[PATCH 1/8] staging: rtl8712: r8712_init_mlme_priv(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change return values of r8712_init_mlme_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Modify call site accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/os_intfs.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletio

[PATCH 2/8] staging: rtl8712: r8712_set_auth(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change return values of r8712_set_auth from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Modify call site accordingly. Also change return type of the function from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 6 +++--- drivers/staging/rtl8712/rtl871

[PATCH 8/8] staging: rtl8712: r8712_free_recvframe(): Change return type

2019-07-22 Thread Nishka Dasgupta
Change return type of r8712_free_recvframe from int to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- drivers/staging/rtl8712/rtl871x_recv.h | 2 +- 2 files changed, 2 insertions(+), 3 dele

[PATCH 4/8] staging: rtl8712: r8712_register_cmd_alive(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change return values of r8712_register_cmd_alive from _SUCCESS and _FAIL to 0 and -EINVAL. Change the return type of this function from sint to int. Modify its call site to check for 0 instead of _SUCCESS. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- driv

[PATCH 7/8] staging: rtl8712: r8712_init_recvbuf(): Change return type

2019-07-22 Thread Nishka Dasgupta
Change return type of r8712_init_recvbuf from int to void as it always returned _SUCCESS and this return value was never used at any call site. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- drivers/staging/rtl8712/rtl8712_recv.h | 2 +- 2 files changed, 2 ins

[PATCH 6/8] staging: rtl8712: r8712_set_802_11_add_wep(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change call sites of r8712_set_802_11_add_wep to check for 0 and non-zero values (e.g -EINVAL, -ENOMEM) instead of for _SUCCESS and _FAIL. Change return values of r8712_set_802_11_add_wep from true and false and _SUCCESS to -EINVAL and the return value of r8712_set_key. Change return type from u8 t

[PATCH 3/8] staging: rtl8712: r8712_set_key(): Change return values

2019-07-22 Thread Nishka Dasgupta
Change return values of r8712_set_key from _SUCCESS and _FAIL to 0 and -ENOMEM or -EINVAL, as the case may require. Modify return statements and return variable accordingly. Change return type from sint to int. As there is only one site where the return value is used, update that call site accordin

[PATCH RESEND] staging: media: davinci_vpfe: Replace function vpfe_isif_cleanup()

2019-07-22 Thread Nishka Dasgupta
Rename function isif_remove to vpfe_isif_cleanup, as vpfe_isif_cleanup does nothing but call isif_remove. Change type of new vpfe_isif_cleanup from static to non-static to match the old function definition. Remove the original vpfe_isif_cleanup. Modify calls to isif_remove to vpfe_isif_cleanup. Iss

Re: [PATCH] staging: media/davinci_vpfe: fix pinmux setup compilation

2019-07-22 Thread Sekhar Nori
Hi Arnd, On 22/07/19 1:42 PM, Arnd Bergmann wrote: > The dm365_isif staging driver uses an odd method for configuring its > pin muxing by calling directly into low-level davinci platform specific > code, even when being compile-tested for other platforms. > > As we want davinci to be part of a mu

[PATCH] staging: media/davinci_vpfe: fix pinmux setup compilation

2019-07-22 Thread Arnd Bergmann
The dm365_isif staging driver uses an odd method for configuring its pin muxing by calling directly into low-level davinci platform specific code, even when being compile-tested for other platforms. As we want davinci to be part of a multi-platform kernel, this will cause a build failure when thos

[driver-core:debugfs_cleanup 26/49] fs/ocfs2/dlmglue.c:3291:30: error: void value not ignored as it ought to be

2019-07-22 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup head: 7ea1b1929a3f463169713ae38bcacf4966e756af commit: 54d5611ad33f517de1bfe958b22f57822743aebb [26/49] debugfs: remove return value of debugfs_create_u32() config: x86_64-lkp (attached as .

Re: [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'

2019-07-22 Thread Enrico Weigelt, metux IT consult
On 21.07.19 19:08, Christophe JAILLET wrote: Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has updated the parameters of 'poll_for_irq()' but not the comment above the function. Update the comment and fix a typo. s/visronic/visornic/ Signed-off-by: Christophe JAILLET ---

Re: [PATCH] staging: unisys: visornic: Update the description of 'poll_for_irq()'

2019-07-22 Thread Enrico Weigelt, metux IT consult
On 21.07.19 19:08, Christophe JAILLET wrote: Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has updated the parameters of 'poll_for_irq()' but not the comment above the function. Update the comment and fix a typo. s/visronic/visornic/ Signed-off-by: Christophe JAILLET ---