Re: [HELP REQUESTED from the community] Was: Staging status of speakup

On Thu, Jul 25, 2019 at 08:11:04AM +0200, Willem van der Walt wrote: > Hi, > I have added a few things inline in Greg's message, mainly regarding the > bleeps and cursor_time. This is a great start, can someone turn this into the correct format that we need for Documentation/ABI/ ? thanks, greg

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

On 7/24/19 7:09 PM, Joe Perches wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Joe Perches >> --- >> drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

Hi, I have added a few things inline in Greg's message, mainly regarding the bleeps and cursor_time. FWIW, Willem On Wed, 24 Jul 2019, Gregory Nowak wrote: [The e-mail server of the sender could not be verified (SPF Record)] On Fri, Jul 12, 2019 at 05:46:23PM -0700, Gregory Nowak wrote: On

[PATCH 9/9] staging: rtl8723bs: Remove unused function prototype ODM_SetAntenna()

Remove unused function prototype ODM_SetAntenna. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/odm.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index 6ba77bb70889..fba3b9e1491b 100644 --- a/

[PATCH 8/9] staging: rtl8723bs: Replace function ODM_TXPowerTrackingCheck()

Remove function ODM_TXPowerTrackingCheck as all it does is call odm_TXPowerTrackingCheckCE. Rename odm_TXPowerTrackingCheckCE to ODM_TXPowerTrackingCheck to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/odm.c

[PATCH 3/9] staging: rtl8723bs: hal: Replace function PHY_GetTxPowerIndex()

Remove function PHY_GetTxPowerIndex as it does nothing except call PHY_GetTxPowerIndex_8723B. Rename PHY_GetTxPowerIndex_8723B to PHY_GetTxPowerIndex to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_com_ph

[PATCH 7/9] staging: rtl8723bs: Replace function odm_TXPowerTrackingInit()

Remove function odm_TXPowerTrackingInit as all it does is call odm_TXPowerTrackingThermalMeterInit. Rename odm_TXPowerTrackingThermalMeterInit to odm_TXPowerTrackingInit to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl

[PATCH 6/9] staging: rtl8723bs: Replace function beacon_timing_control()

Remove function beacon_timing_control as it does nothing except call rtw_hal_bcn_related_reg_setting. Rename rtw_hal_bcn_related_reg_setting to beacon_timing_control to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723b

[PATCH 5/9] staging: rtl8723bs: hal: Replace function rtl8723b_set_ap_wowlan_cmd()

Remove function rtl8723b_set_ap_wowlan_cmd as all it does is call rtl8723b_set_AP_FwWoWlanRelated_cmd. Rename rtl8723b_set_AP_FwWoWlanRelated_cmd to rtl8723b_set_ap_wowlan_cmd to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/stagin

[PATCH 2/9] staging: rtl8723bs: hal: Replace function PHY_SetTxPowerIndex()

Remove function PHY_SetTxPowerIndex as it does nothing except call PHY_SetTxPowerIndex_8723B. Rename PHY_SetTxPowerIndex_8723B to PHY_SetTxPowerIndex to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_com_ph

[PATCH 1/9] staging: rtl8723bs: rtw_pwrctrl: Change true/false checks

Change comparisons to true to the variable itself. Change comparisons to false to the negation of the variable. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 117 +-- 1 file changed, 54 insertions(+), 63 deletions(-) diff --git a/drivers/stagi

[PATCH 4/9] staging: rtl8723bs: hal: Replace function rtl8723b_set_wowlan_cmd()

Remove function rtl8723b_set_wowlan_cmd as all it does is call rtl8723b_set_FwWoWlanRelated_cmd. Rename rtl8723b_set_FwWoWlanRelated_cmd to rtl8723b_set_wowlan_cmd to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/

[PATCH] staging: comedi: daqboard2000: Remove function db2k_initialize_dac()

Remove function db2k_initialize_dac as all it does is call db2k_dac_disarm. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/comedi/drivers/daqboard2000.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/driver

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

Gregory Nowak writes: > keymap > I believe this is the currently active kernel keymap. I'm not sure of > the format, probably what dumpkeys(1) and showkey(1) use. Echoing > different values here should allow for remapping speakup's review > commands besides remapping the keyboard as a whole. AFA

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

On Fri, Jul 12, 2019 at 05:46:23PM -0700, Gregory Nowak wrote: > On Fri, Jul 12, 2019 at 11:23:19AM +0200, Samuel Thibault wrote: > > Hello, > > > > To readers of the linux-speakup: could you help on this so we can get > > Speakup in mainline? Neither Okash or I completely know what user > > cons

[PATCH] staging: rtl8723bs: hal: Remove unneeded variable pU1Tmp

Both pu8 and pU1Tmp are of same data type u8. So replace pU1Tmp with u8. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging

[PATCH] staging: media: hantro: Remove call to memset after dma_alloc_coherent

fix below issue reported by coccicheck /drivers/staging/media/hantro/hantro_vp8.c:149:16-34: WARNING: dma_alloc_coherent use in aux_buf -> cpu already zeroes out memory, so memset is not needed Signed-off-by: Hariprasad Kelam --- drivers/staging/media/hantro/hantro_vp8.c | 2 -- 1 file changed,

[PATCH v2] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- Changes in v2: - Merge the previous two patches which have the same subject line. drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/st

[PATCH v2] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- drivers/staging/wilc1000/wilc_wlan.c

[PATCH] media: staging: tegra-vde: Fix build error

If IOMMU_SUPPORT is not set, and COMPILE_TEST is y, IOMMU_IOVA may be set to m. So building will fails: drivers/staging/media/tegra-vde/iommu.o: In function `tegra_vde_iommu_map': iommu.c:(.text+0x41): undefined reference to `alloc_iova' iommu.c:(.text+0x56): undefined reference to `__free_iova'

Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET

From: YueHaibing Date: Wed, 24 Jul 2019 21:01:26 +0800 > Now if CONFIG_ETHERNET is not set, QLGE driver > building fails: > > drivers/staging/qlge/qlge_main.o: In function `qlge_remove': > drivers/staging/qlge/qlge_main.c:4831: undefined reference to > `unregister_netdev' > > Reported-by: Hulk

Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET

From: David Miller Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT) > From: YueHaibing > Date: Wed, 24 Jul 2019 21:01:26 +0800 > >> Now if CONFIG_ETHERNET is not set, QLGE driver >> building fails: >> >> drivers/staging/qlge/qlge_main.o: In function `qlge_remove': >> drivers/staging/qlge/qlge_main.

Re: Limits for ION Memory Allocator

On Wed, Jul 24, 2019 at 1:18 PM John Stultz wrote: > > On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote: > > > > On 7/17/19 12:31 PM, Alexander Popov wrote: > > > Hello! > > > > > > The syzkaller [1] has a trouble with fuzzing the Linux kernel with ION > > > Memory > > > Allocator. > > > > >

Re: Limits for ION Memory Allocator

On Wed, Jul 24, 2019 at 12:36 PM Laura Abbott wrote: > > On 7/17/19 12:31 PM, Alexander Popov wrote: > > Hello! > > > > The syzkaller [1] has a trouble with fuzzing the Linux kernel with ION > > Memory > > Allocator. > > > > Syzkaller uses several methods [2] to limit memory consumption of the >

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/sunx

Re: Limits for ION Memory Allocator

On 7/17/19 12:31 PM, Alexander Popov wrote: Hello! The syzkaller [1] has a trouble with fuzzing the Linux kernel with ION Memory Allocator. Syzkaller uses several methods [2] to limit memory consumption of the userspace processes calling the syscalls for testing the kernel: - setrlimit(), -

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

On Wed, Jul 24, 2019 at 11:39:03AM -0700, Joe Perches wrote: > On Wed, 2019-07-24 at 20:35 +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 24, 2019 at 10:09:44AM -0700, Joe Perches wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > Arguments are supposed to be ordered high

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

On Wed, 2019-07-24 at 20:35 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 24, 2019 at 10:09:44AM -0700, Joe Perches wrote: > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > Arguments are supposed to be ordered high then low. > > > > > > Signed-off-by: Joe Perches > > > --- > > > d

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

On Wed, Jul 24, 2019 at 10:09:44AM -0700, Joe Perches wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Joe Perches > > --- > > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > > 1 file changed,

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

24.07.2019 17:23, Robin Murphy пишет: > On 24/07/2019 15:09, Dmitry Osipenko wrote: >> 24.07.2019 17:03, Yuehaibing пишет: >>> On 2019/7/24 21:49, Robin Murphy wrote: On 24/07/2019 11:30, Sakari Ailus wrote: > Hi Yue, > > On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote:

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

On 24/07/2019 15:09, Dmitry Osipenko wrote: 24.07.2019 17:03, Yuehaibing пишет: On 2019/7/24 21:49, Robin Murphy wrote: On 24/07/2019 11:30, Sakari Ailus wrote: Hi Yue, On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

24.07.2019 17:03, Yuehaibing пишет: > On 2019/7/24 21:49, Robin Murphy wrote: >> On 24/07/2019 11:30, Sakari Ailus wrote: >>> Hi Yue, >>> >>> On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. But for many drive

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

On 2019/7/24 21:49, Robin Murphy wrote: > On 24/07/2019 11:30, Sakari Ailus wrote: >> Hi Yue, >> >> On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: >>> If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. >>> But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUP

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

On 24/07/2019 11:30, Sakari Ailus wrote: Hi Yue, On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUPPORT" in the Kconfig, for example, CONFIG_TEGRA_VDE is

[PATCH] qlge: Fix build error without CONFIG_ETHERNET

Now if CONFIG_ETHERNET is not set, QLGE driver building fails: drivers/staging/qlge/qlge_main.o: In function `qlge_remove': drivers/staging/qlge/qlge_main.c:4831: undefined reference to `unregister_netdev' Reported-by: Hulk Robot Fixes: 955315b0dc8c ("qlge: Move drivers/net/ethernet/qlogic/qlge

[PATCH] media: staging/intel-ipu3: Use dev_get_drvdata where possible

Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/staging/media/ipu3/ipu3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c

Re: [PATCH] media: staging: davinci: remove vpfe driver

On Tue, Jul 23, 2019 at 11:46 AM Arnd Bergmann wrote: > > The davinci_vpfe driver was merged into staging back in 2012 by Manjunath > Hadli from TI, with a long TODO list. > > For all I can tell, since then it has only seen fixes for compile-time > issues and global cleanups, but nobody has actual

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

Hi Yue, On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: > If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. > But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUPPORT" > in the Kconfig, for example, CONFIG_TEGRA_VDE is set to y but IOMMU_IOVA > is m, then t