[PATCH 4/9] staging: rtl8712: r8712_os_recvbuf_resource_alloc(): Change return values

2019-08-01 Thread Nishka Dasgupta
Change return values of r8712_os_recvbuf_resource_alloc from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Modify check at call site to check for non-zero return value instead of _FAIL. Thereafter remove variable at call site that stored the return value and perform the check directly. Signed-off-by:

[PATCH 6/9] staging: rtl8712: r8712_tkip_decrypt(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of r8712_tkip_decrypt from u8 to void as the return value is never used. Modify or remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 12 ++-- drivers/staging/rtl8712/rtl871x_security.h | 2 +- 2 files

[PATCH 5/9] staging: rtl8712: r8712_os_recvbuf_resource_free(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of r8712_os_recvbuf_resource_free from int to void as it always returns _SUCCESS and this return value is never stored, checked or otherwise used. Remove return statement accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_linux.c | 5 ++--- drivers/st

[PATCH 2/9] staging: rtl8712: _r8712_init_recv_priv(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of _r8712_init_recv_priv as its return value is never checked or used. Modify return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_osdep.h | 2 +- drivers/staging/rtl8712/rtl871x_recv.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH 1/9] staging: rtl8712: r8712_os_recv_resource_alloc(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of function r8712_os_recv_resource_alloc from int to void as its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_linux.c | 5 ++--- drivers/staging/rtl8712/recv_osdep.h | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 8/9] staging: rtl8712: aes_decipher(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of aes_decipher from sint to void as it always returns _SUCCESS and this value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_

[PATCH 7/9] staging: rtl8712: aes_cipher(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of aes_cipher from sint to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8

[PATCH 3/9] staging: rtl8712: r8712_init_recv_priv(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of r8712_init_recv_priv from int to void as its return value is never used. Remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_osdep.h | 4 ++-- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- 2 files changed, 3 insertions(+

[PATCH 9/9] staging: rtl8712: r8712_aes_decrypt(): Change return type

2019-08-01 Thread Nishka Dasgupta
Change return type of r8712_aes_decrypt from u8 to void as its return value is never checked. Modify return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 7 ++- drivers/staging/rtl8712/rtl871x_security.h | 2 +- 2 files changed, 3 ins

Re: [PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-01 Thread Jens Wiklander
On Fri, Aug 2, 2019 at 4:20 AM wrote: > > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7

[PATCH 2/4] staging: rtl8723bs: Change return type of hal_btcoex_IsBtControlLps()

2019-08-01 Thread Nishka Dasgupta
Change return type of hal_btcoex_IsBtControlLps from u8 to bool as it only returns boolean values. Change comparison to false within this function; check the boolean variable directly instead. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ++-- drivers/sta

[PATCH 3/4] staging: rtl8723bs: Change return type of hal_btcoex_IsLpsOn()

2019-08-01 Thread Nishka Dasgupta
Change return type of hal_btcoex_IsLpsOn from u8 to bool as the function only returns boolean values. Modify a comparison of a boolean value to false to instead check that boolean value directly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ++-- drivers/

[PATCH 1/4] staging: rtl8723bs: Change return type of hal_btcoex_IsBtExist()

2019-08-01 Thread Nishka Dasgupta
Change return type of hal_btcoex_IsBtExist from u8 to bool as its only possible return values are true and false. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/hal_btcoex.h | 2 +- 2 files changed, 2 insertions(+), 2 d

[PATCH 4/4] staging: rtl8723bs: Replace hal_btcoex_Initialize()

2019-08-01 Thread Nishka Dasgupta
Remove hal_btcoex_Initialize as all it does is perform a memset and call EXhalbtcoutsrc_InitlizeVariables. Rename EXhalbtcoutsrc_InitlizeVariables to hal_btcoex_Initialize and add the memset of hal_btcoex_Initialize in order to maintain compatibility with call sites of the latter (EXhalbtcoutsrc is

Re: [PATCH] Add default binder devices through binderfs when configured

2019-08-01 Thread Greg Kroah-Hartman
On Thu, Aug 01, 2019 at 03:35:56PM -0700, Hridya Valsaraju wrote: > If CONFIG_ANDROID_BINDERFS is set, the default binder devices > specified by CONFIG_ANDROID_BINDER_DEVICES are created in each > binderfs instance instead of global devices being created by > the binder driver. > > Co-developed-by

[PATCH] staging: wlan-ng: Remove function prism2mib_excludeunencrypted()

2019-08-01 Thread Nishka Dasgupta
Remove function prism2mib_excludeunencrypted as all it does is call prism2mib_flag. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/prism2mib.c | 44 + 1 file changed, 1 insertion(+), 43 deletions(

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-01 Thread John Hubbard
On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -611,15 +611,10 @@ stat

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-01 Thread Juergen Gross
On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cc

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-01 Thread John Hubbard
On 8/1/19 7:16 PM, john.hubb...@gmail.com wrote: > From: John Hubbard > > Hi, > > These are best characterized as miscellaneous conversions: many (not all) > call sites that don't involve biovec or iov_iter, nor mm/. It also leaves > out a few call sites that require some more work. These are mo

[PATCH 28/34] mm/madvise.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 32/34] goldfish_pipe: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 29/34] mm/process_vm_access.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 25/34] mm/frame_vector.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 22/34] orangefs: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 30/34] crypt: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 23/34] uprobes: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 33/34] kernel/events/core.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 14/34] oradax: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 34/34] fs/binfmt_elf: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: Ira Weiny For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder vers

[PATCH 31/34] nfs: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 27/34] mm/memory.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 21/34] fs/exec.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 09/34] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 12/34] vmci: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 18/34] fbdev/pvr2fb: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 07/34] drm/radeon: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 13/34] rapidio: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 24/34] futex: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 11/34] scif: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-01 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*() varia

[PATCH 10/34] genwqe: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 17/34] vfio: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 15/34] staging/vc04_services: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 08/34] media/ivtv: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 19/34] fsl_hypervisor: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 03/34] net/ceph: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 05/34] drm/etnaviv: convert release_pages() to put_user_pages()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 02/34] net/rds: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-01 Thread john . hubbard
From: John Hubbard Hi, These are best characterized as miscellaneous conversions: many (not all) call sites that don't involve biovec or iov_iter, nor mm/. It also leaves out a few call sites that require some more work. These are mostly pretty simple ones. It's probably best to send all of the

[PATCH 04/34] x86/kvm: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Cc: Joe

[PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-01 Thread john . hubbard
From: John Hubbard Hi, These are best characterized as miscellaneous conversions: many (not all) call sites that don't involve biovec or iov_iter, nor mm/. It also leaves out a few call sites that require some more work. These are mostly pretty simple ones. It's probably best to send all of the

[PATCH 02/34] net/rds: convert put_page() to put_user_page*()

2019-08-01 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-01 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*() varia

[PATCH] PCI: hv: Fix panic by calling hv_pci_remove_slots() earlier

2019-08-01 Thread Dexuan Cui
When a slot is removed, the pci_dev must still exist. pci_remove_root_bus() removes and free all the pci_devs, so hv_pci_remove_slots() must be called before pci_remove_root_bus(), otherwise a general protection fault can happen, if the kernel is built with the memory debugging options. Fixes:

[PATCH -next] staging: fsl-dpaa2/ethsw: Remove useless set memory to zero use memset()

2019-08-01 Thread Wei Yongjun
The memory return by kzalloc() has already be set to zero, so remove useless memset(0). Signed-off-by: Wei Yongjun --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c i

RE: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Matt Sickler
>-Original Message- >From: devel On Behalf Of Greg >KH >Sent: Thursday, August 01, 2019 11:35 AM >To: Harsh Jain >Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org >Subject: Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning > >On Thu, Aug 01, 2019 at 12:06:06AM +05

[PATCH v2 1/2] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Adham.Abozaeid
From: Adham Abozaeid wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same parameters to the FW, so it's better to combine them together. Kept wilc_set_wfi_drv_handler implementation since it sends all the required parameters, and renamed it to wilc_set_operation_mode to be more de

[PATCH v2 2/2] staging: wilc1000: remove unused function

2019-08-01 Thread Adham.Abozaeid
From: Adham Abozaeid function wilc_resolve_disconnect_aberration isn't referenced, so removing it Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/wilc_hif.c | 9 - drivers/staging/wilc1000/wilc_hif.h | 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/wilc1

[PATCH v2 0/2] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Adham.Abozaeid
From: Adham Abozaeid This patch series merges drv_handle and operation_mode wids since they provide duplicate information to WILC. Also it removes function wilc_resolve_disconnect_aberration that's not referenced Changes since v1: - Removed missed reference for wilc_set_wfi_drv_handler from wilc

Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Greg KH
On Thu, Aug 01, 2019 at 07:22:13PM +, Matt Sickler wrote: > >-Original Message- > >From: devel On Behalf Of > >Greg KH > >Sent: Thursday, August 01, 2019 11:35 AM > >To: Harsh Jain > >Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org > >Subject: Re: [PATCH] staging:kpc2000

Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Adham.Abozaeid
Hi Greg On 8/1/19 9:41 AM, Greg KH wrote: > External E-Mail > > > On Wed, Jul 31, 2019 at 08:58:19PM +, adham.aboza...@microchip.com wrote: > This patch causes the following build error: > drivers/staging/wilc1000/wilc_hif.c: In function wilc_deinit: > drivers/staging/wilc1000/wilc_hif.c:1610:

Re: [PATCH] staging: wilc1000: remove unused function

2019-08-01 Thread Greg KH
On Wed, Jul 31, 2019 at 09:01:20PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > function wilc_resolve_disconnect_aberration isn't referenced, so > removing it > > Signed-off-by: Adham Abozaeid > --- > drivers/staging/wilc1000/wilc_hif.c | 9 - > drivers/staging

Re: [PATCH] staging: wilc1000: merge drv_handle and operation_mode wids

2019-08-01 Thread Greg KH
On Wed, Jul 31, 2019 at 08:58:19PM +, adham.aboza...@microchip.com wrote: > From: Adham Abozaeid > > wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same > parameters to the FW, so it's better to combine them together. > > Kept wilc_set_wfi_drv_handler implementation since it

Re: [Patch v2 01/10] staging: rtl8723bs: os_dep: Remove function _rtw_regdomain_select

2019-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 11:41:58PM +0530, Hariprasad Kelam wrote: > This function simply returns &rtw_regdom_rd . So replace this function > with actual code > > Signed-off-by: Hariprasad Kelam > --- > v2 - Add patch number I only received patches 1-6 and 10. Where did the others go? And they

Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Greg KH
On Thu, Aug 01, 2019 at 12:06:06AM +0530, Harsh Jain wrote: > Bitwise OR(|) operation with 0 always yield same result. > It fixes dubious x | !y sparse warning. > > Signed-off-by: Harsh Jain > --- > drivers/staging/kpc2000/kpc2000_i2c.c | 16 +--- > 1 file changed, 1 insertion(+), 15

Re: [PATCH v3 3/3] media: dt-bindings: imx7-csi: add i.MX6UL/L support

2019-08-01 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 1:34 PM Sébastien Szymanski wrote: > > Document "fsl,imx6ul-csi" entry. > > Reviewed-by: Rob Herring > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam ___ devel mailing list de...@linuxdriverproject.org http://dr

Re: [PATCH v3 2/3] media: imx7-media-csi: add i.MX6UL support

2019-08-01 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 1:33 PM Sébastien Szymanski wrote: > > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski Reviewed-by: Fabio Estevam ___ devel mailing l

Re: [PATCH v3 2/3] media: imx7-media-csi: add i.MX6UL support

2019-08-01 Thread Rui Miguel Silva
Hi Sebastien, Thanks for the patch. On Wed 31 Jul 2019 at 17:33, Sébastien Szymanski wrote: > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski > LGTM. Thanks for adding the support to this imx6ul/l soc.