[PATCH] staging: drivers: rtl8712: removing unnecessary parenthesis

2019-08-09 Thread Hugo Eduardo Ziviani
Fix checkpatch error "CHECK: Remove unecessary parenthesis in drivers/staging/rtl8712/rtl871x_mlme.c" Signed-off-by: Hugo Eduardo Ziviani --- drivers/staging/rtl8712/rtl871x_mlme.c | 89 +- 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/drivers/staging/r

Re: [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

2019-08-09 Thread Hridya Valsaraju
On Fri, Aug 9, 2019 at 11:22 AM Christian Brauner wrote: > > On Fri, Aug 09, 2019 at 04:50:16PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote: > > > Currently, since each binderfs instance needs its own > > > private binder devices, every tim

[PATCH v2 2/2] staging: wilc1000: return kernel error codes from wilc_wlan_stop

2019-08-09 Thread Adham.Abozaeid
From: Adham Abozaeid return -EIO for bus failures, 0 otherwise. Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/wilc_wlan.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c ind

[PATCH v2 1/2] staging: wilc1000: Don't reset WILC CPU disgracefully

2019-08-09 Thread Adham.Abozaeid
From: Adham Abozaeid Send abort request to WILC from wilc_wlan_stop instead of resetting the CPU. The abort request was being sent from wilc_wlan_cleanup after the CPU was reset which wasn't the correct order. The abort request handler in the chip will take care of resetting the CPU. Signed-off-

[PATCH v2 0/2] staging: wilc1000: Don't reset WILC CPU disgracefully

2019-08-09 Thread Adham.Abozaeid
From: Adham Abozaeid This patch series modifies wilc_wlan_stop to send an abort request to wilc instead of disgracefully resetting its CPU. changes sinces v1: - return kernel error codes from wilc_wlan_stop - added missing checks for bus operations Adham Abozaeid (2): staging: wilc1000: Don't

Re: [PATCH v3 2/2] binder: Validate the default binderfs device names.

2019-08-09 Thread Christian Brauner
On Fri, Aug 09, 2019 at 04:55:08PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 03:27:26PM -0700, Hridya Valsaraju wrote: > > Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. > > This patch adds a check in binderfs_init() to ensure the same > > for the default binder

Re: [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

2019-08-09 Thread Christian Brauner
On Fri, Aug 09, 2019 at 04:50:16PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote: > > Currently, since each binderfs instance needs its own > > private binder devices, every time a binderfs instance is > > mounted, all the default binder devices

RE: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-09 Thread Weiny, Ira
> > On Wed 07-08-19 19:36:37, Ira Weiny wrote: > > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: > > > > So I think your debug option and my suggested renaming serve a bit > > > > different purposes (and thus both make sense). If you do the > > > > renaming, you can just grep to se

Re: [PATCH v3 2/2] binder: Validate the default binderfs device names.

2019-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 08, 2019 at 03:27:26PM -0700, Hridya Valsaraju wrote: > Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. > This patch adds a check in binderfs_init() to ensure the same > for the default binder devices that will be created in every > binderfs instance. > > Co-developed

Re: [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured

2019-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 08, 2019 at 03:27:25PM -0700, Hridya Valsaraju wrote: > Currently, since each binderfs instance needs its own > private binder devices, every time a binderfs instance is > mounted, all the default binder devices need to be created > via the BINDER_CTL_ADD IOCTL. Wasn't that a design go

Re: [PATCH v3 2/2] binder: Validate the default binderfs device names.

2019-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 08, 2019 at 03:27:26PM -0700, Hridya Valsaraju wrote: > Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. > This patch adds a check in binderfs_init() to ensure the same > for the default binder devices that will be created in every > binderfs instance. > > Co-developed

Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB

2019-08-09 Thread Greg KH
On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote: > USB_WUSB should depends on CONFIG_USB, otherwise building fails > > drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb': > wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb' > > Reported-by: Hulk Rob

Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

2019-08-09 Thread Michael Ellerman
John Hubbard writes: > On 8/7/19 10:42 PM, Michael Ellerman wrote: >> Hi John, >> >> john.hubb...@gmail.com writes: >>> diff --git a/arch/powerpc/mm/book3s64/iommu_api.c >>> b/arch/powerpc/mm/book3s64/iommu_api.c >>> index b056cae3388b..e126193ba295 100644 >>> --- a/arch/powerpc/mm/book3s64/iomm

Re: [PATCH v3 20/41] fbdev/pvr2fb: convert put_page() to put_user_page*()

2019-08-09 Thread Bartlomiej Zolnierkiewicz
On 8/7/19 3:33 AM, john.hubb...@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in co

[PATCH] staging: wusbcore: Fix build error without CONFIG_USB

2019-08-09 Thread YueHaibing
USB_WUSB should depends on CONFIG_USB, otherwise building fails drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb': wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb' Reported-by: Hulk Robot Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is

Re: [PATCH v2 1/2] binder: Add default binder devices through binderfs when configured

2019-08-09 Thread Dan Carpenter
On Wed, Aug 07, 2019 at 09:51:46AM -0700, Hridya Valsaraju wrote: > On Wed, Aug 7, 2019 at 4:02 AM Dan Carpenter wrote: > > > > On Tue, Aug 06, 2019 at 11:40:05AM -0700, Hridya Valsaraju wrote: > > > @@ -467,6 +466,9 @@ static int binderfs_fill_super(struct super_block > > > *sb, void *data, int

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-09 Thread Jan Kara
On Thu 08-08-19 16:25:04, Weiny, Ira wrote: > > I thought I'd caught things early enough to get away with the > > rename and deletion of that. You could either: > > > > a) open code an implementation of vaddr_put_pages_dirty_lock() that > > doesn't call any of the *put_user_pages_dirty*() variants

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-09 Thread Jan Kara
On Wed 07-08-19 19:36:37, Ira Weiny wrote: > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: > > > So I think your debug option and my suggested renaming serve a bit > > > different purposes (and thus both make sense). If you do the renaming, you > > > can just grep to see unconverted