Re: [OSSNA] Intro to kernel hacking tutorial

2019-09-01 Thread Tobin C. Harding
On Sun, Sep 01, 2019 at 05:30:23AM +0530, Amit Kumar wrote: > Hi, > I think now your tutorial should be ready. I do not understand what this means sorry. Is it a request for action? The tutorial was a couple of weeks ago now, here is a link to the material if that is what you were asking

Re: [RFC PATCH 09/15] drivers/acrn: add passthrough device support

2019-09-01 Thread Zhao, Yakui
On 2019年08月16日 21:05, Dan Carpenter wrote: On Fri, Aug 16, 2019 at 10:25:50AM +0800, Zhao Yakui wrote: + case IC_ASSIGN_PTDEV: { + unsigned short bdf; + + if (copy_from_user(, (void *)ioctl_param, This casting is ugly and you also need a __user tag for

[PATCH v2] staging: r8188eu: use skb_put_data instead of skb_put/memcpy pair

2019-09-01 Thread Ivan Safonov
skb_put_data is shorter and clear. Signed-off-by: Ivan Safonov --- Changes in v2: - add "staging: " in message subject; - all code lines now have no breaks in the middle of a sentence. drivers/staging/rtl8188eu/core/rtw_recv.c| 6 +-

Re: [PATCH 0/9] staging: move greybus core out of staging

2019-09-01 Thread Pavel Machek
Hi! > The Greybus code has long been "stable" but was living in the > drivers/staging/ directory to see if there really was going to be > devices using this protocol over the long-term. With the success of > millions of phones with this hardware and code in it, and the recent So, what phones do

Re: [PATCH v6 06/24] erofs: support special inode

2019-09-01 Thread Gao Xiang
Hi Christoph, On Thu, Aug 29, 2019 at 03:25:03AM -0700, Christoph Hellwig wrote: > On Fri, Aug 02, 2019 at 08:53:29PM +0800, Gao Xiang wrote: > > This patch adds to support special inode, such as > > block dev, char, socket, pipe inode. > > > > Signed-off-by: Gao Xiang > > --- > >

Re: [PATCH v6 05/24] erofs: add inode operations

2019-09-01 Thread Gao Xiang
Hi Christoph, Here are redo-ed comments of your suggestions... On Thu, Aug 29, 2019 at 03:24:26AM -0700, Christoph Hellwig wrote: > On Fri, Aug 02, 2019 at 08:53:28PM +0800, Gao Xiang wrote: > > This adds core functions to get, read an inode. > > It adds statx support as well. > > > >

Re: [PATCH v6 03/24] erofs: add super block operations

2019-09-01 Thread Gao Xiang
Hi Christoph, Here is also my redo-ed comments... On Thu, Aug 29, 2019 at 03:15:45AM -0700, Christoph Hellwig wrote: > On Fri, Aug 02, 2019 at 08:53:26PM +0800, Gao Xiang wrote: > > +static int __init erofs_init_inode_cache(void) > > +{ > > + erofs_inode_cachep =

Re: [PATCH v6 01/24] erofs: add on-disk layout

2019-09-01 Thread Gao Xiang
Hi Christoph, Sorry about my first response, sincerely... Here is my redo-ed comments to all your suggestions... On Thu, Aug 29, 2019 at 02:59:54AM -0700, Christoph Hellwig wrote: > > --- /dev/null > > +++ b/fs/erofs/erofs_fs.h > > @@ -0,0 +1,316 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only