Re: general protection fault in __apic_accept_irq

2019-09-05 Thread Wanpeng Li
On Thu, 5 Sep 2019 at 21:11, Vitaly Kuznetsov wrote: > > Wanpeng Li writes: > > > On Thu, 5 Sep 2019 at 16:53, syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:3b47fd5c Merge tag 'nfs-for-5.3-4' of > >> git://git.linux-nfs... > >> git t

[PATCH] staging: olpc_dcon: allow simultaneous XO-1 and XO-1.5 support

2019-09-05 Thread Jerry Lin
This patch remove model related configuration. Since the module can decide which platform data to use itself base on current running olpc board. Also change module dependency from (GPIO_CS5535 || GPIO_CS5535=n) to (GPIO_CS5535 || ACPI) because original one does not make any sense and module only d

[PATCH][V2] staging: rtl8723bs: hal: remove redundant variable n

2019-09-05 Thread Colin King
From: Colin Ian King The variable n is being assigned a value that is never read inside an if statement block, the assignment is redundant and can be removed. With this removed, n is only being used for a constant loop bounds check, so replace n with that value instead and remove n completely. A

Re: [PATCH] staging: rtl8723bs: hal: remove redundant assignment to variable n

2019-09-05 Thread Colin Ian King
On 05/09/2019 15:52, Dan Carpenter wrote: > It would be better to remove "n" altogether. Good point, will resend a V2 later. > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mai

Re: [PATCH] staging: rtl8723bs: hal: remove redundant assignment to variable n

2019-09-05 Thread Dan Carpenter
It would be better to remove "n" altogether. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723bs: hal: remove redundant assignment to variable n

2019-09-05 Thread Colin King
From: Colin Ian King The variable n is being assigned a value that is never read, the assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 1 - 1 file changed, 1 deletion(-) diff --g

[PATCH] staging: pi433: Fix typo in documentation

2019-09-05 Thread Rohit Sarkar
Fixes a typo in the documentation. Signed-off-by: Rohit Sarkar --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/Documentation/pi433.txt b/drivers/staging/pi433/Documentation/pi433.txt index 21cffdb86ecf..

Re: general protection fault in __apic_accept_irq

2019-09-05 Thread Vitaly Kuznetsov
Wanpeng Li writes: > On Thu, 5 Sep 2019 at 16:53, syzbot > wrote: >> >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:3b47fd5c Merge tag 'nfs-for-5.3-4' of git://git.linux-nfs... >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=12

Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-05 Thread Ajay.Kathat
Hi Greg, On 05-Sep-19 1:07 PM, Greg KH wrote: > On Thu, Sep 05, 2019 at 06:09:43AM +, ajay.kat...@microchip.com wrote: >> Hi Eugen, >> >> On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote: >>> From: Eugen Hristev >>> >>> Add bindings for optional rtc clock pin. >>> >>> Signed-off-by: Eugen H

Re: [PATCH v2 00/25] erofs: patchset addressing Christoph's comments

2019-09-05 Thread Christoph Hellwig
On Thu, Sep 05, 2019 at 09:03:54AM +0800, Gao Xiang wrote: > Could we submit these patches if these patches look good... > Since I'd like to work based on these patches, it makes a difference > to the current code though... Yes, I'm fine with these patches.

Re: [staging:staging-testing 314/401] drivers/iio/common/hid-sensors/hid-sensor-attributes.c:312: undefined reference to `__udivdi3'

2019-09-05 Thread Jonathan Cameron
On Wed, 4 Sep 2019 15:37:11 +0300 Andy Shevchenko wrote: > On Wed, Sep 04, 2019 at 11:33:50AM +0800, kbuild test robot wrote: > > tree: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: 74eb9c06b1d722468db397595ac6834b9e4ac235 > >

Re: general protection fault in __apic_accept_irq

2019-09-05 Thread Wanpeng Li
On Thu, 5 Sep 2019 at 16:53, syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:3b47fd5c Merge tag 'nfs-for-5.3-4' of git://git.linux-nfs... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=124af12a60 > kernel config: ht

general protection fault in __apic_accept_irq

2019-09-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3b47fd5c Merge tag 'nfs-for-5.3-4' of git://git.linux-nfs... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=124af12a60 kernel config: https://syzkaller.appspot.com/x/.config?x=144488c6c6c6d2b6 da

Re: [PATCH 2/2] staging: wilc1000: look for rtc_clk clock

2019-09-05 Thread Greg KH
On Wed, Sep 04, 2019 at 01:34:01PM +, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > If rtc_clk is provided from DT, use it and enable it. > This is optional. > The signal may be hardcoded and no need to be requested, > but if DT provides it, use it. > > Signed-off-by: Eugen Hr

Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

2019-09-05 Thread Greg KH
On Thu, Sep 05, 2019 at 06:09:43AM +, ajay.kat...@microchip.com wrote: > Hi Eugen, > > On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote: > > From: Eugen Hristev > > > > Add bindings for optional rtc clock pin. > > > > Signed-off-by: Eugen Hristev > > Thanks for sending the patch series.

Re: [PATCH] staging: greybus: loopback_test: remove multiple blank lines

2019-09-05 Thread Johan Hovold
On Wed, Sep 04, 2019 at 09:05:47PM +, Pedro Chinen wrote: > Fix following checkpath warnings in multiple lines: > CHECK: Please don't use multiple blank lines Checkpatch reports five instances of this CHECK, please fix them all in one go. > Signed-off-by: Pedro Chinen > --- > drivers/stagin

Re: [PATCH] staging: greybus: Adding missing brackets into if..else block.

2019-09-05 Thread Johan Hovold
On Wed, Sep 04, 2019 at 08:32:09PM +, Julio Faracco wrote: > Inside a block of if..else conditional, else structure does not contain > brackets. This is not following regular policies of good coding style. s/good/kernel/ ? > All parts of this conditional blocks should respect brackets inclusi

Re: [PATCH] staging: greybus: remove blank line after an open brace '{'.

2019-09-05 Thread Johan Hovold
On Wed, Sep 04, 2019 at 08:55:58PM +, joahannes wrote: > Fix checkpatch error > "CHECK: Blank lines aren't necessary after an open brace '{'" > in loopback_test.c:742. Please fix up all of the blank lines before/after closing/opening brace checkpatch CHECKs in one go. There appears to be many