[PATCH] staging: rtl8712: align arguments with open parenthesis in file rtl8712_led.c

Cleans up checks of "Alignment should match open parenthesis" Signed-off-by: Gabriela Bittencourt --- drivers/staging/rtl8712/rtl8712_led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging/rtl8712/rtl8712_led.c index

[PATCH] staging: rtl8712: align arguments with open parenthesis

Cleans up checks of: "Alignment should match open parenthesis" Signed-off-by: Gabriela Bittencourt --- drivers/staging/rtl8712/osdep_service.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h

Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote: [mA vs. MA] Table 5. SI prefixes Factor NameSymbol 10^6megaM 10^-3 milli m Confusing one for another (especially for electrical units) can be... spectacular. FYI, 1mA is more or less what you get if you

[PATCH] staging: rtl8712: align arguments with open parenthesis

Cleans up checks of "Alignment should match open parenthesis" Signed-off-by: Gabriela Bittencourt --- drivers/staging/rtl8712/recv_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/recv_linux.c b/drivers/staging/rtl8712/recv_linux.c index

[PATCH] staging: rtl8712: align block comments

Cleans up warnings of "Block comments should align the * on each line" Signed-off-by: Gabriela Bittencourt --- drivers/staging/rtl8712/recv_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/recv_linux.c

[PATCH] staging: vt6656: remove duplicated blank line

Cleans up checks of "don't use multiple blank line" Signed-off-by: Gabriela Bittencourt --- drivers/staging/vt6656/main_usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 856ba97aec4f..a1884b5cc915 100644 ---

[PATCH] staging: vt6656: reorganize characters so the lines are under 80 ch

Cleans up warnings of "line over 80 characters" Signed-off-by: Gabriela Bittencourt --- drivers/staging/vt6656/rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index c7522841c8cf..922872b62994 100644

[PATCH] staging: vt6656: align arguments with open parenthesis

Cleans up CHECKs of "Alignment should match open parenthesis" Signed-off-by: Gabriela Bittencourt --- drivers/staging/vt6656/rxtx.c | 63 +++ 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c

Re: [PATCH] staging: comedi: Fix camelcase check warning

On Sun, Oct 06, 2019 at 07:44:53PM +0100, Jules Irenge wrote: > Capitalize unit_ma to fix camelcase check warning. > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedi.h| 4 ++-- > drivers/staging/comedi/comedidev.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

On Sun, Oct 06, 2019 at 07:49:03PM +0100, Jules Irenge wrote: > Capitalize RANGE_mA to fix camelcase check warning. > Issue reported by checkpatch.pl > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedidev.h | 2 +- > drivers/staging/comedi/drivers/adv_pci1724.c | 4

Re: [Outreachy kernel] [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

On Sun, Oct 06, 2019 at 09:01:09PM +0200, Julia Lawall wrote: > > > On Sun, 6 Oct 2019, Jules Irenge wrote: > > > Capitalize RANGE_mA to fix camelcase check warning. > > Issue reported by checkpatch.pl > > I guess mA means something, so it would be better to keep it? Yes it does, we need to

Re: [Outreachy kernel] [PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

On Sun, 6 Oct 2019, Jules Irenge wrote: > Capitalize RANGE_mA to fix camelcase check warning. > Issue reported by checkpatch.pl I guess mA means something, so it would be better to keep it? julia > > Signed-off-by: Jules Irenge > --- > drivers/staging/comedi/comedidev.h | 2 +- >

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +-

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +-

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +-

[PATCH] staging: comedi: Fix camelcase check warning

Capitalize unit_ma to fix camelcase check warning. Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedi.h| 4 ++-- drivers/staging/comedi/comedidev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi.h

[PATCH] staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'

Depending on revision of the chip, reset lines are inverted. Make code more readable making use of 'soc_device_match' in driver probe function. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 23 +-- 1 file changed, 17 insertions(+), 6

[PATCH] staging: wlan-ng: p80211wep.c: use lib/crc32

Use lib/crc32 instead of another implementation. Signed-off-by: Thomas Meyer --- drivers/staging/wlan-ng/p80211wep.c | 64 ++--- 1 file changed, 3 insertions(+), 61 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c

Re: [Outreachy kernel] Re: [PATCH] staging: greybus: add blank line after declarations

On Sun, 6 Oct 2019, Joe Perches wrote: > On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote: > > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > > > Fix CHECK: add blank line after declarations > [] > > > diff --git a/drivers/staging/greybus/control.h > > >

[PATCH v2] staging: rtl8192u: Fix indentation for cleaner code

Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter. Reported-by: Dan Carpenter Signed-off-by: Sumera Priyadarsini --- Changes in v2: -Wrap commit message line at a column length of 72. ---

Re: [PATCH] staging: greybus: add blank line after declarations

On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote: > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > > Fix CHECK: add blank line after declarations [] > > diff --git a/drivers/staging/greybus/control.h > > b/drivers/staging/greybus/control.h [] > > @@ -24,6 +24,7 @@ struct

Re: [PATCH] staging: greybus: add blank line after declarations

On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote: > Fix CHECK: add blank line after declarations > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/greybus/control.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/control.h >

[PATCH] staging: rtl8723bs: Remove set but not used variable 'oldcnt'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/sdio_ops.c: In function sdio_read_port: drivers/staging/rtl8723bs/hal/sdio_ops.c:430:6: warning: variable oldcnt set but not used [-Wunused-but-set-variable] It is not used since commit dedf215bd1c7 ("staging:

[PATCH] staging: vc04_services: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:139 WARNING: Use devm_platform_ioremap_resource for g_regs Signed-off-by: Hariprasad Kelam --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c |

[PATCH 0/5] staging/rtl8723bs/core: Remove some set but not used variables

zhengbin (5): staging: rtl8723bs: Remove set but not used variable 'i' staging: rtl8723bs: Remove set but not used variable 'tmp_aid' staging: rtl8723bs: Remove set but not used variable 'prwskeylen' staging: rtl8723bs: Remove set but not used variables 'ppp','type','data' staging:

[PATCH 2/5] staging: rtl8723bs: Remove set but not used variable 'tmp_aid'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_sta_mgt.c: In function rtw_alloc_stainfo: drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:190:7: warning: variable tmp_aid set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3abf21

[PATCH 3/5] staging: rtl8723bs: Remove set but not used variable 'prwskeylen'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_security.c: In function rtw_tkip_encrypt: drivers/staging/rtl8723bs/core/rtw_security.c:660:6: warning: variable prwskeylen set but not used [-Wunused-but-set-variable]

[PATCH 4/5] staging: rtl8723bs: Remove set but not used variables 'ppp', 'type', 'data'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_recv.c: In function validate_80211w_mgmt: drivers/staging/rtl8723bs/core/rtw_recv.c:1415:8: warning: variable ppp set but not used [-Wunused-but-set-variable] drivers/staging/rtl8723bs/core/rtw_recv.c: In function

[PATCH 5/5] staging: rtl8723bs: Remove set but not used variable 'adapter'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_mlme.c: In function rtw_select_roaming_candidate: drivers/staging/rtl8723bs/core/rtw_mlme.c:2007:18: warning: variable adapter set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3abf21

[PATCH 1/5] staging: rtl8723bs: Remove set but not used variable 'i'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/core/rtw_xmit.c: In function update_attrib: drivers/staging/rtl8723bs/core/rtw_xmit.c:680:7: warning: variable i set but not used [-Wunused-but-set-variable] It is not used since commit 554c0a3abf21 ("staging: Add