Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

2019-10-10 Thread Greg KH
On Thu, Oct 10, 2019 at 10:51:52PM -0700, Chandra Annamaneni wrote: > Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl > > Signed-off-by: Chandra Annamaneni Please fix the subject lines for all of these patches and resend. Also, this is a second set of patches, right? What

Re: [PATCH 1/5] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-10 Thread Greg KH
On Thu, Oct 10, 2019 at 10:51:51PM -0700, Chandra Annamaneni wrote: > Resoved: "WARNING: line over 80 characters" from checkpatch.pl Please put "staging:" in your subject line, makes it easier to sort and handle. It should look something like: staging: kpc2000_spi: fix line length issues

Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-10 Thread Julia Lawall
On Fri, 11 Oct 2019, Wambui Karuga wrote: > Remove typedef declaration from struct cvmx_wqe_t in You can remove the _t from the name as well. > drivers/staging/octeon/octeon-stubs.h. It's not really necessary to give the name of the file in the log message, as it can easily be seen below. j

Re: [PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-10 Thread Andrzej Hajda
On 11.10.2019 04:20, Xin Ji wrote: > Hi all, > > The following series add initial support for the Slimport ANX7625 > transmitter, a > ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable > device. > > This is the initial version, any mistakes, please let me know, I will fix it

[PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t

2019-10-10 Thread Wambui Karuga
Remove declaration of union cvmx_helper_link_info_t as typedef in drivers/staging/octeon/octeon-stubs.h. Also replace its previous uses with new union declaration. Issue found by checkpatch.pl Signed-off-by: Wambui Karuga --- drivers/staging/octeon/ethernet-mdio.c | 6 +++--- drivers/staging/

[PATCH 5/5] staging: octeon: remove typedef declaration for cvmx_fau_op_size_t

2019-10-10 Thread Wambui Karuga
Remove addition of new typedef for enum cvmx_fau_op_size_t in drivers/staging/octeon/octeon-stubs.h. Issue found by checkpatch.pl Signed-off-by: Wambui Karuga --- drivers/staging/octeon/octeon-stubs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/

[PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-10 Thread Wambui Karuga
Remove typedef declaration from struct cvmx_wqe_t in drivers/staging/octeon/octeon-stubs.h. Also replace its previous uses with new struct declaration. Issue found by checkpatch.pl Signed-off-by: Wambui Karuga --- drivers/staging/octeon/ethernet-rx.c | 6 +++--- drivers/staging/octeon/ethernet

[PATCH 0/5] Remove declarations of new typedef in

2019-10-10 Thread Wambui Karuga
This patchset removes various typedef declarations of new data types in drivers/staging/octeon/octeon-stubs.h. The series also changes their old uses with the new declaration format. Wambui Karuga (5): staging: octeon: remove typedef declaration for cvmx_wqe_t staging: octeon: remove typedef d

[PATCH 4/5] staging: octeon: remove typedef declartion for cvmx_pko_command_word0_t

2019-10-10 Thread Wambui Karuga
Removes addition of new typedef declaration for cvmx_pko_command_word0_t in drivers/staging/octeon/octeon-stubs.h. Also replace previous instances with new union declaration. Signed-off-by: Wambui Karuga --- drivers/staging/octeon/ethernet-tx.c | 2 +- drivers/staging/octeon/octeon-stubs.h | 6

[PATCH 3/5] staging: octeon: remove typedef declaration for cvmx_fau_reg_32_t

2019-10-10 Thread Wambui Karuga
Remove typedef declaration for enum cvmx_fau_reg_32_t in drivers/staging/octeon/octeon-stubs.h. Also replace its previous uses with new declaration format. Issue found by checkpatch.pl Signed-off-by: Wambui Karuga --- drivers/staging/octeon/octeon-stubs.h | 14 -- 1 file changed, 8 i

[PATCH 3/5] KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace)

2019-10-10 Thread Chandra Annamaneni
Resolved: ERROR: else should follow close brace '}' Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index d1f7360cd179.

[PATCH 1/5] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-10 Thread Chandra Annamaneni
Resoved: "WARNING: line over 80 characters" from checkpatch.pl Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/k

[PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

2019-10-10 Thread Chandra Annamaneni
Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 81d79b116ce0.

[PATCH 5/5] KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis)

2019-10-10 Thread Chandra Annamaneni
Resolved: CHECK: Unnecessary parentheses around table[i] Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c index 26e1e8466f

[PATCH 4/5] KPC2000: kpc2000_spi.c: Fix style issues (alignment)

2019-10-10 Thread Chandra Annamaneni
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch Signed-off-by: Chandra Annamaneni --- drivers/staging/kpc2000/kpc2000_spi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc20

[PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

[PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-10 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Xin Ji
Hi Dan Carpenter, This is a bug, I'll fix it right now. The coding is much nicer than before, thanks for your comments, it is very helpful for me. Thanks, Xin On Thu, Oct 10, 2019 at 12:56:17PM +0300, Dan Carpenter wrote: > On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote: > > Thi

Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"

2019-10-10 Thread Yizhuo Zhai
Sorry about that, let me resend it . On Thu, Oct 10, 2019 at 2:53 AM Dan Carpenter wrote: > > On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > > Inside function set_chip_clock(), struct pll is supposed to be > > initialized in sm750_calc_pll_value(), if condition > > "diff < mini_diff" i

RE: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-10 Thread Matt Sickler
>-Original Message- >From: devel On Behalf Of >Chandra Annamaneni >Sent: Wednesday, October 09, 2019 10:09 PM >To: gre...@linuxfoundation.org >Cc: de...@driverdev.osuosl.org; gneuk...@gmail.com; chandra...@gmail.com; >fabian.krue...@fau.de; linux- >ker...@vger.kernel.org; si...@nikanor.n

Re: [PATCH v2] PCI: PM: Move to D0 before calling pci_legacy_resume_early()

2019-10-10 Thread Rafael J. Wysocki
On 10/8/2019 9:56 PM, Bjorn Helgaas wrote: On Tue, Oct 08, 2019 at 07:32:27PM +0200, Rafael J. Wysocki wrote: On 10/7/2019 8:57 PM, Dexuan Cui wrote: -Original Message- From: Bjorn Helgaas Sent: Monday, October 7, 2019 6:24 AM To: Dexuan Cui Cc: lorenzo.pieral...@arm.com; linux-...@vg

[PATCH -next] staging: rtl8723bs: Remove unnecessary null check

2019-10-10 Thread YueHaibing
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl87

[PATCH] rtl8723bs: Remove comparison to NULL

2019-10-10 Thread Wambui Karuga
Remove comparison to NULL in drivers/staging/rtl8723bs/core/rtw_ap.c:1449. Issue found by checkpatch.pl Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/

[PATCH v3 4/4] staging: rtl8723bs: Remove unnecessary blank lines

2019-10-10 Thread Wambui Karuga
Remove multiple blank lines in drivers/staging/rtl8723bs/core/rtw_mlme.c. Issues reported by checkpatch.pl as: CHECK: Please don't use multiple blank lines Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 47 --- 1 file changed, 47 deletions(-) di

[PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-10 Thread Wambui Karuga
Remove most comparisons to NULL in conditionals in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Comparison to NULL could be written Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 50 +++ 1 file changed, 25

[PATCH v3 2/4] staging: rtl8723bs: Remove unnecessary braces for single statements

2019-10-10 Thread Wambui Karuga
Clean up multiple unnecessary braces around single statement blocks in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: WARNING: braces {} are not necessary for single statement blocks or WARNING: braces {} are not necessary for any arm of this statement Signed-off-by

[PATCH v3 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals.

2019-10-10 Thread Wambui Karuga
Remove comparisons to true and false in multiple if statements in drivers/staging/rtl8723bs/core/rtw_mlme.c Issues reported by checkpatch.pl as: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Wambui Karuga --- drivers/staging/rtl8723

[PATCH v3 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c

2019-10-10 Thread Wambui Karuga
This patchset addresses multiple style and formatting issues reported by checkpatch.pl in drivers/staging/rtl8723bs/core/rtw_mlme.c PATCH v2 of the series corrects the "patchest" mispelling in the original cover letter and provides a clearer subject line. PATCH v3 of the series incorporates newer

Re: [PATCH v2 1/2] dmaengine: avalon: Intel Avalon-MM DMA Interface for PCIe

2019-10-10 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 10:51:45AM +0200, Alexander Gordeev wrote: > On Wed, Oct 09, 2019 at 09:53:23PM +0300, Dan Carpenter wrote: > > > > > + u32 *rd_flags = hw->dma_desc_table_rd.cpu_addr->flags; > > > > > + u32 *wr_flags = hw->dma_desc_table_wr.cpu_addr->flags; > > > > > + struct av

[PATCH][next] staging: wfx: fix spelling mistake "non existant" -> "non-existent"

2019-10-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/staging/wfx/hif_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 52db02d3aa41..36e

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 12:53:15PM +0300, Dan Carpenter wrote: > This code is *so* much nicer than before. I hope you feel good about > the changes. It makes me happy to look at this code now. > > On Thu, Oct 10, 2019 at 09:34:19AM +, Xin Ji wrote: > > +static int edid_read(struct anx7625_da

Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"

2019-10-10 Thread Dan Carpenter
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > Inside function set_chip_clock(), struct pll is supposed to be > initialized in sm750_calc_pll_value(), if condition > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, > then some field of pll will not be initialized but use

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Dan Carpenter
This code is *so* much nicer than before. I hope you feel good about the changes. It makes me happy to look at this code now. On Thu, Oct 10, 2019 at 09:34:19AM +, Xin Ji wrote: > +static int edid_read(struct anx7625_data *ctx, > + u8 offset, u8 *pblock_buf) > +{ > + int

[PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

[PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-10 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt

Re: [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

2019-10-10 Thread kbuild test robot
Hi Jules, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Jules-Irenge/staging-qlge-Fix-multiple-assignments-warning-by-splitting-the-assignement-into-two-each/20191010-141520 config: x86_64

Re: [Outreachy kernel] [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

2019-10-10 Thread Dan Carpenter
I was just about to give a newbie a Reviewed-by cookie until I saw it was a Joe Perches patch without a commit message or a sign off. And then I was annoyed that I had invested any time in it at all. I even dropped out of my email client for this! :P If you want to resend as a proper commit the

Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"

2019-10-10 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > Inside function set_chip_clock(), struct pll is supposed to be > initialized in sm750_calc_pll_value(), if condition > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, > then some field of pll will not be initialized but use

Re: [PATCH v2 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c

2019-10-10 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 07:49:04AM +0300, Wambui Karuga wrote: > This patchset addresses multiple style and formatting issues reported by > checkpatch.pl in drivers/staging/rtl8723bs/core/rtw_mlme.c > > PATCH v2 of the series corrects the "patchest" mispelling in the > original cover letter and pr

Re: [PATCH v2 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-10 Thread Greg KH
On Thu, Oct 10, 2019 at 07:49:05AM +0300, Wambui Karuga wrote: > Remove most comparisons to NULL in conditionals in > drivers/staging/rtl8723bs/core/rtw_mlme.c > Issues reported by checkpatch.pl as: > CHECK: Comparison to NULL could be written > > Signed-off-by: Wambui Karuga > --- > drivers/sta

Re: [PATCH 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals.

2019-10-10 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 06:39:23AM +0300, Wambui Karuga wrote: > if (is_primary_adapter(adapter)) > DBG_871X("IsBtDisabled =%d, IsBtControlLps =%d\n", > hal_btcoex_IsBtDisabled(adapter), hal_btcoex_IsBtControlLps(adapter)); > > - if ((adapter_to_pwrctl(adapter)->bFwCurren

driverdev-devel@linuxdriverproject.org

2019-10-10 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2019 at 03:07:39PM +, Jerome Pouiller wrote: > On Wednesday 9 October 2019 09:38:31 CEST kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: d49d1c76b96ebf39539e93d5ab7943a01ef70e4f > > commit:

Re: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-10 Thread Greg KH
On Wed, Oct 09, 2019 at 08:08:57PM -0700, Chandra Annamaneni wrote: > Resoved: "WARNING: line over 80 characters" from checkpatch.pl > > Signed-off-by: Chandra Annamaneni > --- > drivers/staging/kpc2000/kpc2000_spi.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-)

Re: [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

2019-10-10 Thread Dan Carpenter
On Wed, Oct 09, 2019 at 09:10:29PM +0100, Jules Irenge wrote: > Fix multiple assignments warning " check > issued by checkpatch.pl tool: > "CHECK: multiple assignments should be avoided". > > Signed-off-by: Jules Irenge > --- > drivers/staging/qlge/qlge_dbg.c | 6 -- > 1 file changed, 4 ins

Re: [PATCH v2 1/2] dmaengine: avalon: Intel Avalon-MM DMA Interface for PCIe

2019-10-10 Thread Alexander Gordeev
On Wed, Oct 09, 2019 at 09:53:23PM +0300, Dan Carpenter wrote: > > > > + u32 *rd_flags = hw->dma_desc_table_rd.cpu_addr->flags; > > > > + u32 *wr_flags = hw->dma_desc_table_wr.cpu_addr->flags; > > > > + struct avalon_dma_desc *desc; > > > > + struct virt_dma_desc *vdesc; > >

Re: [Outreachy kernel] [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

2019-10-10 Thread Joe Perches
On Wed, 2019-10-09 at 22:48 +0200, Julia Lawall wrote: > On Wed, 9 Oct 2019, Jules Irenge wrote: > > Fix multiple assignments warning " check > > issued by checkpatch.pl tool: > > "CHECK: multiple assignments should be avoided". [] > > diff --git a/drivers/staging/qlge/qlge_dbg.c > > b/drivers/st