Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Julia Lawall
> btw2: > > I really dislike all the code inconsistencies and > unnecessary code duplication with miscellaneous changes > in the rtl staging drivers > > Horrid stuff. I'm not sure what you mean by "miscellaneous changes". Do you mean that all issues should be fixed for one file before moving

Re: [PATCH] Staging: gasket: apex_driver: fixed a line over 80 characters coding style issue

2019-10-20 Thread Joe Perches
dOn Sun, 2019-10-20 at 20:50 +0300, Samuil Ivanov wrote: > Fixed four lines of code that were over 80 characters long. Some of the 80 column messages that checkpatch emits should be ignored. These are some of them because each of these lines is a single very long name (48 chars!) identifier. Per

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Joe Perches
On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote: > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c [] > > @@ -1132,7 +1132,7 @@ unsigned int OnAuthClient(struct adapter > >

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Julia Lawall
On Sun, 20 Oct 2019, Joe Perches wrote: > On Sun, 2019-10-20 at 21:52 +0200, Julia Lawall wrote: > > On Sun, 20 Oct 2019, Joe Perches wrote: > [] > > > There's probably a generic cocci mechanism to check function > > > prototypes and then remove uses of unnecessary void pointer casts > > > in f

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Joe Perches
On Sun, 2019-10-20 at 21:52 +0200, Julia Lawall wrote: > On Sun, 20 Oct 2019, Joe Perches wrote: [] > > There's probably a generic cocci mechanism to check function > > prototypes and then remove uses of unnecessary void pointer casts > > in function calls. I'm not going to try to figure out that

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Julia Lawall
On Sun, 20 Oct 2019, Joe Perches wrote: > On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote: > > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote: > > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c > [] > > > @@ -1132,7 +1132,7 @@ unsigned int OnAut

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Julia Lawall
On Sun, 20 Oct 2019, Joe Perches wrote: > On Sun, 2019-10-20 at 22:17 +0300, Dan Carpenter wrote: > > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote: > > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c > [] > > > @@ -1132,7 +1132,7 @@ unsigned int OnAut

Re: [Outreachy kernel] Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Julia Lawall
On Sun, 20 Oct 2019, Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote: > > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c > > --- a/rtl8723bs/core/rtw_mlme_ext.c > > +++ b/rtl8723bs/core/rtw_mlme_ext.c > > @@ -1132,7 +1132,7 @@ unsig

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

2019-10-20 Thread Dan Carpenter
On Sat, Oct 19, 2019 at 01:02:31PM -0700, Joe Perches wrote: > diff -u -p a/rtl8723bs/core/rtw_mlme_ext.c b/rtl8723bs/core/rtw_mlme_ext.c > --- a/rtl8723bs/core/rtw_mlme_ext.c > +++ b/rtl8723bs/core/rtw_mlme_ext.c > @@ -1132,7 +1132,7 @@ unsigned int OnAuthClient(struct adapter >

[PATCH] Staging: gasket: apex_driver: fixed a line over 80 characters coding style issue

2019-10-20 Thread Samuil Ivanov
Fixed four lines of code that were over 80 characters long. Signed-off-by: Samuil Ivanov --- drivers/staging/gasket/apex_driver.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c index 4619