On Mon, 28 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in file xd.c
>
> Signed-off-by: Gabriela Bittencourt
> ---
> drivers/staging/rts5208/xd.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/dr
Cleans up checks of "Avoid CamelCase" in file ms.h
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/ms.h | 70 ++--
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rts5208/ms.h b/drivers/staging/rts5208/ms.h
index 952
Cleans up checks of "Avoid CamelCase" in tree rts5208
Gabriela Bittencourt (5):
staging: rts5208: Eliminate the use of Camel Case in file ms.c
staging: rts5208: Eliminate the use of Camel Case in file ms.h
staging: rts5208: Eliminate the use of Camel Case in file xd.c
staging: rts5208: El
Cleans up checks of "Avoid CamelCase" in file sd.h
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/sd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h
index dc9e8cad7a74..f4ff62653b56 100644
--- a/dr
Cleans up checks of "Avoid CamelCase" in file ms.c
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/ms.c | 86 ++--
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index e85
Cleans up checks of "Avoid CamelCase" in file xd.c
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/xd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index f3dc96a4c59d..0f369935fb6c 100644
Cleans up checks of "Avoid CamelCase" in file xd.h
Signed-off-by: Gabriela Bittencourt
---
drivers/staging/rts5208/xd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
index 57b94129b26f..98c00f268e56 100644
--
After implementing the function to check the status of the driver,
there is no longer need for this comment.
Signed-off-by: Samuil Ivanov
---
drivers/staging/gasket/apex_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/apex_driver.c
b/drivers/staging/gasket/ape
>From the TODO:
- apex_get_status() should actually check status
The function now checkes the status of the driver
Signed-off-by: Samuil Ivanov
---
drivers/staging/gasket/apex_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/gasket/apex_driver.c
b/drivers/staging
>From the TODO list:
- apex_get_status() should actually check status.
First patch implements the check.
Second removes the TODO comment in the function.
*** BLURB HERE ***
Samuil Ivanov (2):
Staging: gasket: implement apex_get_status() to check driver status
Staging: gasket: Clean apex_get_s
Hi Greg, friendly reminder... Did you miss the patch review below, or
is there a reason
why this isn't getting queued?
There seems to be a crowd chasing down this type of warnings, resulting
in multiple duplicates.
On Tue, Oct 8, 2019 at 9:31 AM Sven Van Asbroeck wrote:
>
> On Tue, Oct 8, 2019 a
On Mon, Oct 28, 2019 at 09:35:37AM -0700, Davidlohr Bueso wrote:
> On Mon, 28 Oct 2019, Greg KH wrote:
> > This is obviously not in a format I can apply it in :(
>
> What are you talking about? I sent you the original patch,
> then Cc'ed the drivers mailing list. So you still have a
> patch you c
On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> Fix alignment should match open parenthesis. Issue found by checkpatch.
>
> Signed-off-by: Cristiane Naves
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 36
> +-
> 1 file changed, 18 insertions
From: Adham Abozaeid
When killing hostapd, the interface is closed which deinitializes the
device, then change virtual interface is called.
This change checks if the device is initialized before sending the
interface change command to the device
Signed-off-by: Adham Abozaeid
---
.../staging/wi
On Mon, Oct 28, 2019 at 09:35:37AM -0700, Davidlohr Bueso wrote:
> On Mon, 28 Oct 2019, Greg KH wrote:
> > This is obviously not in a format I can apply it in :(
>
> What are you talking about? I sent you the original patch,
> then Cc'ed the drivers mailing list. So you still have a
> patch you ca
On Mon, 28 Oct 2019, Greg KH wrote:
This is obviously not in a format I can apply it in :(
What are you talking about? I sent you the original patch,
then Cc'ed the drivers mailing list. So you still have a
patch you can apply... this is quite a common way of doing
things (Ccing for future refe
On Mon, Oct 28, 2019 at 08:53:54AM -0700, Davidlohr Bueso wrote:
> Cc de...@driverdev.osuosl.org
>
> On Sun, 27 Oct 2019, Bueso wrote:
>
> > There seems no need to be using a semaphore, or a sleeping lock
> > in the first place: critical region is extremely short, does not
> > call into any block
Cc de...@driverdev.osuosl.org
On Sun, 27 Oct 2019, Bueso wrote:
There seems no need to be using a semaphore, or a sleeping lock
in the first place: critical region is extremely short, does not
call into any blocking calls and furthermore lock and unlocking
operations occur in the same context.
On Mon, Oct 28, 2019 at 12:39:08PM -0300, Cristiane Naves wrote:
> Fix Blank lines aren't necessary before a close brace '}'. Issue found
> by checkpatch.
>
> Signed-off-by: Cristiane Naves
> ---
> drivers/staging/rtl8712/rtl8712_recv.c | 2 --
> 1 file changed, 2 deletions(-)
This patch did no
Fix Blank lines aren't necessary before a close brace '}'. Issue found
by checkpatch.
Signed-off-by: Cristiane Naves
---
drivers/staging/rtl8712/rtl8712_recv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/drivers/staging/rtl8712/rtl8712_recv.c
in
Fix alignment should match open parenthesis. Issue found by checkpatch.
Signed-off-by: Cristiane Naves
---
drivers/staging/rtl8712/rtl8712_recv.c | 36 +-
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/dri
On Mon, Oct 28, 2019 at 08:21:08AM -0700, Davidlohr Bueso wrote:
> On Mon, 28 Oct 2019, Stefan Wahren wrote:
>
> > Hi Davidlohr,
> >
> > Am 27.10.19 um 23:15 schrieb Davidlohr Bueso:
> > > There seems no need to be using a semaphore, or a sleeping lock
> > > in the first place: critical region is
On Mon, 28 Oct 2019, Stefan Wahren wrote:
Hi Davidlohr,
Am 27.10.19 um 23:15 schrieb Davidlohr Bueso:
There seems no need to be using a semaphore, or a sleeping lock
in the first place: critical region is extremely short, does not
call into any blocking calls and furthermore lock and unlocking
Cleanup in rtl8712
Changes in v2:
- Arranging conflict between author name and signed-off-by.
- Remove unnecessary parentheses.
- Change the driver name to rtl8712.
Changes in v3:
- Change alignment of eth_type.
- Change alignment of SN_EQUAL.
- Remove commit of unneeded parentheses.
Chang
Fix Blank lines aren't necessary before a close brace '}'. Issue found
by checkpatch.
Signed-off-by: Cristiane Naves
---
drivers/staging/rtl8712/rtl8712_recv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/drivers/staging/rtl8712/rtl8712_recv.c
in
Fix alignment should match open parenthesis. Issue found by checkpatch.
Signed-off-by: Cristiane Naves
---
drivers/staging/rtl8712/rtl8712_recv.c | 36 +-
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.c
b/dri
Cleanup in rtl8712
Changes in v2:
- Arranging conflict between author name and signed-off-by.
- Remove unnecessary parentheses.
- Change the driver name to rtl8712
Changes in v3:
- Change alignment of eth_type
- Change alignment of SN_EQUAL
- Remove commit of unneeded parentheses.
Cristian
On Sat, Oct 26, 2019 at 7:52 PM Cristiane Naves
wrote:
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together. Issue
> found by coccicheck.
>
> Signed-off-by: Cristiane Naves
This is a duplicate of:
https://www.spinics.net/lists/l
On Mon, 2019-10-28 at 11:01 +0300, Dan Carpenter wrote:
> On Fri, Oct 25, 2019 at 06:50:25PM -0700, Joe Perches wrote:
> > On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote:
> > > Fix alignment should match open parenthesis.Issue found by checkpatch.
> >
> > Beyond doing style cleanups, ple
On Mon, Oct 28, 2019 at 04:39:50AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 28, 2019 at 12:17:43PM +0100, Hans de Goede wrote:
> > Hi Greg,
> >
> > As discussed previously can you please take vboxsf upstream through
> > drivers/staging?
> >
> > It has seen many revisions on the fsdevel list,
On Mon, Oct 28, 2019 at 12:17:43PM +0100, Hans de Goede wrote:
> Hi Greg,
>
> As discussed previously can you please take vboxsf upstream through
> drivers/staging?
>
> It has seen many revisions on the fsdevel list, but it seems that the
> fsdevel people are to busy to pick it up.
>
> Previous
VirtualBox hosts can share folders with guests, this commit adds a
VFS driver implementing the Linux-guest side of this, allowing folders
exported by the host to be mounted under Linux.
This driver depends on the guest <-> host IPC functions exported by
the vboxguest driver.
Signed-off-by: Hans d
Hi Greg,
As discussed previously can you please take vboxsf upstream through
drivers/staging?
It has seen many revisions on the fsdevel list, but it seems that the
fsdevel people are to busy to pick it up.
Previous versions of this patch have been reviewed by Al Viro, David Howells
and Christoph
On Mon, Oct 28, 2019 at 09:36:04AM +0100, Julia Lawall wrote:
>
>
> On Mon, 28 Oct 2019, Dan Carpenter wrote:
>
> > On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote:
> > > Remove unneeded variable used to store return value. Issue found by
> > > coccicheck.
> > >
> > > Signed-off-
On Mon, 28 Oct 2019, Dan Carpenter wrote:
> On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote:
> > Remove unneeded variable used to store return value. Issue found by
> > coccicheck.
> >
> > Signed-off-by: Cristiane Naves
> > ---
> > drivers/staging/octeon/octeon-stubs.h | 4 +--
On Sat, Oct 26, 2019 at 07:24:53PM -0300, Cristiane Naves wrote:
> Remove unneeded variable used to store return value. Issue found by
> coccicheck.
>
> Signed-off-by: Cristiane Naves
> ---
> drivers/staging/octeon/octeon-stubs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> di
On Fri, Oct 25, 2019 at 06:50:25PM -0700, Joe Perches wrote:
> On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote:
> > Fix alignment should match open parenthesis.Issue found by checkpatch.
>
> Beyond doing style cleanups, please always try
> to make the code more readable.
>
> > diff --git
When I see a RESEND in the subject, that means you are tell us we messed
up and accidentally ignored your patch. So then we have to figure out
what went wrong with the process and so we don't mess up again.
It would help us if you put a note under the --- cut off like "I sent
this a month ago and
38 matches
Mail list logo
