Re: [PATCH] staging: rtl8192u: fix indentation issue

2019-11-15 Thread Joe Perches
On Fri, 2019-11-15 at 22:45 -0800, Joe Perches wrote: > This function might as well be deleted instead as > rtl819xusb_beacon_tx is a noop function in > drivers/staging/rtl8192u/r8192U_core.c Perhaps: --- drivers/staging/rtl8192u/r8192U.h| 1 - drivers/staging/rtl8192u/r8192U_core.c |

Re: [PATCH] staging: rtl8192u: fix indentation issue

2019-11-15 Thread Joe Perches
On Thu, 2019-11-14 at 09:54 +, Colin King wrote: > From: Colin Ian King > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. [] > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > b/drivers/staging/rtl8192u/r819xU_cmdpkt.c [] > @@ -169,19 +169,

[PATCH v2] staging: rtl*: Remove tasklet callback casts

2019-11-15 Thread Kees Cook
In order to make the entire kernel usable under Clang's Control Flow Integrity protections, function prototype casts need to be avoided because this will trip CFI checks at runtime (i.e. a mismatch between the caller's expected function prototype and the destination function's prototype). Many of t

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-15 Thread Kees Cook
On Fri, Nov 15, 2019 at 02:16:10PM +0800, Greg Kroah-Hartman wrote: > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > In order to make the entire kernel usable under Clang's Control Flow > > Integrity protections, function prototype casts need to be avoided > > because this will trip

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-15 Thread Kees Cook
On Fri, Nov 15, 2019 at 10:42:35AM +0300, Dan Carpenter wrote: > On Fri, Nov 15, 2019 at 10:40:03AM +0300, Dan Carpenter wrote: > > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > > In order to make the entire kernel usable under Clang's Control Flow > > > Integrity protections, func

[PATCH v5 3/4] dt-binding: iio: Add documentation for AD7091R5

2019-11-15 Thread Beniamin Bia
Documentation for AD7091R5 ADC was added. Signed-off-by: Beniamin Bia Reviewed-by: Rob Herring --- Changes in v5: -nothing changed .../bindings/iio/adc/adi,ad7091r5.yaml| 54 +++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/

[PATCH v5 4/4] MAINTAINERS: add entry for AD7091R5 driver

2019-11-15 Thread Beniamin Bia
Add Beniamin Bia as a maintainer for AD7091R5 ADC. Signed-off-by: Beniamin Bia --- Changes in v5: -nothing changed MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2e01d0f0b0e5..7f1e4b88688f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -89

[PATCH v5 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-11-15 Thread Beniamin Bia
From: Paul Cercueil The scale can now be obtained with the "in_voltage_scale" file. By default, the scale returned corresponds to the internal VREF of 2.5V. It is possible to use an external VREF (through the REFIN/REFOUT pin of the chip), by passing a regulator to the driver. The scale will the

[PATCH v5 1/4] iio: adc: Add support for AD7091R5 ADC

2019-11-15 Thread Beniamin Bia
From: Paul Cercueil AD7091R5 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC. This driver will also support AD7091R2/4/8 in the future. Datasheet: Link: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf Signed-off-by: Paul Cercueil Co-developed-by: Beniamin Bia

Re: [PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-11-15 Thread Dan Carpenter
On Fri, Nov 15, 2019 at 02:23:14PM +0200, Beniamin Bia wrote: > @@ -216,6 +240,21 @@ int ad7091r_probe(struct device *dev, const char *name, > return ret; > } > > + st->vref = devm_regulator_get_optional(dev, "vref"); > + if (IS_ERR(st->vref)) { > +

[PATCH v4 3/4] dt-binding: iio: Add documentation for AD7091R5

2019-11-15 Thread Beniamin Bia
Documentation for AD7091R5 ADC was added. Signed-off-by: Beniamin Bia Reviewed-by: Rob Herring --- Changes in v4: -nothing changed .../bindings/iio/adc/adi,ad7091r5.yaml| 54 +++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/

[PATCH v4 4/4] MAINTAINERS: add entry for AD7091R5 driver

2019-11-15 Thread Beniamin Bia
Add Beniamin Bia as a maintainer for AD7091R5 ADC. Signed-off-by: Beniamin Bia --- Changes in v4: -nothing changed MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2e01d0f0b0e5..7f1e4b88688f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -89

[PATCH v4 1/4] iio: adc: Add support for AD7091R5 ADC

2019-11-15 Thread Beniamin Bia
From: Paul Cercueil AD7091R5 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC. This driver will also support AD7091R2/4/8 in the future. Datasheet: Link: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf Signed-off-by: Paul Cercueil Co-developed-by: Beniamin Bia

[PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-11-15 Thread Beniamin Bia
From: Paul Cercueil The scale can now be obtained with the "in_voltage_scale" file. By default, the scale returned corresponds to the internal VREF of 2.5V. It is possible to use an external VREF (through the REFIN/REFOUT pin of the chip), by passing a regulator to the driver. The scale will the