[PATCH v2] media: allegro: add the missed check for v4l2_m2m_ctx_init

2019-12-09 Thread Chuhong Yuan
allegro_open() misses a check for v4l2_m2m_ctx_init(). Add a check and error handling code to fix it. Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") Signed-off-by: Chuhong Yuan --- Changes in v2: - Fix the use-after-free in v1. drivers/staging/media/allegro-dvt/a

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread Arnd Bergmann
On Mon, Dec 9, 2019 at 7:29 PM David Miller wrote: > > From: Arnd Bergmann > Date: Mon, 9 Dec 2019 16:12:56 +0100 > > > syzbot keeps finding issues in the X.25 implementation that nobody is > > interested in fixing. Given that all the x25 patches of the past years > > that are not global cleanu

Re: [PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init

2019-12-09 Thread Dan Carpenter
On Mon, Dec 09, 2019 at 04:58:07PM +0800, Chuhong Yuan wrote: > diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c > b/drivers/staging/media/allegro-dvt/allegro-core.c > index 6f0cd0784786..5f1d454b41bb 100644 > --- a/drivers/staging/media/allegro-dvt/allegro-core.c > +++ b/drivers/stag

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 9 Dec 2019 16:12:56 +0100 > syzbot keeps finding issues in the X.25 implementation that nobody is > interested in fixing. Given that all the x25 patches of the past years > that are not global cleanups tend to fix user-triggered oopses, is it > time to just retire

Re: [PATCH 1/2] staging: remove isdn capi drivers

2019-12-09 Thread David Miller
From: Greg Kroah-Hartman Date: Mon, 9 Dec 2019 16:37:43 +0100 > On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote: >> As described in drivers/staging/isdn/TODO, the drivers are all >> assumed to be unmaintained and unused now, with gigaset being the >> last one to stop being maintaine

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 03:41:51PM +, Kim, David wrote: > Hi Greg, > > Thanks for the speedy reply. I was hoping that setting my client to > plain text only would actually do plain text only but I will try again > with git send-email. > > This is our first driver upstreaming and we targeted s

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread Greg Kroah-Hartman
On Mon, Dec 09, 2019 at 04:12:56PM +0100, Arnd Bergmann wrote: > syzbot keeps finding issues in the X.25 implementation that nobody is > interested in fixing. Given that all the x25 patches of the past years > that are not global cleanups tend to fix user-triggered oopses, is it > time to just ret

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread Kim, David
Hi Greg, Thanks for the speedy reply. I was hoping that setting my client to plain text only would actually do plain text only but I will try again with git send-email. This is our first driver upstreaming and we targeted staging as a first entry point. If you feel it's more appropriate when I

Re: [PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init

2019-12-09 Thread Michael Tretter
On Mon, 09 Dec 2019 16:58:07 +0800, Chuhong Yuan wrote: > allegro_open() misses a check for v4l2_m2m_ctx_init(). > Add a check and error handling code to fix it. > > Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") > Signed-off-by: Chuhong Yuan Reviewed-by: Michael Tr

Re: [PATCH 1/2] staging: remove isdn capi drivers

2019-12-09 Thread Greg Kroah-Hartman
On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote: > As described in drivers/staging/isdn/TODO, the drivers are all > assumed to be unmaintained and unused now, with gigaset being the > last one to stop being maintained after Paul Bolle lost access > to an ISDN network. > > The CAPI su

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 01:56:55PM +, Kim, David wrote: > > Hi everybody, > ​ > This patch introduces a driver for nCipher's Solo and Solo XC range of PCIe > hardware security modules (HSM), which provide key creation/management > and cryptography services. > > Upstreaming the nCipher driver

[PATCH 1/4] [net-next] wan: remove stale Kconfig entries

2019-12-09 Thread Arnd Bergmann
The dscc4 driver was recently removed, but these Kconfig entries remain, so remove them as well. Fixes: 28c9eb9042a9 ("net/wan: dscc4: remove broken dscc4 driver") Signed-off-by: Arnd Bergmann --- drivers/net/wan/Kconfig | 24 1 file changed, 24 deletions(-) diff --git

[PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread Arnd Bergmann
syzbot keeps finding issues in the X.25 implementation that nobody is interested in fixing. Given that all the x25 patches of the past years that are not global cleanups tend to fix user-triggered oopses, is it time to just retire the subsystem? I looked a bit closer and found: - we used to supp

[PATCH 3/4] [net-next] wan: remove old frame relay driver

2019-12-09 Thread Arnd Bergmann
The DLCI framework and SDLA driver are as obsolete as it gets, this is an ISA add-on card from the mid-1990s that has only seen sporadic cleanups. The website listed for downloading the user space tools has dropped off the internet at some point around 2010, but Debian already dropped the packages

[PATCH 2/4] [net-next] wan: remove sbni/granch driver

2019-12-09 Thread Arnd Bergmann
The driver was merged in 1999 and has only ever seen treewide cleanups since then, with no indication whatsoever that anyone has actually had access to hardware for testing the patches. >From the information in the link below, it appears that the hardware is for some leased line system in Russia t

[PATCH 2/2] isdn: capi: dead code removal

2019-12-09 Thread Arnd Bergmann
The staging isdn drivers are gone, and CONFIG_BT_CMTP is now the only user. This means a lot of the code in the subsystem has no remaining callers and can be removed. Change the capi user space front-end to be part of kernelcapi, and the combined module to only be compiled if BT_CMTP is also enabl

[PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread Kim, David
Hi everybody, ​ This patch introduces a driver for nCipher's Solo and Solo XC range of PCIe hardware security modules (HSM), which provide key creation/management and cryptography services. Upstreaming the nCipher driver into the kernel will allow early adopters of the latest kernel to upgrade an

Re: [PATCH RFC 2/6] staging: most: rename core.h to most.h

2019-12-09 Thread Christian.Gromm
On Fr, 2019-12-06 at 15:35 +0100, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, Nov 25, 2019 at 04:51:32PM +0100, Christian Gromm wrote: > > > > This patch renames the core header file core.h to most.h. The > > intention

[PATCH] staging: qlge: Fix CamelCase in qlge.h and qlge_dbg.c

2019-12-09 Thread Scott Schafer
This patch addresses CamelCase warnings in qlge.h under struct mpi_coredump_global_header and mpi_coredump_segment_header. As well ass addresses CamelCase warnings in qlge_dbg.c when the structs are used. Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 14 +++--- drive

[PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove

2019-12-09 Thread Chuhong Yuan
All drivers in imx call v4l2_async_notifier_cleanup() after unregistering the notifier except this driver. This should be a miss and we need to add the call to fix it. Signed-off-by: Chuhong Yuan --- drivers/staging/media/imx/imx7-mipi-csis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init

2019-12-09 Thread Chuhong Yuan
allegro_open() misses a check for v4l2_m2m_ctx_init(). Add a check and error handling code to fix it. Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") Signed-off-by: Chuhong Yuan --- drivers/staging/media/allegro-dvt/allegro-core.c | 7 +++ 1 file changed, 7 inser