Re: [PATCH v2 1/4] media: uapi: hevc: Add scaling matrix control

2020-01-08 Thread Mauro Carvalho Chehab
Em Fri, 13 Dec 2019 17:04:25 +0100 Jernej Skrabec escreveu: > HEVC has a scaling matrix concept. Add support for it. > +struct v4l2_ctrl_hevc_scaling_matrix { > + __u8scaling_list_4x4[6][16]; > + __u8scaling_list_8x8[6][64]; > + __u8scaling_list_16x16[6][64]; > + __u8

Re: [PATCH v2 3/4] media: uapi: hevc: Add segment address field

2020-01-08 Thread Mauro Carvalho Chehab
Em Fri, 13 Dec 2019 17:04:27 +0100 Jernej Skrabec escreveu: > If HEVC frame consists of multiple slices, segment address has to be > known in order to properly decode it. > > Add segment address field to slice parameters. > > Signed-off-by: Jernej Skrabec > --- > Documentation/media/uapi/v4l/

Re: [PATCH v2 1/4] media: uapi: hevc: Add scaling matrix control

2020-01-08 Thread Paul Kocialkowski
Hi Mauro, On Wed 08 Jan 20, 15:11, Mauro Carvalho Chehab wrote: > Em Fri, 13 Dec 2019 17:04:25 +0100 > Jernej Skrabec escreveu: > > > HEVC has a scaling matrix concept. Add support for it. > > > +struct v4l2_ctrl_hevc_scaling_matrix { > > + __u8scaling_list_4x4[6][16]; > > + __u8sca

Re: [PATCH v2 2/4] media: cedrus: hevc: Add support for scaling matrix

2020-01-08 Thread Hans Verkuil
On 1/7/20 6:10 PM, Jernej Škrabec wrote: > Hi! > > Dne torek, 07. januar 2020 ob 16:01:16 CET je Hans Verkuil napisal(a): >> On 12/13/19 5:04 PM, Jernej Skrabec wrote: >>> HEVC frames may use scaling list feature. Add support for it. >>> >>> Signed-off-by: Jernej Skrabec >>> --- >>> >>> drivers/

Re: [PATCH] media: hantro: remove a pointless NULL check

2020-01-08 Thread Ezequiel Garcia
Hi Dan, Thanks for the patch. On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote: > This can't be NULL and we've already dereferenced it so let's remove > the check. > > Signed-off-by: Dan Carpenter > --- > drivers/staging/media/hantro/hantro_v4l2.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH] media: hantro: remove a pointless NULL check

2020-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2020 at 12:08:21PM -0300, Ezequiel Garcia wrote: > Hi Dan, > > Thanks for the patch. > > On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote: > > This can't be NULL and we've already dereferenced it so let's remove > > the check. > > > > Signed-off-by: Dan Carpenter > > --- >

Re: [PATCH] media: hantro: remove a pointless NULL check

2020-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2020 at 06:18:09PM +0300, Dan Carpenter wrote: > On Wed, Jan 08, 2020 at 12:08:21PM -0300, Ezequiel Garcia wrote: > > Hi Dan, > > > > Thanks for the patch. > > > > On Wed, 2020-01-08 at 08:35 +0300, Dan Carpenter wrote: > > > This can't be NULL and we've already dereferenced it so

[PATCH] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-01-08 Thread Alexander X Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") S

[PATCH] staging: octeon: repair "fixed-link" support

2020-01-08 Thread Alexander X Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet

[PATCH 1/4] staging: vt6656: correct packet types for CTS protect, mode.

2020-01-08 Thread Malcolm Priestley
It appears that the driver still transmits in CTS protect mode even though it is not enabled in mac80211. That is both packet types PK_TYPE_11GA and PK_TYPE_11GB both use CTS protect. The only difference between them GA does not use B rates. Find if only B rate in GB or GA in protect mode other

[PATCH 4/4] staging: vt6656: Move ieee80211_rx_status off stack.

2020-01-08 Thread Malcolm Priestley
ieee80211_rx_status off stack to IEEE80211_SKB_RXCB (skb->cb) removing the need to copy on to it. skb->cb is always present as a clean buffer so simply fill it in. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/dpc.c | 21 ++--- 1 file changed, 10 insertions(+), 1

[PATCH 2/4] staging: vt6656: use NULLFUCTION stack on mac80211

2020-01-08 Thread Malcolm Priestley
It appears that the drivers does not go into power save correctly the NULL data packets are not being transmitted because it not enabled in mac80211. The driver needs to capture ieee80211_is_nullfunc headers and copy the duration_id to it's own duration data header. Cc: stable Signed-off-by: Mal

[PATCH 3/4] staging: vt6656: Fix false Tx excessive retries reporting.

2020-01-08 Thread Malcolm Priestley
The driver reporting IEEE80211_TX_STAT_ACK is not being handled correctly. The driver should only report on TSR_TMO flag is not set indicating no transmission errors and when not IEEE80211_TX_CTL_NO_ACK is being requested. Cc: stable Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/

Re: [PATCH 1/5] staging: vt6656: Fix non zero logical return of, usb_control_msg

2020-01-08 Thread Malcolm Priestley
On 06/01/2020 21:45, Quentin Deslandes wrote: > On 01/03/20 13:58:08, Dan Carpenter wrote: >> On Fri, Dec 20, 2019 at 09:14:59PM +, Malcolm Priestley wrote: >>> Starting with commit 59608cb1de1856 >>> ("staging: vt6656: clean function's error path in usbpipe.c") >>> the usb control functions ha