[staging:staging-next] BUILD INCOMPLETE d40310f65771b3a1eb9af34af433136887a64251

2020-01-14 Thread kbuild test robot
defconfig um i386_defconfig um x86_64_defconfig xtensa randconfig-a001-20200114 pariscallnoconfig pariscallyesonfig parisc

Re: [PATCH] Remove warning: "dubious: x | !y" detected by sparse

2020-01-14 Thread Dan Carpenter
Add a subsystem prefix to the subject. "Staging: kpc2000:" On Tue, Jan 14, 2020 at 10:25:15PM -0300, Felipe Cardoso Resende wrote: > The way I chose to remove the warning was to define a macro to > make it clear if a flag will be enable or not. > > Let me know if you would prefer it to be done

[PATCH] Remove warning: "dubious: x | !y" detected by sparse

2020-01-14 Thread Felipe Cardoso Resende
The way I chose to remove the warning was to define a macro to make it clear if a flag will be enable or not. Let me know if you would prefer it to be done in a different way. Signed-off-by: Felipe Cardoso Resende --- drivers/staging/kpc2000/kpc2000_i2c.c | 80 +++ 1

[PATCH 2/2] staging: comedi: ni_routes: allow partial routing information

2020-01-14 Thread Ian Abbott
This patch fixes a regression on setting up asynchronous commands to use external trigger sources when board-specific routing information is missing. `ni_find_device_routes()` (called via `ni_assign_device_routes()`) finds the table of register values for the device family and the set of valid

[PATCH 1/2] staging: comedi: ni_routes: fix null dereference in ni_find_route_source()

2020-01-14 Thread Ian Abbott
In `ni_find_route_source()`, `tables->route_values` gets dereferenced. However it is possible that `tables->route_values` is `NULL`, leading to a null pointer dereference. `tables->route_values` will be `NULL` if the call to `ni_assign_device_routes()` during board initialization returned an

[PATCH 0/2] staging: comedi: ni_routes: fix some regressions

2020-01-14 Thread Ian Abbott
Fix some regressions resulting from the routing functionality implemented for the National Instruments comedi drivers in kernel 4.20 when board-specific routing information is absent. Patch 1 fixes a null pointer dereference, but the set-up of asynchronous commands that use external triggers on

[PATCH] staging: wlan-ng: ensure error return is actually returned

2020-01-14 Thread Colin King
From: Colin Ian King Currently when the call to prism2sta_ifst fails a netdev_err error is reported, error return variable result is set to -1 but the function always returns 0 for success. Fix this by returning the error value in variable result rather than 0. Addresses-Coverity: ("Unused

[PATCH][next] staging: wilc1000: remove redundant assignment to variable result

2020-01-14 Thread Colin King
From: Colin Ian King The variable result is being initialized with a value that is never read and is being re-assigned later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/spi.c | 4 ++--

[PATCH][next] staging: vt6655: remove redundant assignment to variable ret

2020-01-14 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and is being re-assigned later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/vt6655/rf.c | 2 +- 1 file

[PATCH RFC v3 9/9] staging: most: Documentation: move ABI description files out of staging area

2020-01-14 Thread Christian Gromm
This patch moves the ABI description fils sysfs-bus-most and configfs-most to the kernel's documentation folder. Signed-off-by: Christian Gromm --- v2: v3: .../ABI/configfs-most.txt => Documentation/ABI/testing/configfs-most | 0 .../ABI/sysfs-bus-most.txt =>

[PATCH RFC v3 6/9] staging: most: change storage class of struct mostcore

2020-01-14 Thread Christian Gromm
This patch allocated the mostcore structure dynamically and releases the memory in the dedicated release function. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/core.c | 110 1 file

[PATCH RFC v3 4/9] staging: most: move interface dev to private section

2020-01-14 Thread Christian Gromm
This patch moves the struct device of the interface structure to its private section, because only the core should access it directly. For other entities an API is provided. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/core.c

[PATCH RFC v3 5/9] staging: most: usb: check for NULL device

2020-01-14 Thread Christian Gromm
Check if the dci structer has been allocated before trying to release it. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/usb/usb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH RFC v3 7/9] staging: most: move core files out of the staging area

2020-01-14 Thread Christian Gromm
This patch moves the core module to the /drivers/most directory and makes all necessary changes in order to not break the build. Signed-off-by: Christian Gromm --- v2: v3: drivers/Kconfig| 1 + drivers/Makefile | 1 +

[PATCH RFC v3 8/9] staging: most: Documentation: update ABI description

2020-01-14 Thread Christian Gromm
This patch updates the ABI description files to be in sync with current implementation. Signed-off-by: Christian Gromm --- v2: v3: .../most/Documentation/ABI/configfs-most.txt | 8 .../most/Documentation/ABI/sysfs-bus-most.txt | 24 +++--- 2 files changed,

[PATCH RFC v3 2/9] staging: most: core: use dev_* function for logging

2020-01-14 Thread Christian Gromm
This patch replaces all calls to pr_* functions and uses the dev_* functions instead. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/core.c | 61 ++--- 1 file changed, 30 insertions(+), 31

[PATCH RFC v3 1/9] staging: most: core: fix date in file comment

2020-01-14 Thread Christian Gromm
This patch updates the date range in the comment section. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/core.c

[PATCH RFC v3 3/9] staging: most: core: remove noisy log messages

2020-01-14 Thread Christian Gromm
In order to not generate unnecessary noise in the kernel log,this patch removes debug log messages. Signed-off-by: Christian Gromm --- v3: This patch has been added to the series. drivers/staging/most/core.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH RFC v3 0/9] staging: most: move core module out of staging

2020-01-14 Thread Christian Gromm
The MOST driver was pushed to the staging area with kernel 4.3. Since then it has encountered many refinements by the community and should be ready for an upstream audit and to be moved out of the staging area. Since the driver consists of multiple modules the core module is about to go first and

Re: [PATCH] binder: fix log spam for existing debugfs file creation.

2020-01-14 Thread Greg Kroah-Hartman
On Fri, Jan 10, 2020 at 04:44:01PM +0100, Martin Fuzzey wrote: > Since commit 43e23b6c0b01 ("debugfs: log errors when something goes wrong") > debugfs logs attempts to create existing files. > > However binder attempts to create multiple debugfs files with > the same name when a single PID has

Re: [PATCH] staging: most: remove header include path to drivers/staging

2020-01-14 Thread Greg Kroah-Hartman
On Sun, Jan 05, 2020 at 01:18:27AM +0900, Masahiro Yamada wrote: > There is no need to add "ccflags-y += -I $(srctree)/drivers/staging" > just for including . > > Use the #include "..." directive with the correct relative path. > > Signed-off-by: Masahiro Yamada This patch doesn't apply to my

Re: [PATCH v4] drivers/staging/exfat/exfat_super.c: Clean up ffsCamelCase function names

2020-01-14 Thread Greg KH
On Tue, Jan 07, 2020 at 03:33:37PM +0100, Julian Preis wrote: > Rename every instance of to > in file exfat_super.c. Fix resulting overlong lines. > > Co-developed-by: Johannes Weidner > Signed-off-by: Johannes Weidner > Signed-off-by: Julian Preis I get an odd error when trying to apply

[PATCH 4/5] staging: rtl8188eu: remove unnecessary parentheses in rtl8188e_dm.c

2020-01-14 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c

[PATCH 5/5] staging: rtl8188eu: cleanup whitespace in rtl8188e_dm.c

2020-01-14 Thread Michael Straube
Replace tabs with spaces and/or remove spaces to use typical kernel horizontal whitespace. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[PATCH 1/5] staging: rtl8188eu: refactor rtw_hal_antdiv_before_linked()

2020-01-14 Thread Michael Straube
Refactor rtw_hal_antdiv_before_linked() to clear checkpatch warnings. WARNING: line over 80 characters WARNING: else is not generally useful after a break or return Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 17 + 1 file changed, 9

[PATCH 3/5] staging: rtl8188eu: cleanup long lines in rtl8188e_dm.c

2020-01-14 Thread Michael Straube
Cleanup lines over 80 characters in rtl8188e_dm.c by adding appropriate line breaks. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 26 ++--- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git