Re: [PATCH] staging: media: rkisp1: make links immutable by default

2020-01-17 Thread Niklas Söderlund
Hi Helen, Thanks for your work. On 2020-01-17 17:12:18 -0300, Helen Koike wrote: > The only places which make sese to allow users to enable or disable > links are: > > * between sensors and isp: > So users can select which sensor should be used while streaming > > * between isp and the resizers

[PATCH] staging: media: rkisp1: make links immutable by default

2020-01-17 Thread Helen Koike
The only places which make sese to allow users to enable or disable links are: * between sensors and isp: So users can select which sensor should be used while streaming * between isp and the resizers: | v here rkisp1_isp:2 -> rkisp1_resizer_mainpath -> rkisp1_mainpath

[staging:staging-testing] BUILD SUCCESS 270f104ba26f0498aff85e5b002e2f4c2249c04b

2020-01-17 Thread kbuild test robot
configs may be tested in the coming days. x86_64 randconfig-g001-20200117 x86_64 randconfig-g002-20200117 x86_64 randconfig-g003-20200117 i386 randconfig-g001-20200117 i386 randconfig-g002-20200117 i386

[PATCH 3/4] staging: wilc1000: added 'wilc_' prefix for 'struct assoc_resp' name

2020-01-17 Thread Ajay.Kathat
From: Ajay Singh Use 'wilc_' prefix for 'assoc_resp' struct to have proper naming convention. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/fw.h | 2 +- drivers/staging/wilc1000/hif.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/fw.h

[PATCH 2/4] staging: wilc1000: move firmware API struct's to separate header file

2020-01-17 Thread Ajay.Kathat
From: Ajay Singh It's recommended to keep the 'struct' used for passing data to firmware in separate header file. So added 'fw.h' header file to keep struct's used to pass data to firmware. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/fw.h | 119 + dr

[PATCH 4/4] staging: wilc1000: remove unused code prior to throughput enhancement in SPI

2020-01-17 Thread Ajay.Kathat
From: Ajay Singh The firmware now uses throughput enhancement code by default for SPI so remove the previous implementation as its not used anymore. Removed the use of 'has_thrpt_enh' element as its always true. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/spi.c | 143 +--

[PATCH 1/4] staging: wilc1000: remove use of infinite loop conditions

2020-01-17 Thread Ajay.Kathat
From: Ajay Singh Avoid the use of 'while (1)' infinite loop conditions. It's not recommended to have infinite loop in kernel code because a small bug can cause never ending loops so use terminator condition as suggested in full driver review [1]. [1]. https://lore.kernel.org/linux-wireless/2019

[PATCH 0/4] staging: wilc1000: handle few full driver review comments

2020-01-17 Thread Ajay.Kathat
From: Ajay Singh The patch series contains changes to address the below code review comments - 1/ Avoid use of infinite loops. 2/ Use separate header file to keep firmware related 'struct'. 3/ Remove unused code. Ajay Singh (4): staging: wilc1000: remove use of infinite loop conditions s