Re: [PATCH] staging: exfat: remove fs_func struct.

2020-01-22 Thread Dan Carpenter
On Thu, Jan 23, 2020 at 03:04:35PM +0800, m...@kaowomen.cn wrote: > On Thu, Jan 23, 2020 at 06:38:53AM +, > kohada.tetsuh...@dc.mitsubishielectric.co.jp wrote: > > Hello, Greg. > > > > Thank you for the quick reply. > > > > > Also the patch does not apply to the linux-next tree at all, so I

Re: [PATCH] staging: exfat: remove fs_func struct.

2020-01-22 Thread me
On Thu, Jan 23, 2020 at 06:38:53AM +, kohada.tetsuh...@dc.mitsubishielectric.co.jp wrote: Hello, Greg. Thank you for the quick reply. Also the patch does not apply to the linux-next tree at all, so I can't take it. The patch I sent was based on the master branch of

Re: [PATCH] staging: exfat: remove fs_func struct.

2020-01-22 Thread Dan Carpenter
On Thu, Jan 23, 2020 at 06:38:53AM +, kohada.tetsuh...@dc.mitsubishielectric.co.jp wrote: > Hello, Greg. > > Thank you for the quick reply. > > > Also the patch does not apply to the linux-next tree at all, so I can't > > take it. > The patch I sent was based on the master branch of >

RE: [PATCH] staging: exfat: remove fs_func struct.

2020-01-22 Thread kohada.tetsuh...@dc.mitsubishielectric.co.jp
Hello, Greg. Thank you for the quick reply. > Also the patch does not apply to the linux-next tree at all, so I can't take > it. The patch I sent was based on the master branch of “https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/” and its tag was v5.5-rc6. > Also the patch

Re: [PATCH] staging: qlge: fix spelling mistake "to" -> "too"

2020-01-22 Thread Benjamin Poirier
On 2020/01/23 00:07 +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netif_printk message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/staging/qlge/qlge_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] staging: comedi: drivers: fix spelling mistake "to" -> "too"

2020-01-22 Thread Colin King
From: Colin Ian King There is a spelling mistake in a deb_dbg message. Fix it. Signed-off-by: Colin Ian King --- drivers/staging/comedi/drivers/das6402.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das6402.c

[PATCH] staging: qlge: fix spelling mistake "to" -> "too"

2020-01-22 Thread Colin King
From: Colin Ian King There is a spelling mistake in a netif_printk message. Fix it. Signed-off-by: Colin Ian King --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread Vladimir Stankovic
On 22.1.20. 09:49, gre...@linuxfoundation.org wrote: > A: http://en.wikipedia.org/wiki/Top_post > > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting

Re: [PATCH] staging: exfat: remove fs_func struct.

2020-01-22 Thread Greg Kroah-Hartman
On Fri, Jan 17, 2020 at 03:20:46PM +0900, T.Kohada wrote: > Remove 'fs_func struct' and change indirect calls to direct calls. > > The following issues are described in exfat's TODO. > > Create helper function for exfat_set_entry_time () and > > exfat_set_entry_type () because it's sort of ugly

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH] staging: qlge: fix missing a blank line after declaration

2020-01-22 Thread Greg KH
On Sun, Jan 19, 2020 at 04:03:59PM +0200, Valery Ivanov wrote: > This patch fixes "WARNING: Missing a blank lin after declarations" > Issue found by checkpatch.pl > > Signed-off-by: Valery Ivanov > --- > drivers/staging/qlge/qlge_ethtool.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH] staging: mt7621-pinctrl: Align code by cleanup long lines

2020-01-22 Thread Dan Carpenter
On Tue, Jan 21, 2020 at 08:52:18PM +0100, Sandesh Kenjana Ashok wrote: > Cleanup lines over 80 characters in pinctrl-rt2880.c. > Issue found by checkpatch.pl > > Signed-off-by: Sandesh Kenjana Ashok > --- > drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 4 ++-- > 1 file changed, 2

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread Vladimir Stankovic
Hi Greg, It was section 2.5 of the kernel development process, "staging trees". In particular, statement "where many sub-directories for drivers or filesystems that are on their way to being added to the kernel tree live" caught our attention. Now, by reading it once again, I see that the rest