[PATCH] staging: exfat: Replace printk with pr_info

2020-02-10 Thread JieunKim
pr_info is preferred to use than printk. pr_info calls printk with KERN_INFO macros by itself. Signed-off-by: JieunKim --- drivers/staging/exfat/exfat_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_su

[PATCH 0/6] staging: rtl8188eu and rtl8723bs - some fixes and cleanups

2020-02-10 Thread Larry Finger
It was recently reported that staging drivers rtl8188eu and rtl8723bs contained a security flaw because a parameter had not been checked. The following patches fix that flaw and cleans up the routines. Signed-off-by: Larry Finger Larry Finger (6): staging: rtl8188eu: Fix potential security ho

[PATCH 6/6] staging: rtl8723bs: Remove unneeded goto statements

2020-02-10 Thread Larry Finger
In routines rtw_hostapd_ioctl() and wpa_supplicant_ioctl(), several error conditions involve setting a variable indicating the error, followed by a goto. The code following the target of that goto merely returns the value. It is simpler, therefore to return the error value immediately, and eliminat

[PATCH 2/6] staging: rtl8723bs: Fix potential security hole

2020-02-10 Thread Larry Finger
In routine rtw_hostapd_ioctl(), the user-controlled p->length is assumed to be at least the size of struct ieee_param size, but this assumption is never checked. This could result in out-of-bounds read/write on kernel heap in case a p->length less than the size of struct ieee_param is specified by

[PATCH 5/6] staging: rtl8188eu: Remove some unneeded goto statements

2020-02-10 Thread Larry Finger
In routines rtw_hostapd_ioctl() and wpa_supplicant_ioctl(), several error conditions involve setting a variable indicating the error, followed by a goto. The code following the target of that goto merely returns the value. It is simpler, therefore to return the error value immediately, and eliminat

[PATCH 4/6] staging: rtl8723bs: Fix potential overuse of kernel memory

2020-02-10 Thread Larry Finger
In routine wpa_supplicant_ioctl(), the user-controlled p->length is checked to be at least the size of struct ieee_param size, but the code does not detect the case where p->length is greater than the size of the struct, thus a malicious user could be wasting kernel memory. Fixes commit 554c0a3abf2

[PATCH 3/6] staging: rtl8188eu: Fix potential overuse of kernel memory

2020-02-10 Thread Larry Finger
In routine wpa_supplicant_ioctl(), the user-controlled p->length is checked to be at least the size of struct ieee_param size, but the code does not detect the case where p->length is greater than the size of the struct, thus a malicious user could be wasting kernel memory. Fixes commit a2c60d42d97

[PATCH 1/6] staging: rtl8188eu: Fix potential security hole

2020-02-10 Thread Larry Finger
In routine rtw_hostapd_ioctl(), the user-controlled p->length is assumed to be at least the size of struct ieee_param size, but this assumption is never checked. This could result in out-of-bounds read/write on kernel heap in case a p->length less than the size of struct ieee_param is specified by

Re: [PATCH 4/6] staging: rtl8723bs: Fix potential overuse of kernel memory

2020-02-10 Thread Greg KH
On Mon, Feb 10, 2020 at 12:02:33PM -0600, Larry Finger wrote: > In routine wpa_supplicant_ioctl(), the user-controlled p->length is > checked to be at least the size of struct ieee_param size, but the code > does not detect the case where p->length is greater than the size > of the struct, thus a m

[PATCH v2 00/19] Renaming some identifiers.

2020-02-10 Thread Pragat Pandya
This patchset renames following nineteen variables in exfat.h Fix checkpatch warning: Avoid CamelCase -Year->year -Day->day -Hour->hour -Minute->minute -Second->second -Millisecond->millisecond -FatType->fat_type -ClusterSize->cluster_size -NumClusters->num_clusters -FreeClusters->free_cl

[PATCH v2 03/19] staging: exfat: Rename variable 'Day' to 'day'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Day" to "day" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-10 Thread Ajay.Kathat
From: Ajay Singh Refactor handling of P2P specific action frames. Make use of 'struct' to handle the P2P frames instead of manipulating using 'buf' pointer. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/cfg80211.c | 298 1 file changed, 127 insertions(+),

[PATCH 2/3] staging: wilc1000: directly fetch 'priv' handler from 'vif' instance

2020-02-10 Thread Ajay.Kathat
From: Ajay Singh The 'priv' handler is already present in 'vif' struct so directly fetch its value from vif handler in wilc_handle_roc_expired(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/hif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/w

[PATCH v2 01/19] staging: exfat: Rename variable 'Year' to 'year'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Year" to "year" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --gi

[PATCH 1/3] staging: wilc1000: remove use of vendor specific IE for p2p handling

2020-02-10 Thread Ajay.Kathat
From: Ajay Singh Remove the use of vendor specific IE parameter to decide p2p_GO/p2p_Client roles between two 'wilc' device. Previously p2p group formation between two 'wilc' device make use of vendor IE for roles decision. The role is decided based on the 'go_intent' value. Signed-off-by: Ajay

[PATCH v2 02/19] staging: exfat: Rename variable 'Month' to 'month'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Month" to "month" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --

[PATCH v2 05/19] staging: exfat: Rename variable 'Minute' to 'minute'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Minute" to "minute" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff

[PATCH v2 04/19] staging: exfat: Rename variable 'Hour' to 'hour'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Hour" to "hour" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --gi

[PATCH v2 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ClusterSize" to "cluster_size" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "MilliSecond" to "millisecond" Signed-off-by: Pragat Pandya --- Changes in v1: -Rename variable "MilliSecond" to "milli_second" Changes in v2: -Remove unnecessary '_' underscore character in renamed identifier name.

[PATCH v2 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "FatType" to "fat_type" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s

[PATCH v2 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_clusters'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences identifier "NumClusters" to "num_clusters" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --gi

[PATCH v2 15/19] staging: exfat: Rename variable 'Attr' to 'attr'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Attr" to "attr" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 24 2 files changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v2 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ShortName" to "short_name" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH v2 06/19] staging: exfat: Rename variable 'Second' to 'second'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Second" to "second" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff

[PATCH v2 13/19] staging: exfat: Rename variable 'Name' to 'name'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Name" to "name" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/driver

[PATCH v2 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "FreeClusters" to "free_clusters" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --g

[PATCH v2 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "UsedClusters" to "used_clusters" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --g

[PATCH v2 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "AccessTimestamp" to "access_timestamp" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-)

[PATCH v2 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ModifyTimestamp" to "modify_timestamp" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 46 ++--- 2 files changed, 24 insertion

[PATCH v2 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "NumSubdirs" to "num_subdirs" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --g

[PATCH v2 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp'

2020-02-10 Thread Pragat Pandya
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "CreateTimestamp" to "create_timestamp" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 46 ++--- 2 files changed, 24 insertion

[PATCH] staging: rtl8188eu: rename variable pnetdev -> netdev

2020-02-10 Thread Michael Straube
Rename the local variable pnetdev in rtw_alloc_etherdev_with_old_priv to avoid hungarian notation and clear the last checkpatch warning in the file osdep_service.c. rtl8188eu/os_dep/osdep_service.c:32: WARNING: line over 80 characters Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu

Re: [PATCH 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-10 Thread Dan Carpenter
On Mon, Feb 10, 2020 at 06:36:01PM +, ajay.kat...@microchip.com wrote: > + if (sta_ch == WILC_INVALID_CHANNEL) > + return; > > while (index < len) { This range checking was there in the original code, but it's not correct. index and len are in terms of bytes so we know

Re: [PATCH 3/3] staging: wilc1000: refactor p2p action frames handling API's

2020-02-10 Thread Dan Carpenter
On Tue, Feb 11, 2020 at 09:51:01AM +0300, Dan Carpenter wrote: > On Mon, Feb 10, 2020 at 06:36:01PM +, ajay.kat...@microchip.com wrote: > > + if (sta_ch == WILC_INVALID_CHANNEL) > > + return; > > > > while (index < len) { > > This range checking was there in the original code