Re: [PATCH] staging: qlge: add braces around macro arguments

2020-02-23 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 02:32:25PM +0900, Benjamin Poirier wrote: > On 2020/02/22 01:26 +0530, Kaaira Gupta wrote: > > Fix checkpatch.pl warnings of adding braces around macro arguments to > > prevent precedence issues by adding braces in qlge_dbg.c > > > > Signed-off-by: Kaaira Gupta > > --- > >

Re: [PATCH] staging: qlge: add braces around macro arguments

2020-02-23 Thread Benjamin Poirier
On 2020/02/22 01:26 +0530, Kaaira Gupta wrote: > Fix checkpatch.pl warnings of adding braces around macro arguments to > prevent precedence issues by adding braces in qlge_dbg.c > > Signed-off-by: Kaaira Gupta > --- > drivers/staging/qlge/qlge_dbg.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] staging: rtl8723bs: remove temporary variable CrystalCap

2020-02-23 Thread Joe Perches
On Sun, 2020-02-23 at 15:14 +, Colin King wrote: > odm_GetDefaultCrytaltalCap Might change the likely function name typo too from odm_GetDefaultCrytaltalCap to odm_GetDefaultCrystalCap ___ devel mailing list de...@linuxdriverprojec

[PATCH] staging: wfx: match parentheses alignment

2020-02-23 Thread Kaaira Gupta
match next line with open parentheses by giving appropriate tabs. Signed-off-by: Kaaira Gupta --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 20f4740734f2..815fde0913f5

[PATCH] staging: exfat: remove sync_alloc_bitmap()

2020-02-23 Thread Kaaira Gupta
sync_alloc_bitmap() is not called anywhere, hence remove it from exfat_core.c and exfat.h Signed-off-by: Kaaira Gupta --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 12 2 files changed, 13 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH] staging: exfat: remove exfat_buf_sync()

2020-02-23 Thread Kaaira Gupta
exfat_buf_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Signed-off-by: Kaaira Gupta --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_cache.c | 19 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/exfat/e

[PATCH v3] staging: qlge: emit debug and dump at same level

2020-02-23 Thread Kaaira Gupta
Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() instead of existing functions so that the debug and dump are emitted at the same KERN_ Signed-off-by: Kaaira Gupta --- changes since v1: make code of ql_mpi_core_to_log() simpler. changes since v2: directly call the function inste

Re: [PATCH] staging: speakup: remove redundant initialization of pointer p_key

2020-02-23 Thread Samuel Thibault
Colin King, le dim. 23 févr. 2020 15:39:54 +, a ecrit: > From: Colin Ian King > > Pointer p_key is being initialized with a value that is never read, > it is assigned a new value later on. The initialization is redundant > and can be removed. > > Addresses-Coverity: ("Unused value") > Signed

[PATCH] staging: speakup: remove redundant initialization of pointer p_key

2020-02-23 Thread Colin King
From: Colin Ian King Pointer p_key is being initialized with a value that is never read, it is assigned a new value later on. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/speakup/keyhelp.c | 2 +- 1 f

[PATCH] staging: rtl8723bs: core: remove redundant zero'ing of counter variable k

2020-02-23 Thread Colin King
From: Colin Ian King The zero'ing of counter variable k is redundant as it is never read after breaking out of the while loop. Remove it. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 +--- 1 file changed, 1 insertion(+),

[PATCH] staging: rtl8188eu: remove redundant assignment to cond

2020-02-23 Thread Colin King
From: Colin Ian King Variable cond is initialized to a value that is never read and it is re-assigned later. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- 1 file changed,

[PATCH] staging: rtl8723bs: remove temporary variable CrystalCap

2020-02-23 Thread Colin King
From: Colin Ian King Currently variable CrystalCap is being initialized with the value 0x20 that is never read so that is redundant and can be removed. Clean up the code by removing the need for variable CrystalCap since the calculation of the return value is relatively simple. Addresses-Coverit

[PATCH] docs: dt: fix several broken doc references

2020-02-23 Thread Mauro Carvalho Chehab
There are several DT doc references that require manual fixes. I found 3 cases fixed on this patch: - directory named "binding/" instead of "bindings/"; - .txt to .yaml renames; - file renames (still on txt format); Signed-off-by: Mauro Carvalho Chehab --- .../devicetree

Re: [PATCH] staging: exfat: remove exfat_fat_sync()

2020-02-23 Thread Valdis Klētnieks
On Wed, 19 Feb 2020 21:47:38 +0530, you said: > exfat_fat_sync() is not called anywhere, hence remove it from > exfat_cache.c and exfat.h Yes, it's a leftover from the fat/vfat support that got taken out. Acked-by: Valdis Kletnieks pgpq4XA0lOzRP.pgp Description: PGP signature _

Re: [RFC PATCH] staging: exfat: remove symlink feature.

2020-02-23 Thread Valdis Klētnieks
On Wed, 19 Feb 2020 14:57:27 +0900, Tetsuhiro Kohada said: > Remove symlink feature completely. > > Becouse > -Uses reserved areas(defined in the Microsoft exfat specification), causing > future incompatibilities. > -Not described in Microsoft exfat specifications or SD standards. > -For REMOVABLE