On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
> The subject isn't really quite appropriate as you
> are not doing this space around
On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > Add space around & operator for improving the code
> > readability.
> I guess you found this with checkpatch. If so, it could be nice to add
> "Reported by checkpatch." to the log message.
Hi
> > > Those clocks are part of the CSI-2 protocol and also don't need to be
> > > explicitly controlled. As far as I can tell from a quick check of the
> > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that
> > > needs to be exposed.
(snip)
> > Do you know, by chance,
allnoconfig
pariscgeneric-64bit_defconfig
pariscgeneric-32bit_defconfig
parisc allyesconfig
x86_64 randconfig-a001-20200308
x86_64 randconfig-a002-20200308
x86_64 randconfig-a003-20200308
On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> Add space around operators for improving the code
> readability.
Hello again Shreeya.
The subject isn't really quite appropriate as you
are not doing this space around operator addition
for the entire subsystem.
IMO, the subject should
: error: void value not ignored as it ought
to be
Error ids grouped by kconfigs:
recent_errors
`-- powerpc-randconfig-a001-20200308
`--
arch-powerpc-kernel-traps.c:error:void-value-not-ignored-as-it-ought-to-be
elapsed time: 822m
configs tested: 145
configs skipped: 0
arm
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git
On Sun, 2020-03-08 at 21:17 +0100, Julia Lawall wrote:
>
> On Mon, 9 Mar 2020, Shreeya Patel wrote:
>
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> >
> > Hi Joe,
> >
> > > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > > > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> >
On Sun, 2020-03-08 at 13:19 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote:
> > On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> > Hi Joe,
>
> Hello.
> []
> > > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > > >
On Mon, 2020-03-09 at 01:40 +0530, Shreeya Patel wrote:
> On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
> Hi Joe,
Hello.
[]
> > > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > > b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > []
> > > > @@ -924,7 +924,7 @@ static void
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
>
> Hi Joe,
>
> > On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> > >
> > > > Add space around & operator for improving the code
> > > >
Remove comparison to "true" from if statement to
maintain the kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
On Sun, 2020-03-08 at 12:59 -0700, Joe Perches wrote:
Hi Joe,
> On Sun, 2020-03-08 at 20:31 +0100, Julia Lawall wrote:
> > On Mon, 9 Mar 2020, Shreeya Patel wrote:
> >
> > > Add space around & operator for improving the code
> > > readability.
> > I guess you found this with checkpatch. If so,
On Mon, 9 Mar 2020, Shreeya Patel wrote:
> Add space around & operator for improving the code
> readability.
I guess you found this with checkpatch. If so, it could be nice to add
"Reported by checkpatch." to the log message. OK otherwise.
Acked-by: Julia Lawall
>
> Signed-off-by: Shreeya
Add space around & operator for improving the code
readability.
Signed-off-by: Shreeya Patel
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
b/drivers/staging/rtl8188eu/core/rtw_mlme.c
>>> */
>>> #undef __NO_VERSION__
>>>
>>> +#include
>>> #include
>>> #include
>>> #include "device.h"
>>> @@ -802,8 +803,7 @@ static u64 vnt_prepare_multicast(struct ieee80211_hw
>>> *hw,
>>>
>>> netdev_hw_addr_list_for_each(ha, mc_list) {
>>> bit_nr = ether_crc(ETH_ALEN,
Dearest Friend
I am Mr Abdul Kareem working with Emirate NBD Bank Dubai,United Arab Emirate as
Finance Manager.
I have a very profitable Business that concerns you and will benefit both of us
after completion.
Kindly get back to me for more details.
Awaiting your response.
Regards
Abdul Kareem
Dearest Friend
I am Mr Abdul Kareem working with Emirate NBD Bank Dubai,United Arab Emirate as
Finance Manager.
I have a very profitable Business that concerns you and will benefit both of us
after completion.
Kindly get back to me for more details.
Awaiting your response.
Regards
Abdul Kareem
On Sun, Mar 08, 2020 at 07:55:38AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 07, 2020 at 11:49:29AM +0100, Oscar Carter wrote:
> > Replace the bit left shift operation with the BIT_ULL() macro and remove
> > the unnecessary "and" operation against the bit_nr variable.
> >
> > Signed-off-by:
-a001-20200308 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout b5ecb947d7ee5c3510544593d3932cd6f6515afc
Function 'mt7621_pcie_init_virtual_bridges' is a bit mess and can be
refactorized properly in a cleaner way. Introduce new 'pcie_rmw' inline
function helper to do clear and set the correct bits this function needs
to work.
Signed-off-by: Sergio Paracuellos
---
Changes are only compile tested.
21 matches
Mail list logo
