[PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()

2020-03-31 Thread Chen Zhou
In gb_lights_light_config(), 'light->name' is allocated by kstrndup(). It returns NULL when fails, add check for it. Signed-off-by: Chen Zhou --- drivers/staging/greybus/light.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/light.c b/drivers/stagin

[driver-core:debugfs_remove_return_value] BUILD SUCCESS 3777507a35aed836416a6233140b9f889cbb90d7

2020-03-31 Thread kbuild test robot
generic-32bit_defconfig pariscgeneric-64bit_defconfig x86_64 randconfig-a001-20200331 x86_64 randconfig-a002-20200331 x86_64 randconfig-a003-20200331 i386 randconfig-a001-20200331 i386 randconfig-a002

[driver-core:debugfs_cleanup] BUILD SUCCESS 8bc760d4977eeecc8c9eb13d5614f39d73151c0e

2020-03-31 Thread kbuild test robot
x86_64 randconfig-a003-20200331 x86_64 randconfig-a002-20200331 i386 randconfig-a001-20200331 i386 randconfig-a002-20200331 i386 randconfig-a003-20200331 x86_64 randconfig-a001-20200331 riscv

Re: b276527539 ("staging: most: move core files out of the staging .."): [ 12.247349] BUG: kernel NULL pointer dereference, address: 00000000

2020-03-31 Thread Christian.Gromm
On Sun, 2020-03-29 at 21:39 +0800, kernel test robot wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad > commit is > > https://git.kernel.org/pub/scm/linux/kerne

SPDX headers - Was: Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Mauro Carvalho Chehab
Em Tue, 31 Mar 2020 15:06:08 +0300 Laurent Pinchart escreveu: > I've however been thinking about licenses for > build system files recently, and I'll hijack this thread a bit to ask a > question :-) Ok, I'll change the subject, as the answers won't be related to the Kernel :-) > For a project l

Re: [staging:staging-testing 278/280] drivers/most/core.c:1287 most_register_interface() error: we previously assumed 'iface' could be null (see line 1285)

2020-03-31 Thread Christian.Gromm
On Tue, 2020-03-31 at 13:45 +0300, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > Hi Christian, > > First bad commit (maybe != root cause): > > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >

Re: [PATCH V2] x86/Hyper-V: don't allocate clockevent device when synthetic timer is unavailable

2020-03-31 Thread Tianyu Lan
On 3/31/2020 7:20 PM, Vitaly Kuznetsov wrote: ltyker...@gmail.com writes: From: Tianyu Lan Current code initializes clock event data structure for syn timer even when it's unavailable. Fix it. Signed-off-by: Tianyu Lan --- Change since v1: Update title and commit log. drivers/hv/

Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Laurent Pinchart
Hi Greg, On Tue, Mar 31, 2020 at 02:47:56PM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 31, 2020 at 03:39:14PM +0300, Laurent Pinchart wrote: > > On Tue, Mar 31, 2020 at 02:22:09PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laurent Pinchart wrote: > > > > O

Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Greg Kroah-Hartman
On Tue, Mar 31, 2020 at 03:39:14PM +0300, Laurent Pinchart wrote: > Hi Greg, > > On Tue, Mar 31, 2020 at 02:22:09PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laurent Pinchart wrote: > > > On Tue, Mar 31, 2020 at 01:11:53PM +0200, Mauro Carvalho Chehab wrote: >

Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Laurent Pinchart
Hi Greg, On Tue, Mar 31, 2020 at 02:22:09PM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laurent Pinchart wrote: > > On Tue, Mar 31, 2020 at 01:11:53PM +0200, Mauro Carvalho Chehab wrote: > > > Most of media Kconfig/Makefile files already has SPDX, > > > but there a

Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Greg Kroah-Hartman
On Tue, Mar 31, 2020 at 03:06:08PM +0300, Laurent Pinchart wrote: > Hi Mauro, > > Thank you for the patch. > > On Tue, Mar 31, 2020 at 01:11:53PM +0200, Mauro Carvalho Chehab wrote: > > Most of media Kconfig/Makefile files already has SPDX, > > but there are a few ones still missing. Add it to th

Re: [PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Tue, Mar 31, 2020 at 01:11:53PM +0200, Mauro Carvalho Chehab wrote: > Most of media Kconfig/Makefile files already has SPDX, > but there are a few ones still missing. Add it to them. I think it's a good idea to state the license of each source file, the patc

Re: [PATCH V2] x86/Hyper-V: don't allocate clockevent device when synthetic timer is unavailable

2020-03-31 Thread Vitaly Kuznetsov
ltyker...@gmail.com writes: > From: Tianyu Lan > > Current code initializes clock event data structure for syn timer > even when it's unavailable. Fix it. > > Signed-off-by: Tianyu Lan > --- > Change since v1: > Update title and commit log. > > drivers/hv/hv.c | 15 +-- > 1 f

[PATCH v4 17/33] media: add SPDX headers on Kconfig and Makefile files

2020-03-31 Thread Mauro Carvalho Chehab
Most of media Kconfig/Makefile files already has SPDX, but there are a few ones still missing. Add it to them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/Kconfig | 2 ++ drivers/media/mc/Kconfig| 2 ++ drivers/media/platform/sunxi/Kco

[PATCH v4 00/33] Media Kconfig menu reorg and improvements

2020-03-31 Thread Mauro Carvalho Chehab
The media Kconfig menu is complex. From time to time, it requires some improvements. This series is organized on two parts: 1. Patches 1 to 19: cleanups and improvements; - Try to be smarter when selecting features. So, auto-select Cypress firmware support on drivers that use it. Also, auto-

[PATCH v4 19/33] media: Kconfig files: use select for V4L2 subdevs and MC

2020-03-31 Thread Mauro Carvalho Chehab
There are lots of drivers that only work when the media controller and/or the V4L2 subdev APIs are present. Right now, someone need to first enable those APIs before using those drivers. Well, ideally, drivers, should, instead *optionally* depend on it, in order for PC camera drivers to be able t

[staging:staging-testing 278/280] drivers/most/core.c:1287 most_register_interface() error: we previously assumed 'iface' could be null (see line 1285)

2020-03-31 Thread Dan Carpenter
Hi Christian, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 4a1a3e9bf5654e98bb48f5b074af17af96ded30d commit: b276527539188f1f61c082ebef27803db93e536d [278/280] staging: most: move core files out of the

Re: [PATCH] staging: vt6656: Use BIT() macro in vnt_mac_reg_bits_* functions

2020-03-31 Thread Dan Carpenter
On Thu, Mar 26, 2020 at 06:10:43PM +0100, Oscar Carter wrote: > I will make these changes and i will send and incremental patch with the > "Fixes:" tag due to the this patch has already been added to the staging-next > branch of the greg staging tree. Fixes is only for bug fixes, not style issues.

Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines

2020-03-31 Thread Dan Carpenter
Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: vt6656: Use defines in vnt_mac_reg_bits_* functions

2020-03-31 Thread Dan Carpenter
On Sat, Mar 28, 2020 at 10:54:33AM +0100, Oscar Carter wrote: > Define the necessary bits in the CHANNEL, PAPEDELAY and GPIOCTL0 > registers to can use them in the calls to vnt_mac_reg_bits_on and > vnt_mac_reg_bits_off functions. In this way, avoid the use of BIT() > macros and clarify the code. >

Re: [PATCH v8] staging: vt6656: add error code handling to unused variable

2020-03-31 Thread Quentin Deslandes
On 03/31/20 02:01:03, Stefano Brivio wrote: > On Mon, 30 Mar 2020 16:39:00 -0700 > "John B. Wyatt IV" wrote: > > > Add error code handling to unused 'ret' variable that was never used. > > Return an error code from functions called within vnt_radio_power_on. > > > > Issue reported by coccinelle