Hi,
Am 06.04.20 um 04:04 schrieb kernel test robot:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: aad378845d9334d223d0d56db8332ce071d90202 ("[PATCH 9/9] staging:
> bcm2835-camera: reduce indentation in ctrl_set_image_effect")
> url:
> https://github.com/0day-ci/linux/com
On Tue, Apr 14, 2020 at 04:12:14PM +0300, Dan Carpenter wrote:
> On Mon, Apr 13, 2020 at 04:02:09PM +0200, Oscar Carter wrote:
> > diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> > index 4f9aba0f21b0..3b200d7290a5 100644
> > --- a/drivers/staging/vt6656/rf.c
> > +++ b/drive
From: Jérôme Pouiller
wfx_fwd_probe_req() is a function of two lines called from only one
place. In order to uniformize all filtering functions, drop
wfx_fwd_probe_req().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 14 +-
drivers/staging/wfx/sta.h | 1 -
2 files
From: Jérôme Pouiller
It is now useless to store filter_prbreq and filter_bssid in struct
wfx_vif. We can just pass them as parameters to hif_set_rx_filter().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 12 ++--
drivers/staging/wfx/wfx.h | 2 --
2 files changed, 6 i
From: Jérôme Pouiller
After hif_reset(), device stop to receive any RF data. So, it is
useless to disable beacon filtering. In add, if necessary, mac80211 will
call wfx_configure_filter().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 --
1 file changed, 2 deletions(-)
diff
From: Jérôme Pouiller
Filters provided by HIF API are sometime inclusive, sometime exclusive.
This patch align the behavior and name of the probe request filter with
the other filters.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 4 ++--
drivers/staging/wfx/sta.c
From: Jérôme Pouiller
Currently, wfx_update_filtering() apply the value of wvif->filter_mcast
to the hardware. But an attentive reader will note that
wfx_update_filtering() is always called after set wvif->filter_mcast.
Thus, it not necessary to store filter_mcast in the struct wfx_vif. We
can ju
From: Jérôme Pouiller
It is not very clear why driver ask to firmware to stop filtering probe
request during scan. It is particularly weird because scan is not
supported in AP mode. In add, it does not restore previous filtering
state after scanning.
It seems to be a mistake and should be droppe
From: Jérôme Pouiller
Firmware is able to detect detect changes about ERP protection in
beacons and automatically enable/disable ERP protection. However, it not
bring performance improvements and we are more confident in the ERP
handling of mac80211. So, the patch disable this feature.
Signed-of
From: Jérôme Pouiller
Update the TODO list associated to the wfx driver with the last
progresses and last remarks made by reviewers.
The items about support for P2P and mesh have also been removed. Indeed,
it seems that the device does not fully support them.
Signed-off-by: Jérôme Pouiller
---
From: Jérôme Pouiller
hif_set_rx_filter() apply changes on filter_prbreq and filter_bssid to
the hardware. Each time filter_prbreq and filter_bssid are changed,
hif_set_rx_filter() is called.
Currently, on extra call to hif_set_rx_filter() is made from
wfx_update_filtering(). This call is useles
From: Jérôme Pouiller
The frame filtering is more complex than necessary. This series simplify
the whole process and hopefully fixes some corner cases.
Jérôme Pouiller (20):
staging: wfx: update filtering even if not connected
staging: wfx: simplify wfx_update_filtering()
staging: wfx: re
From: Jérôme Pouiller
The only reason we ask to mac80211 to wait for a dtim before to
associate is to get an accurate DTIM value. However, we can temporary
set the dtim period to 1. Then we can waiting for
BSS_CHANGED_BEACON_INFO for the real value. Thus, the association
process is faster.
Signe
From: Jérôme Pouiller
mac80211 explicitly call wfx_configure_filters() before/after starting
AP. Thus, it is not necessary to call wfx_update_filtering() from
wfx_start_ap().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
From: Jérôme Pouiller
Device is able to automatically reply to probe request (therefore, the
probe requests are not forwarded to host). This feature is enabled by
wfx_start_ap(). However, further calls to wfx_configure_filter() can
disable it.
So, relocate the handling of probe request filtering
From: Jérôme Pouiller
The struct wfx_grp_addr_table is only instantiated on one place. There
is no justifiation for this struct. Moreover, it is not consistent with
other fields related to filtering (filter_bssid, etc...).
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 28 +
From: Jérôme Pouiller
Currently, wfx_update_filtering() is sometime called only to apply the
value of wvif->filter_beacon to the hardware. It is nicer to have a
specific function for beacon filtering.
In add, an attentive reader would note that wfx_update_filtering() is
always called after chang
From: Jérôme Pouiller
Since we had simplified the join process, update_filtering_work is no
more used. Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 10 --
drivers/staging/wfx/sta.h | 1 -
drivers/staging/wfx/wfx.h | 1 -
3 files changed, 12 deletions(-)
di
From: Jérôme Pouiller
Inline wfx_set_mcast_filter() into wfx_update_filtering() and remove
useless intermediate variables.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 69 ++-
1 file changed, 25 insertions(+), 44 deletions(-)
diff --git a/
From: Jérôme Pouiller
When the device joins an AP, beacon are forwarded to the host. Once has
retrieved all necessary parameters, we can start to filter the beacon
(and only beacon with changed/new data will be forwarded).
Currently, the driver detect beacons in data Rx process. It is far more
e
From: Jérôme Pouiller
Filters provided by HIF API are sometime inclusive, sometime exclusive.
This patch align the behavior and name of the beacon filter with the
other filters. Also avoid double negation: "disable filter"
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 10
From: Jérôme Pouiller
wfx_configure_filter() lacks of coherency. In add, some corner cases
seems to not been handled properly. Rework the whole function().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 41 +--
1 file changed, 35 insertions(+
From: Jérôme Pouiller
Currently, filtering are not update if the device is not connected.
There is no obvious rationale for that. Updating filtering while it is
not necessary is harmless. On the other hand, it is difficult to ensure
that the filtering rule has been correctly sent to the firmware.
On Tuesday 14 April 2020 12:13:15 CEST Greg Kroah-Hartman wrote:
> On Tue, Apr 14, 2020 at 05:55:15PM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > staging-next
> > head: ce920326663b3df22c94ade99a8b234baa6ccaa5
> > commit: ce9
On 4/14/20 6:13 PM, Greg Kroah-Hartman wrote:
On Tue, Apr 14, 2020 at 05:55:15PM +0800, kbuild test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
head: ce920326663b3df22c94ade99a8b234baa6ccaa5
commit: ce920326663b3df22c94ade99a8b234baa
25 matches
Mail list logo
