[PATCH] staging: vt6656: Fix pairwise key entry save.

2020-04-18 Thread Malcolm Priestley
The problem is that the group key was saved as VNT_KEY_DEFAULTKEY was over written by the VNT_KEY_GROUP_ADDRESS index. mac80211 could not clear the mac_addr in the default key. The VNT_KEY_DEFAULTKEY is not necesscary so remove it and set as VNT_KEY_GROUP_ADDRESS. mac80211 can clear any key

Re: [PATCH 2/2] staging: vt6656: Fix functions' documentation

2020-04-18 Thread Malcolm Priestley
Actually I don't really think the function descriptions are needed at all the names of the functions are enough. card.c needs to be removed the bss callers to baseband.c, the tbtt's to power.c and the rest to mac.c Regards Malcolm ___ devel mailing

Re: [PATCH ] staging: vt6656: Fix calling conditions of vnt_set_bss_mode

2020-04-18 Thread Malcolm Priestley
Sorry this was sent twice gmail reported the first one failed. Regards Maloclm ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH ] staging: vt6656: Fix calling conditions of vnt_set_bss_mode

2020-04-18 Thread Malcolm Priestley
vnt_set_bss_mode needs to be called on all changes to BSS_CHANGED_BASIC_RATES, BSS_CHANGED_ERP_PREAMBLE and BSS_CHANGED_ERP_SLOT Remove all other calls and vnt_update_ifs which is called in vnt_set_bss_mode. Fixes an issue that preamble mode is not being updated correctly. Fixes: c12603576e06

[PATCH ] staging: vt6656: Fix calling conditions of vnt_set_bss_mode

2020-04-18 Thread Malcolm Priestley
vnt_set_bss_mode needs to be called on all changes to BSS_CHANGED_BASIC_RATES, BSS_CHANGED_ERP_PREAMBLE and BSS_CHANGED_ERP_SLOT Remove all other calls and vnt_update_ifs which is called in vnt_set_bss_mode. Fixes an issue that preamble mode is not being updated correctly. Fixes: c12603576e06

[PATCH] staging: vt6656: Fix drivers TBTT timing counter.

2020-04-18 Thread Malcolm Priestley
The drivers TBTT counter is not synchronized with mac80211 timestamp. Reorder the functions and use vnt_update_next_tbtt to do the final synchronize. Fixes: c15158797df6 ("staging: vt6656: implement TSF counter") Cc: stable Signed-off-by: Malcolm Priestley ---

[PATCH] staging: vt6656: Don't set RCR_MULTICAST or RCR_BROADCAST by default.

2020-04-18 Thread Malcolm Priestley
mac80211/users control whether multicast is on or off don't enable it by default. Fixes an issue when multicast/broadcast is always on allowing other beacons through in power save. Fixes: db8f37fa3355 ("staging: vt6656: mac80211 conversion: main_usb add functions...") Cc: stable

[PATCH] staging: vt6656: Refactor the vnt_ofdm_min_rate function

2020-04-18 Thread Oscar Carter
Replace the for loop by a ternary operator whose condition is an AND bitmask against the priv->basic_rates variable. The purpose of the for loop was to check if any of bits from RATE_54M to RATE_6M was set, but it's not necessary to check every individual bit. The same result can be achieved

[PATCH 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-18 Thread Oscar Carter
Check the return value of vnt_control_out_* function calls. When necessary modify the function prototype to be able to return the new checked error code. It's safe to modify all the function prototypes without fix the call because the only change is the return value from void to int. If before

[PATCH 2/2] staging: vt6656: Fix functions' documentation

2020-04-18 Thread Oscar Carter
Replace the functions' documentation by the kernel-doc style fixing the parameters and return value. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/card.c | 101 +++-- drivers/staging/vt6656/mac.c | 67 --

[PATCH 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls

2020-04-18 Thread Oscar Carter
This patch series checks the return value of vnt_control_out_* function calls. The first patch checks the return value and when necessary modify the function prototype to be able to return the new checked error code. The second patch replaces the documentation of functions that their prototype

[PATCH] staging:r8188eu: avoid skb_clone for amsdu to msdu conversion

2020-04-18 Thread Ivan Safonov
skb clones use same data buffer, so tail of one skb is corrupted by beginning of next skb. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git