On Tue, Apr 28, 2020 at 09:31:10PM -0700, Joe Perches wrote:
> On Wed, 2020-04-29 at 00:04 -0400, Rylan Dmello wrote:
> > Fix checkpatch.pl warnings:
> >
> > WARNING: Avoid multiple line dereference - prefer 'qdev->func'
> > WARNING: Avoid multiple line dereference - prefer 'qdev->flags'
>
>
r entry in MAINTAINERS now.
Signed-off-by: Lukas Bulwahn
---
Greg, here is a minor non-urgent patch for staging.
applies cleanly on v5.7-rc3, current master and next-20200428
MAINTAINERS | 5 -
1 file changed, 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 26f281d9f32a..41e2b5774
Fix checkpatch.pl warnings:
WARNING: Avoid multiple line dereference - prefer 'qdev->func'
WARNING: Avoid multiple line dereference - prefer 'qdev->flags'
Signed-off-by: Rylan Dmello
---
drivers/staging/qlge/qlge_main.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --
Fix checkpatch.pl warning:
WARNING: suspect code indent for conditional statements (16, 23)
Signed-off-by: Rylan Dmello
---
drivers/staging/qlge/qlge_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.
Fix checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Rylan Dmello
---
drivers/staging/qlge/qlge_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 0edeea525f
amigaone_defconfig
powerpc ep8248e_defconfig
powerpc g5_defconfig
powerpc mpc512x_defconfig
powerpc chrp32_defconfig
powerpc holly_defconfig
parisc randconfig-a001-20200428
m68k
On Mon, Apr 27, 2020 at 2:18 PM Xin Ji wrote:
>
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K.
>
> The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI
> to DP feature. This driver only ena
allyesconfig
parisc allmodconfig
parisc randconfig-a001-20200428
m68k randconfig-a001-20200428
alpharandconfig-a001-20200428
nds32randconfig-a001-20200428
riscvrandconfig-a001-20200428
nios2
Hi Greg,
Thanks for the cleanup.
On Tue, Apr 28, 2020 at 07:04:05PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc:
-32bit_defconfig
parisc allyesconfig
parisc allmodconfig
parisc randconfig-a001-20200428
m68k randconfig-a001-20200428
alpharandconfig-a001-20200428
nds32randconfig-a001-20200428
riscv
On Mon, Apr 27, 2020 at 05:28:27PM +0530, Suraj Upadhyay wrote:
> On Mon, Apr 27, 2020 at 11:50:23AM +, Jerome Pouiller wrote:
> > On Saturday 25 April 2020 13:32:34 CEST Suraj Upadhyay wrote:
> > > Break lines with length over 80 characters to
> > > conform to the linux coding style and refact
On Mon, Apr 27, 2020 at 11:50:23AM +, Jerome Pouiller wrote:
> On Saturday 25 April 2020 13:32:34 CEST Suraj Upadhyay wrote:
> > Break lines with length over 80 characters to
> > conform to the linux coding style and refactor
> > wherever necessary.
> >
> > Signed-off-by: Suraj Upadhyay
> > -
On Mon, Apr 27, 2020 at 02:36:25PM +0200, Oliver Graute wrote:
> On 27/04/20, Dan Carpenter wrote:
> > On Mon, Apr 27, 2020 at 10:36:42AM +0200, Oliver Graute wrote:
> > > On 09/04/20, Dan Carpenter wrote:
> > > > On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote:
> > > > > From: Oliver
On Mon, Apr 27, 2020 at 10:29:39AM +0200, Oliver Graute wrote:
> On 09/04/20, Dan Carpenter wrote:
> > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote:
> > > From: Oliver Graute
> > >
> > > Enable inversion mode
> >
> > What the heck is an inversion mode and why would you want it?
Correct spelling in comment
Signed-off-by: John Oldman
---
drivers/staging/media/usbvision/usbvision-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/usbvision/usbvision-core.c
b/drivers/staging/media/usbvision/usbvision-core.c
index f05a5c84dc18.
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Rui Miguel Silva
Cc: Steve Longerbeam
Cc: Philipp Zabel
Cc: Mauro Carvalho Chehab
Cc: Greg Kroah-Hartman
Cc
On Tue, Apr 28, 2020 at 03:47:42PM +, Stahl, Manuel wrote:
> >
> > > + return err;
> > > + }
> > > + pci_set_master(pdev);
> > > +
> > > + dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq);
> >
> > Again, remove, be quiet :)
>
> Use dev_dbg() or remove completely?
If it helps in deb
On Di, 2020-04-28 at 15:54 +0200, greg k-h wrote:
> On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote:
> > This device combines the uio_pci_generic driver and the uio_dmem_genirq
> > driver since PCI uses a slightly different API for interrupts.
> > A fixed number of DMA capable memory r
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
debugfs_cleanup
head: 44bb83b556b01215b8d22a1f5a6f2dff0a394ad3
commit: 44bb83b556b01215b8d22a1f5a6f2dff0a394ad3 [1/1] drm: make .debugfs_init
and drm_debugfs_create_files() return void
config: x86_64-defconfig (attac
Fix to return negative error code -ENOMEM from cdev alloc failed error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/staging/pi433/pi433_if.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/st
On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote:
> This device combines the uio_pci_generic driver and the uio_dmem_genirq
> driver since PCI uses a slightly different API for interrupts.
> A fixed number of DMA capable memory regions can be defined using the
> module parameter "dmem_s
On Tue, Apr 28, 2020 at 02:21:25PM +0100, John Oldman wrote:
> I was not so happy about this one, even though I went and committed it.
>
> Without the blank line checkpatch reports:
>
> WARNING: Missing a blank line after declarations
> #160: FILE: drivers/staging/mt7621-dma/mtk-hsdma.c:160:
> +
(this time sent as plain text)
I was not so happy about this one, even though I went and committed it.
Without the blank line checkpatch reports:
WARNING: Missing a blank line after declarations
#160: FILE: drivers/staging/mt7621-dma/mtk-hsdma.c:160:
+ struct tasklet_struct task;
+ volatile unsi
Now that rtw_spt_band_free() is only a direct wrapper of kfree, we can
remove it and just use kfree().
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_c
在 2020/4/28 20:28, Greg KH 写道:
On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote:
And also remove the NULL check before kfree() because kfree() can handle
NULL pointers correctly.
Fix the following gcc warning:
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning:
variabl
On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote:
> And also remove the NULL check before kfree() because kfree() can handle
> NULL pointers correctly.
>
> Fix the following gcc warning:
>
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning:
> variable ‘size’ set but not u
On Mon, Apr 27, 2020 at 11:23:36AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2564:22: warning:
> variable ‘uintRet’ set but not used [-Wunused-but-set-variable]
> unsigned int uintRet = 0;
> ^~~
>
On Mon, Apr 27, 2020 at 12:15:18AM -0400, Rylan Dmello wrote:
> Remove debug print statements referring to non-existent fields
> 'lbq_clean_idx' and 'lbq_free_cnt' in the 'rx_ring' struct, which causes
> a compilation failure when QL_DEV_DUMP is set.
>
> These fields were initially removed as a pa
On Mon, Apr 27, 2020 at 12:14:11AM -0400, Rylan Dmello wrote:
> Remove unnecessary parentheses around a struct field accessor that
> causes a build failure when QL_DEV_DUMP is set.
>
> Signed-off-by: Rylan Dmello
Add a Fixes tag.
Fixes: 67e6cf7338e1 ("staging: qlge: add braces around macro argu
On Mon, Apr 27, 2020 at 12:14:44AM -0400, Rylan Dmello wrote:
> Remove statement that tries to print the non-existent 'vlgrp' field
> in the 'ql_adapter' struct, which causes a compilation failure when
> QL_DEV_DUMP is set.
>
> vlgrp seems to have been removed from ql_adapter as a part of
> commit
On Tue, Apr 28, 2020 at 11:28:04AM +0100, John Oldman wrote:
> Coding style issues
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kep
Coding style issues
Signed-off-by: John Oldman
---
v1: Initial attempt
v2: Do more blocks
v3: Single patch
drivers/staging/rts5208/rtsx.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
i
On Fri, Apr 24, 2020 at 08:12:04PM +0800, Nicolas Boichat wrote:
> On Fri, Apr 24, 2020 at 2:51 PM Xin Ji wrote:
> >
> > On Thu, Apr 23, 2020 at 07:55:15PM +0800, Nicolas Boichat wrote:
> > > Hi,
> > >
> > > Just commenting on the mode_fixup function that was added in v7.
> > >
> > [snip]
> > > >
On 28/04/20 1:44 pm, Johannes Berg wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> From: Johannes Berg
>
> Adjust to the API changes in cfg80211 for management frame registration.
>
> Fixes: 6cd536fe62ef ("cfg80211: change internal ma
This change cleans up the driver's probe function to use only devm_
function variants. This also gets rid of the remove function and moves the
clock & regulator de-initializations to the 'ad5933_cleanup()' callback.
Signed-off-by: Alexandru Ardelean
---
.../staging/iio/impedance-analyzer/ad5933.
On Tue, Apr 28, 2020 at 10:14:03AM +0200, Johannes Berg wrote:
> From: Johannes Berg
>
> Adjust to the API changes in cfg80211 for management frame registration.
>
> Fixes: 6cd536fe62ef ("cfg80211: change internal management frame registration
> API")
> Signed-off-by: Johannes Berg
Acked-by:
On Tue, Apr 28, 2020 at 10:14:02AM +0200, Johannes Berg wrote:
> From: Johannes Berg
>
> This was changed in cfg80211, so having it broke things, but
> there's no need to adjust since it's an empty implementation.
> Just remove it.
>
> Fixes: 6cd536fe62ef ("cfg80211: change internal management f
On Tue, Apr 28, 2020 at 10:16:57AM +0200, Johannes Berg wrote:
> Greg,
>
> I'm going to take these through my tree because I broke the APIs there
> (and wasn't paying attention to staging), but every bot around the world
> is complaining now that my tree doesn't build ... :)
No objection from me!
> From: Johannes Berg
>
> Adjust to the API changes in cfg80211 for management frame registration.
>
> Fixes: 6cd536fe62ef ("cfg80211: change internal management frame registration
> API")
> Signed-off-by: Johannes Berg
> ---
> drivers/staging/wilc1000/cfg80211.c | 36 ++--
Greg,
I'm going to take these through my tree because I broke the APIs there
(and wasn't paying attention to staging), but every bot around the world
is complaining now that my tree doesn't build ... :)
johannes
___
devel mailing list
de...@linuxdriver
From: Johannes Berg
This was changed in cfg80211, so having it broke things, but
there's no need to adjust since it's an empty implementation.
Just remove it.
Fixes: 6cd536fe62ef ("cfg80211: change internal management frame registration
API")
Signed-off-by: Johannes Berg
---
.../staging/rtl87
From: Johannes Berg
Adjust to the API changes in cfg80211 for management frame registration.
Fixes: 6cd536fe62ef ("cfg80211: change internal management frame registration
API")
Signed-off-by: Johannes Berg
---
drivers/staging/wilc1000/cfg80211.c | 36 ++---
drivers/sta
On Monday 27 April 2020 11:49:13 Sasha Levin wrote:
> On Tue, Apr 21, 2020 at 11:30:45PM +0200, Pali Rohár wrote:
> > On Thursday 13 February 2020 16:18:47 Sasha Levin wrote:
> > > On Thu, Feb 13, 2020 at 01:06:56AM +0100, Pali Rohár wrote:
> > > > In released exFAT specification is not written how
43 matches
Mail list logo
