Re: [PATCH v8 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-29 Thread Xin Ji
On Wed, Apr 29, 2020 at 10:10:05AM +0800, Nicolas Boichat wrote: > On Mon, Apr 27, 2020 at 2:18 PM Xin Ji wrote: > > > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > > > The ANX7625 can support both

Re: [PATCH v8 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-29 Thread Xin Ji
Hi Sam, On Mon, Apr 27, 2020 at 10:00:44PM +0200, Sam Ravnborg wrote: > Hi Xin Ji > > On Mon, Apr 27, 2020 at 02:18:44PM +0800, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > > > T

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-29 Thread Xin Ji
On Tue, Apr 28, 2020 at 12:05:08PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 08:12:04PM +0800, Nicolas Boichat wrote: > > On Fri, Apr 24, 2020 at 2:51 PM Xin Ji wrote: > > > > > > On Thu, Apr 23, 2020 at 07:55:15PM +0800, Nicolas Boichat wrote: > > > > Hi, > > > > > > > > Just commenti

[driver-core:driver-core-linus] BUILD SUCCESS 2a15483b401c0b07e44b43b95414e36f32c02f32

2020-04-29 Thread kbuild test robot
ig powerpc ep8248e_defconfig powerpc g5_defconfig powerpc mpc512x_defconfig parisc randconfig-a001-20200429 m68k randconfig-a001-20200429 alpharandconfig-a001-20200429 mips randc

Re: [PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c

2020-04-29 Thread Joe Perches
On Wed, 2020-04-29 at 21:31 -0400, Rylan Dmello wrote: > This patchset fixes some indentation- and style-related issues in qlge_main.c > reported by checkpatch.pl, such as: > > WARNING: Avoid multiple line dereference > WARNING: line over 80 characters > WARNING: suspect code indent for cond

[PATCH v2 7/7] staging: qlge: Fix function argument alignment warning in ql_init_device

2020-04-29 Thread Rylan Dmello
Fix checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index fa708c72

[PATCH v2 6/7] staging: qlge: Fix suspect code indent warning in ql_init_device

2020-04-29 Thread Rylan Dmello
Fix checkpatch.pl warnings: WARNING: suspect code indent for conditional statements (16, 23) WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main

[PATCH v2 5/7] staging: qlge: Remove multi-line dereference from ql_request_irq

2020-04-29 Thread Rylan Dmello
Fix checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_ma

[PATCH v2 3/7] staging: qlge: Fix indentation in ql_get_mac_addr_reg

2020-04-29 Thread Rylan Dmello
This has similar indentation style issues as ql_set_mac_addr_reg, so I thought I'd re-indent this too. Fix several checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 76 1 file changed,

[PATCH v2 4/7] staging: qlge: Remove goto statements from ql_get_mac_addr_reg

2020-04-29 Thread Rylan Dmello
Similar to ql_set_mac_addr_reg, ql_get_mac_addr_reg also has several goto statements that can be trivially replaced with a break statement. Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/s

[PATCH v2 1/7] staging: qlge: Fix indentation in ql_set_mac_addr_reg

2020-04-29 Thread Rylan Dmello
Based on Joe Perches' feedback, fix the indentation throughout ql_set_mac_addr_reg. This helps fix several "line over 80 characters" warnings along with the original "multiple line dereference" warning. Fix checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'qdev->func'

[PATCH v2 2/7] staging: qlge: Remove gotos from ql_set_mac_addr_reg

2020-04-29 Thread Rylan Dmello
As suggested by Joe Perches, this patch removes the 'exit' label from the ql_set_mac_addr_reg function and replaces the goto statements with break statements. Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) d

[PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c

2020-04-29 Thread Rylan Dmello
This patchset fixes some indentation- and style-related issues in qlge_main.c reported by checkpatch.pl, such as: WARNING: Avoid multiple line dereference WARNING: line over 80 characters WARNING: suspect code indent for conditional statements v2: - Addressed feedback from Joe Perches by u

[driver-core:debugfs_cleanup] BUILD SUCCESS 4fd0626707deb3e0c37ecf41c743a091998f1ba1

2020-04-29 Thread kbuild test robot
amigaone_defconfig powerpcadder875_defconfig powerpc ep8248e_defconfig powerpc g5_defconfig powerpc mpc512x_defconfig parisc randconfig-a001-20200429 m68k randconfig-a001-20200429 alpha

PATCH] staging: vt6656: use struct wiphy retry short and long settings.

2020-04-29 Thread Malcolm Priestley
Remove driver options for short and long retry and use the ones set by user in wiphy. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/device.h | 3 --- drivers/staging/vt6656/main_usb.c | 8 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6

Re: [PATCH] staging: wfx: avoid compiler warning on empty array

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 6:04 PM Jerome Pouiller wrote: > On Wednesday 29 April 2020 16:21:09 CEST Arnd Bergmann wrote: > > > > -static const struct of_device_id wfx_sdio_of_match[]; > > +static const struct of_device_id wfx_sdio_of_match[] = { > > + { .compatible = "silabs,wfx-sdio" }, > > +

Re: [greybus-dev] [PATCH] greybus: uart: fix uninitialized flow control variable

2020-04-29 Thread Alex Elder
On 4/29/20 2:00 PM, Arnd Bergmann wrote: > gcc-10 points out an uninitialized variable use: Wow, nice, checking individual uninitialized fields within the structure. The structure should really be zero-initialized anyway; it's passed as a structure in a message elsewhere. With your change, all f

[PATCH] greybus: uart: fix uninitialized flow control variable

2020-04-29 Thread Arnd Bergmann
gcc-10 points out an uninitialized variable use: drivers/staging/greybus/uart.c: In function 'gb_tty_set_termios': drivers/staging/greybus/uart.c:540:24: error: 'newline.flow_control' is used uninitialized in this function [-Werror=uninitialized] 540 | newline.flow_control |= GB_SERIAL_AUTO_R

[PATCH 3/3] staging: vt6656: return all key calls to mac80211 stack.

2020-04-29 Thread Malcolm Priestley
vnt_mac_set_keyentry can return USB calls so return them to mac80211. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/key.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/vt6656/key.c index de54

[PATCH 2/3] staging: vt6656 remove vnt_mac_disable_keyentry calls

2020-04-29 Thread Malcolm Priestley
It is not necessary to disable all the keys mac80211 will have removed any existing keys that were used. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/key.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/

Re: [PATCH 1/3] staging: qlge: Remove multi-line dereferences from qlge_main.c

2020-04-29 Thread Joe Perches
On Wed, 2020-04-29 at 00:04 -0400, Rylan Dmello wrote: > Fix checkpatch.pl warnings: > > WARNING: Avoid multiple line dereference - prefer 'qdev->func' > WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Assuming you are doing this for exercise: It'd be better to unindent all t

[PATCH 1/3] staging: vt6656: vnt_set_keymode simplify key modes.

2020-04-29 Thread Malcolm Priestley
Unused macros and onfly_latch are removed and others contain to actual key_type value is or-ed with key_mode. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/key.c | 25 + drivers/staging/vt6656/key.h | 13 +++-- 2 files changed, 16 insertions(+), 22 d

[staging:staging-linus] BUILD SUCCESS 0c1d3f2c9a0dc49d96754148b74a44eaa37bfbd8

2020-04-29 Thread kbuild test robot
amigaone_defconfig powerpcadder875_defconfig powerpc ep8248e_defconfig powerpc g5_defconfig powerpc mpc512x_defconfig parisc randconfig-a001-20200429 m68k randconfig-a001

Re: [PATCH] staging: wfx: avoid compiler warning on empty array

2020-04-29 Thread Jerome Pouiller
On Wednesday 29 April 2020 16:21:09 CEST Arnd Bergmann wrote: > > When CONFIG_OF is disabled, gcc-9 produces a warning about the > wfx_sdio_of_match[] array having a declaration without a dimension: > > drivers/staging/wfx/bus_sdio.c:159:34: error: array 'wfx_sdio_of_match' > assumed to have one

[PATCH] staging: vt6656: Refactor the vnt_rf_table_download function

2020-04-29 Thread Oscar Carter
Create a constant array of struct vnt_table_info type elements with the necessary info (address and length) about all the rf tables for every rf type. In every case of the "switch" statement replace the hardcoded info about these tables with and index to the new constant array. Moreover, use this

[PATCH 1/2] staging: vt6656: Check the return values in vnt_set_bss_mode function

2020-04-29 Thread Oscar Carter
Check the return value of all the functions that return zero if successful or a negative error code on failure inside the function vnt_set_bss_mode. Also, remove the unnecessary variable initialization as this variable is set a few lines later. Signed-off-by: Oscar Carter --- drivers/staging/vt

[PATCH 0/2] staging: vt6656: Refactor the vnt_set_bss_mode function

2020-04-29 Thread Oscar Carter
This patch series refactors the vnt_set_bss_mode function through two patches. The first one checks the return value of all the functions that return zero if successful or a negative error code on failure. The second patch removes all the duplicate code in the "if, else if, else" statements as al

[PATCH 2/2] staging: vt6656: Refactor the vnt_set_bss_mode function

2020-04-29 Thread Oscar Carter
Remove all the duplicate code in the "if, else if, else" statements as all the branches in every "if" are almost the same. The only difference between branches is some value. So, use variables instead of repeat code. Also, remove the unnecessary casting to u8 type because the "priv->bb_type" varia

[PATCH] staging: wfx: avoid compiler warning on empty array

2020-04-29 Thread Arnd Bergmann
When CONFIG_OF is disabled, gcc-9 produces a warning about the wfx_sdio_of_match[] array having a declaration without a dimension: drivers/staging/wfx/bus_sdio.c:159:34: error: array 'wfx_sdio_of_match' assumed to have one element [-Werror] 159 | static const struct of_device_id wfx_sdio_of_mat

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread Stahl, Manuel
On Mi, 2020-04-29 at 11:41 +0200, gre...@linuxfoundation.org wrote: > On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > > > + * >

Re: WARNING in exfat_bdev_read

2020-04-29 Thread syzbot
syzbot suspects this bug was fixed by commit: commit 5f33771fb0ac484d6e8cc34cb1e27c37442cd0db Author: Namjae Jeon Date: Fri Jan 3 01:13:45 2020 + staging: exfat: add STAGING prefix to config names bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1407f81810 start commit

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > + * > > > + * Since the driver does not declare any device ids, you must allocate >

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread Stahl, Manuel
On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > + * > > + * Since the driver does not declare any device ids, you must allocate > > + * id and bind the device to the driver yourself. For example: > > +

[PATCH] staging: iio: ad2s1210: Fix SPI reading

2020-04-29 Thread Alexandru Ardelean
From: Dragos Bogdan If the serial interface is used, the 8-bit address should be latched using the rising edge of the WR/FSYNC signal. This basically means that a CS change is required between the first byte sent, and the second one. This change splits the single-transfer transfer of 2 bytes int

[driver-core:driver-core-testing] BUILD SUCCESS 48ebea5026d692c5ab0a7d303f0fe1f8ba046e0f

2020-04-29 Thread kbuild test robot
nds32randconfig-a001-20200428 riscvrandconfig-a001-20200428 parisc randconfig-a001-20200429 m68k randconfig-a001-20200429 alpharandconfig-a001-20200429 mips randconfig-a001-20200429 nds32