[PATCH] staging: vt6656: Use const for read only data

2020-05-04 Thread Oscar Carter
Use const for the arrays that are used as "read only". Also, modify the prototype of vnt_control_out_blocks() function to use a pointer to a const type. The vnt_vt3184_al2230 array can't be converted to const as it's modified later. Then in the vnt_vt3184_init() function use two types of pointers

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Christian.Gromm
On Mon, 2020-05-04 at 17:39 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, May 04, 2020 at 03:17:53PM +, > christian.gr...@microchip.com wrote: > > On Mon, 2020-05-04 at 15:54 +0200, Greg KH wrote: > > > EXTERNA

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Greg KH
On Mon, May 04, 2020 at 03:17:53PM +, christian.gr...@microchip.com wrote: > On Mon, 2020-05-04 at 15:54 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wr

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Greg KH
On Mon, May 04, 2020 at 03:22:08PM +, christian.gr...@microchip.com wrote: > On Mon, 2020-05-04 at 15:55 +0200, Greg KH wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wr

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Christian.Gromm
On Mon, 2020-05-04 at 15:55 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wrote: > > This patch fixes error handling on function parameters. > > > > Signed-off-by:

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Christian.Gromm
On Mon, 2020-05-04 at 15:54 +0200, Greg KH wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wrote: > > This patch fixes error handling on function parameters. > > What does that mean

[PATCH v3] staging: wilc1000: Increase the size of wid_list array

2020-05-04 Thread Oscar Carter
Increase by one the size of wid_list array as index variable can reach a value of 5. If this happens, an out-of-bounds access is performed. Also, use a #define instead of a hard-coded literal for the new array size. Addresses-Coverity-ID: 1451981 ("Out-of-bounds access") Fixes: f5a3cb90b802d ("st

Re: [PATCH v2] staging: wilc1000: Increase the size of wid_list array

2020-05-04 Thread Oscar Carter
On Sun, May 03, 2020 at 04:29:53PM -0700, Joe Perches wrote: > On Sun, 2020-05-03 at 14:52 +, ajay.kat...@microchip.com wrote: > > On 03/05/20 1:21 pm, Oscar Carter wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > Increas

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Greg KH
On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wrote: > This patch fixes error handling on function parameters. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/usb/usb.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > di

Re: [PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Greg KH
On Mon, May 04, 2020 at 03:44:00PM +0200, Christian Gromm wrote: > This patch fixes error handling on function parameters. What does that mean? If I don't understand it, I think it needs to be made a lot more explicit as to why you are making these changes :) > Signed-off-by: Christian Gromm

[PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Christian Gromm
This patch fixes error handling on function parameters. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index

[PATCH v2 21/21] staging: ion: fix sg_table nents vs. orig_nents misuse

2020-05-04 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that dma_map_sg returns the numer of the created entries in the DMA address space. However the subsequent calls to dma_sync_sg_for_{device,cpu} and dma_unmap_sg must be called with the original number of entries passed to dma_map_sg. The sg_table->nents in

[PATCH] staging: rtl8723bs: remove conversion to bool in halbtcoutsrc_Get()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/staging/rtl8723bs/hal/hal_btcoex.c:410:59-64: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

Confirm your donation

2020-05-04 Thread Bill & Melinda
Attn: Email user, We are pleased to announce that your "E address" was nominated as one of the 28 recipients under the Second category in the online DONATION SWEEPSTAKE 2020 Prospect as part of the Bill & Melinda Gates Foundation to relief Humanitarian struggle. For claims and clearance, kindl

Confirm your donation

2020-05-04 Thread Bill & Melinda
Attn: Email user, We are pleased to announce that your "E address" was nominated as one of the 28 recipients under the Second category in the online DONATION SWEEPSTAKE 2020 Prospect as part of the Bill & Melinda Gates Foundation to relief Humanitarian struggle. For claims and clearance, kindl