Re: [PATCH] staging: vc04_services: vchiq_arm: replace bitshift with BIT macro

2020-06-19 Thread Dan Carpenter
On Thu, Jun 18, 2020 at 06:02:59PM +0200, Garrit Franke wrote: > This should prevent possible overflowing bits by using the BIT macro in > vchiq_core There is no reason to think that these will overflow. For that to happen we would need to be using a 64bit with a 1 << 31 shift.

Re: [PATCH] staging: gasket: replace symbolic permissions

2020-06-19 Thread Rodolfo C Villordo
On Thu, Jun 18, 2020 at 09:47:50AM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 01, 2020 at 12:52:40AM +, Rodolfo C. Villordo wrote: > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal permissions '0444'. > > + .attr = __ATTR(_name, S_IRUGO,

Re: [PATCH] staging: gasket: replace symbolic permissions

2020-06-19 Thread Greg Kroah-Hartman
On Fri, Jun 19, 2020 at 08:27:14AM +, Rodolfo C Villordo wrote: > On Thu, Jun 18, 2020 at 09:47:50AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 01, 2020 at 12:52:40AM +, Rodolfo C. Villordo wrote: > > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > > o

Re: [PATCH v5 6/9] media: adv748x: prepare/enable mclk when the audio is used

2020-06-19 Thread Alex Riesen
Kieran Bingham, Thu, Jun 18, 2020 18:23:14 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > --- a/drivers/media/i2c/adv748x/adv748x-dai.c > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > > @@ -117,11 +117,22 @@ static int adv748x_dai_set_fmt(struct snd_soc_dai > > *dai, unsigned int fmt) >

Re: [PATCH v5 7/9] media: adv748x: only activate DAI if it is described in device tree

2020-06-19 Thread Alex Riesen
Kieran Bingham, Thu, Jun 18, 2020 18:17:04 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > To avoid setting it up even if the hardware is not actually connected > > to anything physically. > > > > Besides, the bindings explicitly notes that port definitions are > > "optional if they are not c

Re: [PATCH v5 9/9] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC

2020-06-19 Thread Alex Riesen
Kieran Bingham, Thu, Jun 18, 2020 18:32:55 +0200: > On 02/04/2020 19:35, Alex Riesen wrote: > > --- a/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77950-salvator-x.dts > > @@ -146,7 +146,8 @@ &sata { > > &sound_card { > > dais = <&rsnd_port0

[PATCH v7 31/36] staging: tegra-vde: fix common struct sg_table related issues

2020-06-19 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the dma_

[PATCH v7 30/36] staging: ion: fix common struct sg_table related issues

2020-06-19 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the dma_

[PATCH v7 29/36] staging: ion: remove dead code

2020-06-19 Thread Marek Szyprowski
ion_heap_pages_zero() function is not used at all, so remove it to simplify the ion_heap_sglist_zero() function later. Signed-off-by: Marek Szyprowski --- drivers/staging/android/ion/ion.h | 1 - drivers/staging/android/ion/ion_heap.c | 9 - 2 files changed, 10 deletions(-) diff --

[PATCH v3 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs

2020-06-19 Thread Vaibhav Agarwal
snd_soc_jack APIs are modified in recent kernel versions. This patch updates the codec driver to resolve the compilation errors related to jack framework. Signed-off-by: Vaibhav Agarwal Reviewed-by: Dan Carpenter --- drivers/staging/greybus/audio_codec.c | 54 +-- 1 file

[PATCH v3 0/6] Enable Greybus Audio codec driver

2020-06-19 Thread Vaibhav Agarwal
The existing GB Audio codec driver is dependent on MSM8994 Audio driver. During the development stage, this dependency was configured due to various changes involved in MSM Audio driver to enable addtional codec card and some of the changes proposed in mainline ASoC framework. However, these are no

[PATCH v3 4/6] staging: greybus: audio: Resolve compilation error in topology parser

2020-06-19 Thread Vaibhav Agarwal
Fix compilation errors for GB Audio topology parser code with recent kernel versions. Signed-off-by: Vaibhav Agarwal Reviewed-by: Dan Carpenter --- drivers/staging/greybus/audio_topology.c | 123 +++ 1 file changed, 57 insertions(+), 66 deletions(-) diff --git a/drivers/sta

[PATCH v3 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

2020-06-19 Thread Vaibhav Agarwal
Currently you can't enable the Gey Bus Audio Codec because there is no entry for it in the Kconfig file. Originally the config name was going to be AUDIO_MSM8994 but that's not correct because other types of hardware are supported now. I have chosen the name AUDIO_APB_CODEC instead. Also I had to

[PATCH v3 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules

2020-06-19 Thread Vaibhav Agarwal
Greybus Codec driver allows modules to be dynamically added and removed, which further requires updating the DAPM configurations as well. With current snd_soc architecture, dynamic audio modules is not yet supported. This patch provides helper APIs to update DAPM configurations in response to modu

[PATCH v3 2/6] staging: greybus: audio: Maintain jack list within GB Audio module

2020-06-19 Thread Vaibhav Agarwal
As per the current implementation for GB codec driver, a jack list is maintained for each module. And it expects the list to be populated by the snd_soc_jack structure which would require modifications in mainstream code. However, this is not a necessary requirement and the list can be easily main

[PATCH v3 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module

2020-06-19 Thread Vaibhav Agarwal
Due to dependencies on ASoC framework changes, GB dummy codec module compilation is currently disabled. This patch updates codec driver as per the latest ASoC APIs. Signed-off-by: Vaibhav Agarwal Reviewed-by: Dan Carpenter --- drivers/staging/greybus/audio_codec.c | 88 +

[PATCH] media: allegro: Fix some NULL vs IS_ERR() checks in probe

2020-06-19 Thread Dan Carpenter
The devm_ioremap() function doesn't return error pointers, it returns NULL on error. Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") Signed-off-by: Dan Carpenter --- drivers/staging/media/allegro-dvt/allegro-core.c | 8 1 file changed, 4 insertions(+), 4 del

[bug report] staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list

2020-06-19 Thread Dan Carpenter
Hello Nicolas Saenz Julienne, The patch 46e4b9ec4fa4: "staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list" from Nov 20, 2018, leads to the following static checker warning: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:427 vchiq_blocking_bulk_tran

[PATCH] staging: rtl8188eu: use common packet header constants

2020-06-19 Thread Michael Straube
The driver replicates the definitions of rfc1042_header and bridge_tunnel_header available from cfg80211.h. Use the common ones from cfg80211.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_recv.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-)

Re: [PATCH v3 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

2020-06-19 Thread kernel test robot
Hi Vaibhav, I love your patch! Perhaps something to improve: [auto build test WARNING on 98fe05e21a6e0ca242e974650ed58b64813cb2dc] url: https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-Audio-codec-driver/20200619-192443 base