Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-29 Thread Benjamin Poirier
On 2020-06-30 01:43 +0800, Coiby Xu wrote: > On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote: > > On 2020-06-27 22:58 +0800, Coiby Xu wrote: > > [...] > > > void ql_dump_qdev(struct ql_adapter *qdev) > > > { > > > @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev

[PATCH] rtl8188eu: core: Fix WARNING of Block comments

2020-06-29 Thread Simon Fong
Fixed a WARNING of Block comments use * on subsequent lines. Signed-off-by: Simon Fong --- drivers/staging/rtl8188eu/core/rtw_recv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_re

Re: [kbuild-all] Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread Philip Li
> [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v5.8-rc3 next-20200629] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use as documented in > > https:/

Re: [PATCH v3] staging: wfx: Get descriptors for GPIOs

2020-06-29 Thread kernel test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/staging-wfx-Get-descriptors-for-GPIOs/20200628-165448 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.g

Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-29 Thread Coiby Xu
On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote: On 2020-06-27 22:58 +0800, Coiby Xu wrote: [...] void ql_dump_qdev(struct ql_adapter *qdev) { @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev) #ifdef QL_CB_DUMP void ql_dump_wqicb(struct wqicb *wqicb) { -

[PATCH v2] staging: rtl8188eu: Replace function name with __func__

2020-06-29 Thread Brooke Basile
Fix the following checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'rtw_get_bcn_info', this function's name, in a string Signed-off-by: Brooke Basile --- Changes in v2: - This should fix the previous issue that caused the patch to fail to apply.

[PATCH v2 2/4] staging/rtl8192e: use generic power management

2020-06-29 Thread Vaibhav Gupta
The structure of working of PM hooks for source files is: drivers/staging/rtl8192e/rtl8192e/rtl_pm.h : callbacks declared drivers/staging/rtl8192e/rtl8192e/rtl_pm.c : callbacks defined drivers/staging/rtl8192e/rtl8192e/rtl_core.c : callbacks used Drivers should not use legacy power

[PATCH v2 0/4] drivers/staging: use generic power management

2020-06-29 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from amd ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling t

[PATCH v2 3/4] rts5208/rtsx.c: use generic power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

[PATCH v2 1/4] qlge/qlge_main.c: use generic power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

[PATCH v2 4/4] vt6655/device_main.c: use generic power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread Bjorn Helgaas
Vaibhav: s/genric/generic/ in the subject On Tue, Jun 30, 2020 at 12:09:36AM +0800, kernel test robot wrote: > Hi Vaibhav, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v5.8-rc3 next-20

[PATCH 1/3] staging: rtl8188eu: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/wifi.h | 4

[PATCH 3/3] staging: rtl8712: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/wifi.h | 4 1 f

[PATCH 2/3] staging: rtl8723bs: remove some ieee80211 constants from wifi.h

2020-06-29 Thread Michael Straube
The constants IEEE80211_BAR_CTRL_ACK_POLICY_NORMAL and IEEE80211_BAR_CTRL_CBMTID_COMPRESSED_BA are not used in the driver code and, if ever needed, available from 'include/linux/ieee80211.h'. Remove them from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/include/wifi.h | 5

Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread Vaibhav Gupta
On Mon, 29 Jun 2020 at 21:39, kernel test robot wrote: > > Hi Vaibhav, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v5.8-rc3 next-20200629] > [If your patch is applied to the wro

Re: [PATCH 0/7] Some atomisp fixes and improvements

2020-06-29 Thread Andy Shevchenko
On Fri, Jun 26, 2020 at 05:52:16PM +0200, Mauro Carvalho Chehab wrote: > Em Fri, 26 Jun 2020 18:00:21 +0300 > Andy Shevchenko escreveu: > > > On Fri, Jun 26, 2020 at 04:04:52PM +0200, Mauro Carvalho Chehab wrote: > > > Those patches are meant to improve device detection by the atomisp driver, > >

[PATCH 1/2] staging: rtl8188eu: use compound assignment operators

2020-06-29 Thread Michael Straube
Use compound assignment operators to simplify the code and clear missing spaces around operators checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/

[PATCH 2/2] staging: rtl8188eu: add spaces around operators

2020-06-29 Thread Michael Straube
Add spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 70 ++-- drivers/staging/rtl8188eu/core/rtw_security.c | 102 +++

Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread kernel test robot
Hi Vaibhav, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v5.8-rc3 next-20200629] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

Re: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

2020-06-29 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

[PATCH v2 44/47] staging: vchiq: Move conditional barrier definition into vchiq_core.h

2020-06-29 Thread Nicolas Saenz Julienne
The barrier is only used by core code. So keep the barrier definition in the core header. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq.h| 11 --- .../vc04_services/interface/vchiq_arm/vchiq_core.h | 12 2 files changed, 12 i

[PATCH v2 47/47] staging: vchiq: Move vchiq.h into include directory

2020-06-29 Thread Nicolas Saenz Julienne
To make the separation clear between vchiq's header files and vchiq.h, which is to be used by services and is the 'public' API, move it into a dedicated includes directory. Signed-off-by: Nicolas Saenz Julienne --- Changes since v1: - Remove unwarranted include drivers/staging/vc04_services/M

[PATCH v2 41/47] staging: vchi: Get rid of vchi_bulk_queue_transmit()

2020-06-29 Thread Nicolas Saenz Julienne
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We can then merge both functions by moving vchi_bulk_queue_transmit()'s retry mechanism into vchiq_bulk_transmit() and let services call the later. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c

[PATCH v2 46/47] staging: vchiq: Move defines into core header

2020-06-29 Thread Nicolas Saenz Julienne
Those are only used in the core vchiq code, while present in vchiq's 'public' API header. Move them into the right place. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 5 - .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h

[PATCH v2 43/47] staging: vchiq: Get rid of vchi

2020-06-29 Thread Nicolas Saenz Julienne
All the functions that vchi currently provides are a 1:1 mapping to its vchiq counterparts. Get rid of vchi altogether and use vchiq's on all services. In the process also get rid of the vchi directory, as the only remaining file was a TODO file, which now lives in the parent directory. Signed-of

[PATCH v2 42/47] staging: vchi: Move vchi_queue_kernel_message() into vchiq

2020-06-29 Thread Nicolas Saenz Julienne
We can't really merge it with vchiq_queue_message() as it has internal users that will not benefit from the retry mechanism vchiq_queue_kernel_message() uses. So, for the sake of getting rid of vchi, move it into vchiq. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c

[PATCH v2 40/47] staging: vchi: Get rid of vchi_bulk_queue_receive()

2020-06-29 Thread Nicolas Saenz Julienne
Its vchiq counterpart, vchiq_bulk_receive() is only used by vchi. We can then merge both functions by moving vchi_bulk_queue_receive()'s retry mechanism into vchiq_bulk_receive() and let services call the later. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h

[PATCH v2 45/47] staging: vchiq: Use vchiq.h as the main header file for services

2020-06-29 Thread Nicolas Saenz Julienne
This used to be vchiq_if.h but vchiq.h is more concise for an include file that will hopefully be in the future in the includes directory. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/bcm2835-audio/bcm2835.h | 2 +- .../vc04_services/interface/vchiq_arm/vchiq.h | 107 +++

[PATCH v2 32/47] staging: vchiq: Pass vchiq's message when holding a message

2020-06-29 Thread Nicolas Saenz Julienne
vchi created an opaque structure to be held by services while they process callback messages. The contents of this opaque structure are the service handle, which all services already maintain, and a pointer to vchiq's message structure, struct vchiq_header. Let's get rid of this opaque structure a

[PATCH v2 33/47] staging: vchi: Rework vchi_msg_hold() to match vchiq_msg_hold()

2020-06-29 Thread Nicolas Saenz Julienne
The services have access to struct vchiq_header's internals, so we can let them get the data pointer. This pretty much makes both functions exactly the same, which will allow us to make a switch to vchiq_msg_hold() further down the road. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04

[PATCH v2 35/47] staging: vchi: Get rid of struct vchiq_instance forward declaration

2020-06-29 Thread Nicolas Saenz Julienne
It's already forward declared in vchiq_if.h. So no need to insist Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchi/vchi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_se

[PATCH v2 38/47] staging: vchiq: Make vchiq_add_service() local

2020-06-29 Thread Nicolas Saenz Julienne
The function is being exported although there is no use for it outside of vchiq's core code. Keep it local then. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 3 ---

[PATCH v2 34/47] staging: vchiq: Unify fourcc definition mechanisms

2020-06-29 Thread Nicolas Saenz Julienne
There is already enough duplication with regard to fourcc generation in the kernel. Let's at least use the same macro all over the vchiq ecosystem. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- .../vc04_services/bcm2835-audio/vc_vc

[PATCH v2 30/47] staging: vchi: Use struct vchiq_service_params

2020-06-29 Thread Nicolas Saenz Julienne
For initialization, vchi has its own params structure, which is then translated to vchiq's params structure. They are essentially the same, so lets directly use vchiq's. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c | 9 + .../vc04_services/inte

[PATCH v2 21/47] staging: vchi: Get rid of effect less expression

2020-06-29 Thread Nicolas Saenz Julienne
It was probably there to trick compilers into ignoring unused variables, which isn't needed in Linux. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vc04_services/interf

[PATCH v2 18/47] staging: vchi: Get rid of flags argument in vchi_msg_hold()

2020-06-29 Thread Nicolas Saenz Julienne
All users are ignoring the flags argument. So for the sake of simplicity delete it. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +-- drivers/staging/vc04_services/interface/vchi/vchi.h | 1 - .../vc04_services/interface/vchiq_arm/vchiq_sh

[PATCH v2 27/47] staging: vchiq: Export vchiq_msg_queue_push

2020-06-29 Thread Nicolas Saenz Julienne
vchiq consumer drivers may need to use this function in order to get the benefits of vchiq's per service message queueing mechanism. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH v2 31/47] staging: vchi: Get rid of struct vchi_service

2020-06-29 Thread Nicolas Saenz Julienne
The structure only contains a single parameter, which is the underlying vchiq handle. Get rid of the struct and directly pass the handle around. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c | 23 ++--- .../vc04_services/interface/vchi/vchi.h | 25

[PATCH v2 22/47] staging: vchiq: Introduce vchiq_validate_params()

2020-06-29 Thread Nicolas Saenz Julienne
When adding a new service validate the configuration parameters provided, and remove unnecessary checks in vchi, now that we have validated service's config. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_core.c | 15 +++ .../interface/vchiq_arm/

[PATCH v2 10/47] staging: vchi: Get rid of vchi_msg_peek()

2020-06-29 Thread Nicolas Saenz Julienne
There already is a function that covers most of the functionality vchi_msg_peek() provides: vchi_msg_hold(). The main difference being that the later removes the message from vchu's queue while the other does it later on, while releasing the message. There are no users of this function that can't

[PATCH v2 07/47] staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h

2020-06-29 Thread Nicolas Saenz Julienne
From: Naushir Patuck No functional changes in this commit. - Remove erroneous whitespace. - Remove _t postfix label on structs and enums. Signed-off-by: Naushir Patuck Signed-off-by: Jacopo Mondi Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-camera/bcm2835-camera.c | 2 +-

[PATCH v2 00/47] staging: vchiq: Getting rid of the vchi/vchiq split

2020-06-29 Thread Nicolas Saenz Julienne
vchi acts as a mid layer between vchiq and its kernel services, while arguably providing little to no benefit: half of the functions exposed are a 1:1 copy of vchiq's, and the rest provide some functionality which can be easly integrated into vchiq without all the churn. Moreover it has been found

[PATCH v2 23/47] staging: vchiq: Move message queue into struct vchiq_service

2020-06-29 Thread Nicolas Saenz Julienne
This has historically been handled by vchi, but there is no reason why this couldn't be handled directly in vchiq. The patch tries to avoid altering any behavior, with the exception of the msg_queue size, which is now fixed to VCHIQ_MAX_SLOTS (it was set to VCHIQ_MAX_SLOTS / 2). This is done to ma

[PATCH v2 15/47] staging: vchi_common: Get rid of all unused definitions

2020-06-29 Thread Nicolas Saenz Julienne
There is a series of structures and enums defined but never used. Get rid of them. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchi/vchi_common.h | 65 --- 1 file changed, 65 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_com

[PATCH v2 29/47] staging: vchiq: Don't use a typedef for vchiq_callback

2020-06-29 Thread Nicolas Saenz Julienne
Linux coding style says to avoid typdefs. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchi/vchi.h| 5 - .../vc04_services/interface/vchiq_arm/vchiq_if.h | 14 -- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/stagi

[PATCH v2 16/47] staging: vchi: Get rid of unnecessary defines

2020-06-29 Thread Nicolas Saenz Julienne
Those defines aren't used by anyone. Get rid of them. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchi/vchi.h | 11 --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 - 2 files changed, 12 deletions(-) diff --git a/drivers/staging/vc0

[PATCH v2 24/47] staging: vchiq: Get rid of vchiq_util.h

2020-06-29 Thread Nicolas Saenz Julienne
The header file only provides other includes. Move the relevant includes to their respective C files and delete it for good. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchiq_arm/vchiq.h | 1 - .../interface/vchiq_arm/vchiq_2835_arm.c | 1 + .../interface/vchiq_a

[PATCH v2 39/47] staging: vchiq: Move definitions only used by core into core header

2020-06-29 Thread Nicolas Saenz Julienne
vchiq_if.h is used by service consumers and only the exported API should be present. Move the rest of definitions, which were not exported by the way, to vchiq_core.h where they belong. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_core.h | 22 +

[PATCH v2 14/47] staging: vchi: Get rid of vchi_msg_dequeue()

2020-06-29 Thread Nicolas Saenz Julienne
Nobody uses it. Get rid of it. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h | 7 .../interface/vchiq_arm/vchiq_shim.c | 39 --- 2 files changed, 46 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vc

[PATCH v2 37/47] staging: vchiq: Get rid of unnecessary definitions in vchiq_if.h

2020-06-29 Thread Nicolas Saenz Julienne
Those functions don't actually exist, nor have any use, nor the macros. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchiq_arm/vchiq_if.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h b/

[PATCH v2 25/47] staging: vchi: Expose struct vchi_service

2020-06-29 Thread Nicolas Saenz Julienne
This will make further changes easier. The struct will ultimately disappear. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchi/vchi.h| 10 +++--- .../vc04_services/interface/vchiq_arm/vchiq_shim.c | 7 --- 2 files changed, 7 insertions(+), 10

[PATCH v2 02/47] staging: mmal-vchiq: Make a mmal_buf struct for passing parameters

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson The callback from vchi_mmal to the client was growing lots of extra parameters. Consolidate them into a single struct instead of growing the list further. The struct is associated with the client buffer, therefore there are various changes to setup various containers for the

[PATCH v2 11/47] staging: vchi: Get rid of struct vchi_instance_handle

2020-06-29 Thread Nicolas Saenz Julienne
The idea behind this was to create an opaque handle to struct vchiq_instance. This can be achieved without creating a new type by means of a forward declaration of struct vchiq_instance. This saves us from a lot of useless casting and overall simplifies code. Signed-off-by: Nicolas Saenz Julienne

[PATCH v2 17/47] staging: vc04_services: Get rid of vchi_cfg.h

2020-06-29 Thread Nicolas Saenz Julienne
Nothing in it is being used. Signed-off-by: Nicolas Saenz Julienne --- .../vc04_services/interface/vchi/vchi.h | 1 - .../vc04_services/interface/vchi/vchi_cfg.h | 238 -- 2 files changed, 239 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchi

[PATCH v2 28/47] staging: vchi: Get rid of vchiq_shim's message callback

2020-06-29 Thread Nicolas Saenz Julienne
As vchiq_shim's callback does nothing aside from pushing messages into the service's queue, let's bypass it and jump directly to the service's callbacks, letting them choose whether to use the message queue. It turns out most services don't need to use the message queue, which makes for simpler co

[PATCH v2 19/47] staging: vchi: Use enum vchiq_bulk_mode instead of vchi's transmission flags

2020-06-29 Thread Nicolas Saenz Julienne
vchi has a set of transfer flags which almost map 1:1 to vchiq's own transfer modes. For the sake of simplicity let's use the later and delete vchi's. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c | 2 +- .../vc04_services/bcm2835-audio/bcm2835.h |

[PATCH v2 36/47] staging: vchi: Don't include vchiq_core.h

2020-06-29 Thread Nicolas Saenz Julienne
This file is internal to vchiq. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vc

[PATCH v2 20/47] staging: vchi: Use vchiq's enum vchiq_reason

2020-06-29 Thread Nicolas Saenz Julienne
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to simplify things, let's use the later, and get rid of the extra indirection. Signed-off-by: Nicolas Saenz Julienne --- .../bcm2835-audio/bcm2835-vchiq.c | 5 +-- .../interface/vchi/vchi_common.h | 2

[PATCH v2 13/47] staging: vc04_services: bcm2835-audio: Use vchi_msg_hold()

2020-06-29 Thread Nicolas Saenz Julienne
vchi_msg_dequeue() provides the same functionality as vchi_msg_hold() except it copies the message data as opposed to the later which provides the data in place. The copying is done on a local variable, so there is no need to keep the message out the function's bounds, so use vchi_msg_hold() inste

[PATCH v2 26/47] staging: vchiq: Export vchiq_get_service_userdata()

2020-06-29 Thread Nicolas Saenz Julienne
This is for service's callbacks to get their private data. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/stagin

[PATCH v2 12/47] staging: vchi: Unify struct shim_service and struct vchi_service_handle

2020-06-29 Thread Nicolas Saenz Julienne
The idea behind struct vchi_service_handle is to create an opaque handle to struct shim_service. This can be achieved by doing a forward declaration of struct shim_service, which will avoid unwarranted casts and pointer play. Ultimately as a rename is due all over the vchi user space, rename struc

[PATCH v2 06/47] staging: mmal-vchiq: If the VPU returns an error, don't negate it

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson There is an enum for the errors that the VPU can return. port_parameter_get was negating that value, but also using -EINVAL from the Linux error codes. Pass the VPU error code as positive values. Should the function need to pass a Linux failure, then return that as negative.

[PATCH v2 09/47] staging: vchi: Get rid of all useless callback reasons

2020-06-29 Thread Nicolas Saenz Julienne
They are neither produced nor expected, so just delete them. Signed-off-by: Nicolas Saenz Julienne --- .../interface/vchi/vchi_common.h | 40 ++- 1 file changed, 3 insertions(+), 37 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_common.h

[PATCH v2 04/47] staging: mmal-vchiq: Fix client_component for 64 bit kernel

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson The MMAL client_component field is used with the event mechanism to allow the client to identify the component for which the event is generated. The field is only 32bits in size, therefore we can't use a pointer to the component in a 64 bit kernel. Component handles are alre

[PATCH v2 05/47] staging: mmal-vchiq: Always return the param size from param_get

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson mmal-vchiq is a reimplementation of the userland library for MMAL. When getting a parameter, the client provides the storage and the size of the storage. The VPU then returns the size of the parameter that it wished to return, and as much as possible of that parameter is retu

[PATCH v2 08/47] staging: vchiq_arm: Add a matching unregister call

2020-06-29 Thread Nicolas Saenz Julienne
From: Phil Elwell All the registered children of vchiq have a corresponding call to platform_device_unregister except bcm2835_audio. Fix that. Fixes: 25c7597af20d ("staging: vchiq_arm: Register a platform device for audio") Signed-off-by: Phil Elwell Signed-off-by: Jacopo Mondi Signed-off-by:

[PATCH v2 03/47] staging: mmal-vchiq: Fixup vchiq-mmal include ordering

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson There were dependencies on including the headers in the correct order. Fix up the headers so that they include the other headers that they depend on themselves. Signed-off-by: Dave Stevenson Signed-off-by: Jacopo Mondi Signed-off-by: Nicolas Saenz Julienne --- drivers/st

[PATCH v2 01/47] staging: mmal-vchiq: Make timeout a defined parameter

2020-06-29 Thread Nicolas Saenz Julienne
From: Dave Stevenson The timeout period for VPU communications is a useful thing to extend when debugging. Set it via a define, rather than a magic number buried in the code. Signed-off-by: Dave Stevenson Signed-off-by: Jacopo Mondi Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/v

Re: [PATCH] staging: media: atomisp: i2c: atomisp-ov2680.c: fixed a brace coding style issue.

2020-06-29 Thread B K Karthik
Did this get burried in along with a bunch of other patches? I am sending this email only because I did not recieve a negetive acknowledgement on the patch. I apologize if this message was hurtful / disrespectfull in any manner, thank you for reading this message. karthik On 20/06/28 12:38AM, B

Re: [PATCH v7 00/17] wilc1000: move out of staging

2020-06-29 Thread Pali Rohár
On Tuesday 23 June 2020 11:00:04 ajay.kat...@microchip.com wrote: > This patch series is to review and move wilc1000 driver out of staging. > Most of the review comments received in [1] & [2] are addressed in the > latest code. > Please review and provide your inputs. Hello Ajay! Could you please

Re: [PATCH] staging: rtl8188eu: include: ieee80211.h: fixed multiple blank line coding style issues.

2020-06-29 Thread Michael Straube
On 2020-06-29 10:09, B K Karthik wrote: removed multiple blank lines to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/ieee80211.h | 9 - 1 file changed, 9 deletions(-) Hi, those lines are already removed in commit 5bfb7eadc5874a3a08dd

Re: [PATCH] staging/wilc1000: let wilc_mac_xmit() to NETDEV_TX_OK

2020-06-29 Thread Nicolas.Ferre
Luc, Thanks for your patch... On 28/06/2020 at 20:32, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type defining 'NETDEV_TX_OK' but this > driver returns '0' instead of 'NETDEV_TX_OK'. > > Fix this by returning

Re: [PATCH v3] staging: wfx: Get descriptors for GPIOs

2020-06-29 Thread Jérôme Pouiller
On Sunday 28 June 2020 10:52:36 CEST Linus Walleij wrote: > > The code has the functionality to insert the GPIO lines using > the global GPIO numbers through module parameters. > > As we are clearly deprecating the use of global GPIO numbers > look up the GPIO descriptors from the device instead.

[PATCH v1 3/4] rts5208/rtsx.c: use generic power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

[PATCH v1 2/4] staging/rtl8192e: use generic power management

2020-06-29 Thread Vaibhav Gupta
The structure of working of PM hooks for source files is: drivers/staging/rtl8192e/rtl8192e/rtl_pm.h : callbacks declared drivers/staging/rtl8192e/rtl8192e/rtl_pm.c : callbacks defined drivers/staging/rtl8192e/rtl8192e/rtl_core.c : callbacks used Drivers should not use legacy power

[PATCH v1 4/4] vt6655/device_main.c: use generic power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

[PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread Vaibhav Gupta
Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essential

[PATCH v1 0/4] drivers/staging: use generic power management

2020-06-29 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from amd ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling t

[PATCH] staging: rtl8188eu: include: ieee80211.h: fixed multiple blank line coding style issues.

2020-06-29 Thread B K Karthik
removed multiple blank lines to improve code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/ieee80211.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h b/drivers/staging/rtl8188eu/include/ieee80211.h index

[PATCH] staging: rtl8188eu: include: odm.h: fixed a blank space coding style issue.

2020-06-29 Thread B K Karthik
added blank space and enclosed a complex valued macro within parentheses for improved code readability. Signed-off-by: B K Karthik --- drivers/staging/rtl8188eu/include/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/s

Re: [PATCH v3] staging: wfx: Get descriptors for GPIOs

2020-06-29 Thread Linus Walleij
On Sun, Jun 28, 2020 at 12:43 PM Greg KH wrote: > On Sun, Jun 28, 2020 at 10:52:36AM +0200, Linus Walleij wrote: > > ChangeLog v2->v3: > > - ERR_CAST not PTR_CAST > > ChangeLog v1->v2: > > - Fixed a cast and a variable name. > > - I still don't know how to compile this but hey the zeroday > > r