On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote:
>
> On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
> >
> > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> > wrote:
> > > So, IMO, the best is to keep it on staging for a while, until those
> > > remaining bugs gets solved.
> > >
>
On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote:
>
> On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
> wrote:
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
> >
> > I added this series, together with the regulator driver and
> > a
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
wrote:
> @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct
> platform_device *pdev)
> }
>
> static const struct of_device_id kirin_drm_dt_ids[] = {
> - { .compatible = "hisilicon,hi3660-dpe",
> + { .compatible =
On Wed, 2020-08-19 at 21:54 +0530, Allen wrote:
> > [...]
> > > > Since both threads seem to have petered out, let me suggest in
> > > > kernel.h:
> > > >
> > > > #define cast_out(ptr, container, member) \
> > > > container_of(ptr, typeof(*container), member)
> > > >
> > > > It does what you
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
wrote:
> So, IMO, the best is to keep it on staging for a while, until those
> remaining bugs gets solved.
>
> I added this series, together with the regulator driver and
> a few other patches (including a hack to fix a Kernel 5.8
> regression
Hi John.
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
>
> I'm not sure I see all of these as compelling for pushing it in via
> staging. And I suspect in the process of submitting the patches for
> review folks may find the cause of some
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab
wrote:
> Yet, I'm submitting it via staging due to the following reasons:
>
> - It depends on the LDO3 power supply, which is provided by
> a regulator driver that it is currently on staging;
> - Due to legal reasons, I need to preserve the
Hi Xin Ji.
On Mon, Aug 10, 2020 at 10:35:46PM +0200, Sam Ravnborg wrote:
> Hi Xin Ji.
>
> On Thu, Jul 09, 2020 at 04:31:09PM +0800, Xin Ji wrote:
> > Hi all,
> >
> > The following series add support for the Slimport ANX7625 transmitter, a
> > ultra-low power Full-HD 4K MIPI to DP transmitter
On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart
wrote:
> On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > > This patch series port the out-of-tree driver for Hikey 970 (which
> > > should also support
Remove BUG() at ion_sytem_heap.c and error handling to:
- free_buffer_page
- alloc_buffer_page
this fix the following checkpatch issue:
Avoid crashing the kernel - try using WARN_ON &
recovery code ratherthan BUG() or BUG_ON().
Signed-off-by: Tomer Samara
---
BUG_ON() is removed at ion_page_pool.c and add error handleing to
ion_page_pool_shrink
Fixes the following issue:
Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG()
or BUG_ON().
Signed-off-by: Tomer Samara
---
drivers/staging/android/ion/ion_page_pool.c | 14
Remove BUG/BUG_ONs from androind/ion allocator and add error handling to
calling functions
Tomer Samara (2):
staging: android: Remove BUG_ON from ion_page_pool.c
staging: android: Remove BUG from ion_system_heap.c
drivers/staging/android/ion/ion_page_pool.c | 14 ++
Removeing BUG/BUG_ON from androind/ion and add error handle to calling
functions
Tomer Samara (2):
staging: android: Remove BUG_ON from ion_page_pool.c
staging: android: Remove BUG from ion_system_heap.c
drivers/staging/android/ion/ion_page_pool.c | 14 ++
On 8/19/20 9:24 AM, Allen wrote:
>> [...]
Since both threads seem to have petered out, let me suggest in
kernel.h:
#define cast_out(ptr, container, member) \
container_of(ptr, typeof(*container), member)
It does what you want, the argument order is the same
> [...]
> > > Since both threads seem to have petered out, let me suggest in
> > > kernel.h:
> > >
> > > #define cast_out(ptr, container, member) \
> > > container_of(ptr, typeof(*container), member)
> > >
> > > It does what you want, the argument order is the same as
> > > container_of with
On 8/19/20 4:46 AM, Mauro Carvalho Chehab wrote:
> Now that everything is in place, add the driver to the
> building system.
>
> Signed-off-by: Mauro Carvalho Chehab
Hi Mauro,
In this patch and in patch 01/49, please be consistent in capitalization
on HiSilicon.
more below:
> ---
>
On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote:
> Hi Mauro.
>
> On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> > This patch series port the out-of-tree driver for Hikey 970 (which
> > should also support Hikey 960) from the official 96boards tree:
> >
> >
Hi Mauro.
On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> This patch series port the out-of-tree driver for Hikey 970 (which
> should also support Hikey 960) from the official 96boards tree:
>
>https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
>
> Based on
On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote:
> On 8/18/20 1:00 PM, James Bottomley wrote:
[...]
> > Since both threads seem to have petered out, let me suggest in
> > kernel.h:
> >
> > #define cast_out(ptr, container, member) \
> > container_of(ptr, typeof(*container), member)
> >
>
On Wed, Aug 19, 2020 at 07:17:19AM -0600, Jens Axboe wrote:
> On 8/19/20 6:11 AM, Greg KH wrote:
> > On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote:
> >> On 8/18/20 1:00 PM, James Bottomley wrote:
> >>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
> On 8/17/20 12:48 PM,
On 8/19/20 6:11 AM, Greg KH wrote:
> On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote:
>> On 8/18/20 1:00 PM, James Bottomley wrote:
>>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
On 8/17/20 12:48 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens
On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote:
> On 8/18/20 1:00 PM, James Bottomley wrote:
> > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
> >> On 8/17/20 12:48 PM, Kees Cook wrote:
> >>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
> On 8/17/20 12:29 PM,
On 8/18/20 1:00 PM, James Bottomley wrote:
> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
>> On 8/17/20 12:48 PM, Kees Cook wrote:
>>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
On 8/17/20 12:29 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens
This is part of support for a panel display. Those don't come
with the Hikey 960 or 970 boards. As I don't have any of
those for tests, and we didn't port another required driver
for this to work, for now, let's drop it.
This patch can be reversed later, if one would be adding
support for it.
There are lots of ifdefs checking if the SoC version is
960 or 970. Replace them all by runtime definitions.
With that, the same DRM driver should work with both versions.
The behavior will dynamically change depending on the
OF compatible strings.
Signed-off-by: Mauro Carvalho Chehab
---
The DPE headers define several macros for I/O. Get rid of
them by replacing by the Linux ones.
In the specific case of outp32(), I used this small
coccinelle script to change them to writel():
@ rule1 @
expression addr, val;
@@
-outp32(addr, val)
There are lots of coding style issues on this driver, as
reported by checkpatch.
Address most of them.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 340 +++--
.../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1199 -
From: Xiubin Zhang
Add suspend and resume interface to solve SR Cannot Display Problems.
Signed-off-by: Xiubin Zhang
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 32 +++
drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 14 +-
This is needed for the DRM to work. Ok, right now, this is
enabled on default fastboot logic, but, as soon as we enable
the proper SPMI driver, such code is needed.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 4 +---
Place both adv7535 and panel logic at the same routine,
cleaning up things a little bit and fixing the includes.
Signed-off-by: Mauro Carvalho Chehab
---
.../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c| 58 ++-
1 file changed, 31 insertions(+), 27 deletions(-)
diff --git
The OOT had a fork of adv7535 with some changes for it to
work with a failing EDID retrival I/O.
Get rid of it, as we'll be using the upstream driver.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 1678 -
There are a few typedefs inside this driver. Get rid of them.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 126 +-
.../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 117
.../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c |
This function has a too generic name to export it as a
symbol. Also, we should likely use some other macro instead.
So, for now, just copy it into the Kirin9xx dsi module, in order
for the driver to build.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
call drm_connector_register() when initializing the connector.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
Use SPMI headers to identify the license of each file.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 +
.../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 +
.../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 4 ++-
This is not used anymore on this version, so let's get rid
of them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 3 ---
drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 ---
drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 --
3 files changed,
From: Liwei Cai
The use of synchronization mechanisms to deal with the display of
buffer, to solve the problem of display tearing.
Signed-off-by: Wanchun Zheng
Signed-off-by: Liwei Cai
Signed-off-by: John Stultz
Signed-off-by: Mauro Carvalho Chehab
---
From: Xiubin Zhang
Add some debug prints on adv7535 and kirin_drm_drv.
Signed-off-by: Xiubin Zhang
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 40 ++--
drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 2 +-
2 files changed, 37
From: Liwei Cai
There is an error at wait for vactive end flags, waiting
vactive flag in 1ms maybe too rough, but it's not good to
control the waiting grain size, there is no way to get the
waiting unit, so the interrupt mechanism is the best way to
solve this problem.
Each frame would report
From: Xiubin Zhang
Modfiy pix_clk and dsi lanes to improve HDMI compatibility for hikey970.
Signed-off-by: Xiubin Zhang
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 53 ++-
drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 9 +-
Those aren't needed anymore.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 -
drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 -
drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 --
3 files changed, 4 deletions(-)
diff --git
From: John Stultz
Update the driver to work with v4.9 kernels
Signed-off-by: John Stultz
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 4 +-
drivers/staging/hikey9xx/gpu/kirin_dpe_reg.h | 1 +
drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 3 +-
There were several changes at the upstream kAPIs since
Kernel 4.4. Update the driver for it to build with the
upstream Kernel.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 28 +++---
.../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 26 +++---
Use the same standard as used on other Hisilicon DRM
config vars for kirin9xx.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c| 2 +-
.../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h| 2 +-
drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c
We don't need to implement legacy fbdev support. Just use
the FB emulation instead.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 9 +-
.../staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 -
drivers/staging/hikey9xx/gpu/kirin9xx_fb.c| 94
Now that everything is in place, add the driver to the
building system.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/Kconfig | 3 ++
drivers/staging/hikey9xx/Makefile | 1 +
drivers/staging/hikey9xx/gpu/Kconfig | 52 ++-
From: Xiubin Zhang
Add HDMI/DSS power on in the SR flow.
Signed-off-by: Xiubin Zhang
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/Makefile | 1 -
drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 10 +--
.../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 9 ++-
Do some cleanups at the mode validation code. Right now, there
is a known issue with this driver which makes it to set up
some invalid modes, depending on the display.
We don't know yet what the issue is, so, instead, let's add
a table with the modes which are known to work.
Signed-off-by: Mauro
At least on current upstream Kernels, forcing an event parse
during init time isn't needed anymore.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
b/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c
index
From: Xiubin Zhang
Modfiy mipi dsi lanes to improve HDMI compatibility.
Signed-off-by: Xiubin Zhang
Signed-off-by: Liuyao An
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 24 ---
drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 4
The logic there is more complex than it needs. It also places
the device with a wrong setting if the flags are missed.
This currently happens on Kirin970 for HDMI, as there's a bug
at the part of the driver which selects between PANEL or
OUTPUT at encoder init code.
Signed-off-by: Mauro Carvalho
There's already a driver with the same namespace
for an older Kirin chipset. Rename this one, in order
to make it clearer that this is the driver for
Kirin 960/970.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/{kirin_dpe_reg.h => kirin9xx_dpe_reg.h} | 0
Allocate the framebuffer memory via CMA, as otherwise the
drm driver may not work properly with X11.
Part of the changes here were based on a patch originally
authored by:
alik
The original version can be found at:
While this driver apparently supports both IOMMU and no-IOMMU
access, it always enable the IOMMU via some code, at the
downstream version.
Apparently, the downstream iommu is there just to get the
physical address of the logical IOMMU address. Based on
the downstream code, it sounds that the
The includes there reflect a downstream version back on v4.4
times. change them to reflect the current upstream and to
avoid the need of using a -I flag at the Makefile.
Signed-off-by: Mauro Carvalho Chehab
---
...{kirin9xx_dpe_reg.h => kirin960_dpe_reg.h} | 3 +++
Instead of implementing it at the code, use the default
methods from CMA helper
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git
This patch series port the out-of-tree driver for Hikey 970 (which
should also support Hikey 960) from the official 96boards tree:
https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
Based on his history, this driver seems to be originally written
for Kernel 4.4, and was later ported
- Get rid of a global var meant to store one of its priv
structs;
- Change the name of the driver, in order to not be confused with
the kirin6220;
- Remove some unneeded ifdef;
- use drm_of.h helper.
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 81
There are some #ifdefs there for non-existing CONFIG_ options
(nor even at the downstream code).
Let's get rid of those. It can be re-added later if ever needed.
Signed-off-by: Mauro Carvalho Chehab
---
.../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 36 ---
There are some things inside struct dss_hw_ctx that are unused.
Get rid of them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 2 --
drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 ---
drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 2 --
3
Currently, the method is empty. However, looking at the driver,
it sounds it shouldn't be hard to implement it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
The logich which sets the MIPI parameters is currently wrong:
it is using a value stored at cur_client, with actually points
to the active location, and not to the one that it is about
to be initialized.
The entire logic sounds buggy, but for now let's just keep
following it, by adding an extra
From: Xiubin Zhang
Adjust pixel clock for compatibility with 10.1 inch special displays.
Signed-off-by: Xiubin Zhang
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/hikey9xx/gpu/kirin_drm_dss.c | 4
1 file changed, 4 insertions(+)
diff --git
Those methods belong to crtc fops
Signed-off-by: Mauro Carvalho Chehab
---
.../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 21 ++-
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c
On 2020-08-19 11:28, Mauro Carvalho Chehab wrote:
Em Tue, 18 Aug 2020 15:02:54 -0700
John Stultz escreveu:
On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote:
On 2020-08-18 16:29, Mauro Carvalho Chehab wrote:
Em Tue, 18 Aug 2020 15:47:55 +0100
Basically, the DT binding has this, for IOMMU:
> > > > > > > >
> > > > > > > > In preparation for unconditionally passing the
> > > > > > > > struct tasklet_struct pointer to all tasklet
> > > > > > > > callbacks, switch to using the new tasklet_setup()
> > > > > > > > and from_tasklet() to pass the tasklet pointer explicitly.
> > > > > > >
>
Em Tue, 18 Aug 2020 15:02:54 -0700
John Stultz escreveu:
> On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote:
> > On 2020-08-18 16:29, Mauro Carvalho Chehab wrote:
> > > Em Tue, 18 Aug 2020 15:47:55 +0100
> > > Basically, the DT binding has this, for IOMMU:
> > >
> > >
> > > smmu_lpae
On 2020-08-18 23:02, John Stultz wrote:
On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote:
On 2020-08-18 16:29, Mauro Carvalho Chehab wrote:
Em Tue, 18 Aug 2020 15:47:55 +0100
Basically, the DT binding has this, for IOMMU:
smmu_lpae {
compatible =
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
branch HEAD: bc752d2f345bf55d71b3422a6a24890ea03168dc staging: hikey9xx:
Kconfig: add regulator dependency
elapsed time: 722m
configs tested: 71
configs skipped: 1
The following configs have been
On Wed, Aug 19, 2020 at 02:57:14PM +0800, Hsin-Yi Wang wrote:
> I think you missed this email :)
>
> -- Forwarded message -
> From: Sam Ravnborg
> Date: Tue, Aug 11, 2020 at 4:35 AM
> Subject: Re: [PATCH v14 0/2] Add initial support for slimport anx7625
> To: Xin Ji
> Cc: ,
71 matches
Mail list logo
