On Mon, Sep 07, 2020 at 08:19:43PM +0200, Nicolas Saenz Julienne wrote:
> Indeed, that's why I wasn't all that happy with my solution.
>
> As an alternative, how about returning '-dev->bus_dma_limit' instead of 0?
> It's
> always 0 for the devices without bus_dma_regions, and, I think, an always
On Mon, Sep 07, 2020 at 01:40:46PM -0400, Jim Quinlan wrote:
> Thanks for looking into this. The concern I have with your solution
> is that returning an arbitrarily large offset might overlap with an
> improbable but valid usage. AFAIK there is nothing that disallows
> mapping a device to anywhe
On Mon, Sep 07, 2020 at 05:18:59PM +0200, Nicolas Saenz Julienne wrote:
> Hi Christoph, a small fix to your fixes:
Thanks,
folded into the patch on the dma-ranges branch.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
300-h8300h-sim_defconfig
| `-- include-linux-platform_device.h:error:unknown-type-name-irq_handler_t
|-- h8300-randconfig-r014-20200907
| `-- include-linux-platform_device.h:error:unknown-type-name-irq_handler_t
|-- h8300-randconfig-r034-20200907
| `-- include-linux-platform_device.h:error:un
On Fri, Sep 04, 2020 at 10:01:11PM +0200, Martin Cerveny wrote:
> Allwinner V3s SoC contains video engine. Add compatible for it.
>
> Signed-off-by: Martin Cerveny
The prefix isn't the right one, it shouldn't be media: but dt-bindings: media:
cedrus:
Maxime
signature.asc
Description: PGP sig
Hi,
On Fri, Sep 04, 2020 at 10:01:06PM +0200, Martin Cerveny wrote:
> First patch extends cedrus capability to all decoders
> because V3s missing MPEG2 decoder.
>
> Next two patches add system control node (SRAM C1) and
> next three patches add support for Cedrus VPU.
How was it tested?
Maxime
Fixed a coding style issue by merging split quoted strings in qlge_main.c
to fix checkpatch warnings.
Signed-off-by: Ross Schmidt
---
drivers/staging/qlge/qlge_main.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/stagi
Fixed line cannot end with '(' check.
Signed-off-by: Naveen Panwar
---
drivers/staging/octeon-usb/octeon-hcd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 61471a19d4e6..e2f8b6b67f75
allmodconfig
powerpc defconfig
powerpc allyesconfig
powerpc allmodconfig
i386 randconfig-a004-20200907
i386 randconfig-a005-20200907
i386 randconfig-a006-20200907
i386
mips allmodconfig
powerpc defconfig
powerpc allyesconfig
powerpc allmodconfig
i386 randconfig-a004-20200907
i386 randconfig-a005-20200907
i386
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
head: fa802fde315b87157f6d7c5dfe5d926bdb97d6e4
commit: 4f4e9ddba1225e2dcdd08ac91f1e82aaca51f2b8 [29/33] drivers: provide
devm_platform_request_irq()
config: h8300-randconfig-r034-20200907
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-testing
head: fa802fde315b87157f6d7c5dfe5d926bdb97d6e4
commit: 4f4e9ddba1225e2dcdd08ac91f1e82aaca51f2b8 [29/33] drivers: provide
devm_platform_request_irq()
config: h8300-randconfig-r014-20200907
On 9/7/2020 10:43 AM, Jim Quinlan wrote:
On Mon, Sep 7, 2020 at 5:16 AM Lorenzo Pieralisi
wrote:
On Thu, Aug 27, 2020 at 09:29:59AM -0400, Jim Quinlan wrote:
On Thu, Aug 27, 2020 at 2:35 AM Christoph Hellwig wrote:
On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote:
Hi,
On Mon, 2020-09-07 at 13:40 -0400, Jim Quinlan wrote:
> On Mon, Sep 7, 2020 at 11:01 AM Nicolas Saenz Julienne
> wrote:
> > >
> > > Hi Nicolas,
> > >
> > > Can you please help us out here? It appears that your commit
> >
> > It's dma_offset_from_dma_addr() that's causing trouble. It goes over
Hi Christoph, a small fix to your fixes:
On Tue, 2020-09-01 at 10:24 +0200, Christoph Hellwig wrote:
> I've applied this to the dma-mapping tree.
>
> I had to resolve a conflict in drivers/of/address.c with a recent
> mainline commit. I also applied the minor tweaks Andy pointed out
> plus a few
Hi Jim, sorry I'm a little late to the party, but was on vacation.
On Thu, 2020-09-03 at 13:32 -0400, Jim Quinlan wrote:
> On Wed, Sep 2, 2020 at 8:52 PM Nathan Chancellor
> wrote:
> > On Wed, Sep 02, 2020 at 05:36:29PM -0700, Florian Fainelli wrote:
> > >
> > > On 9/2/2020 3:38 PM, Nathan Chanc
On 01/07/2020 02:16, Jordan Hand wrote:
> On 5/26/20 7:31 AM, Heikki Krogerus wrote:
>> On Fri, May 22, 2020 at 11:57:36AM +0200, Mauro Carvalho Chehab wrote:
>>> Em Thu, 21 May 2020 11:00:19 +0300
>>> Andy Shevchenko escreveu:
>>>
+Cc: Heikki (swnode expert)
On Wed, May 20, 2020 at
From: Jérôme Pouiller
There is no reason to place two spaces between the field tx_conf_payload
and its type.
In the same vein, remove duplicate empty lines between declarations.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 4 +---
drivers/staging/wfx/hif_api_gene
From: Jérôme Pouiller
The structs hif_queue, hif_data_flags, hif_tx_flags and
hif_ht_tx_parameters have no real reasons to exist. Drop them and
simplify access to fields of struct hif_req_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 39 ++--
dr
On Mon, Sep 07, 2020 at 04:07:03PM +0530, Naveen Panwar wrote:
> Adding a blank line after variable declarations
Why?
>
> Signed-off-by: Naveen Panwar
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ralink-gdma/ralink-
From: Jérôme Pouiller
This struct hif_ie_tlv is definitively an Information Element (IE). This
struct is defined by 802.11 specification and already exists in
mac80211. Reuse this definition instead of struct hif_ie_tlv.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 10
From: Jérôme Pouiller
The union hif_indication_data is never used in the driver. So, it is not
necessary to declare it separately from hif_ind_generic.
In add, drop prefix 'indication_' from the names 'indication_type' and
'indication_data' since it is redundant with the name of the struct.
Sig
From: Jérôme Pouiller
In the wfx driver, the prefix 'hif_mib_' is normally used for structures
that represent a hardware message. hif_mib_tx_rate_retry_policy does not
fall in this category. So, rename it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_mib.h | 4 ++--
1 file ch
From: Jérôme Pouiller
The union hif_event_data is never used in the driver. So, it is
not necessary to declare it separately from hif_ind_event.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a
Adding a blank line after variable declarations
Signed-off-by: Naveen Panwar
---
drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ralink-gdma/ralink-gdma.c
index eabf1093328e..9ad012d1581f 1
From: Jérôme Pouiller
The parameter "async" in wfx_cmd_send() allows to send command without
waiting for the reply. In this case, the mutex hif_cmd.lock is released
asynchronously in the context of the receiver workqueue.
However, "kbuild test robot" complains about this architecture[1] since
it
From: Jérôme Pouiller
The driver is now close to leave the staging directory. Update the TODO
list to reflect the work done.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/TODO | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/wfx/TODO b/drivers/st
From: Jérôme Pouiller
Struct hif_bss_flags has no reason to exist. In add, it is never used.
Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/stagi
From: Jérôme Pouiller
Struct hif_suspend_resume_flags has no reason to exist. Drop it and
simplify access to struct hif_ind_suspend_resume_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
drivers/staging/wfx/hif_rx.c | 6 +++---
2 files changed, 4 inser
From: Jérôme Pouiller
Struct hif_pm_mode has no reason to exist. Drop it and simplify access
to struct hif_req_set_pm_mode.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
drivers/staging/wfx/hif_tx.c | 4 ++--
2 files changed, 3 insertions(+), 7 deletions
From: Jérôme Pouiller
A new kind of error has appeared in API 3.4.
The Linux driver is not concerned by this new error, but let's keep the
API in sync with the firmware.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 1 +
drivers/staging/wfx/hif_rx.c | 2 +
From: Jérôme Pouiller
Struct hif_join_flags has no reason to exist. Drop it and simplify
access to struct hif_req_join.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/w
From: Jérôme Pouiller
wfx_join() and wfx_join_finalize() are the two halves of the association
process. Group them.
In addition, for better uniformity of the code, rename wfx_do_join() in
wfx_join().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 100 +++---
From: Jérôme Pouiller
Struct hif_ie_flags has no reason to exist. Drop it and simplify
access to struct hif_req_update_ie.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 14 +-
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 6 insertions(+), 10 d
On 02/09/2020 18:10, Mauro Carvalho Chehab wrote:
> While I was lately relying on Jenkins to report smatch/sparse issues,
> I discovered this week that the reports were missing such warnings
>
> I got it fixed already at builder.linuxtv.org, but there are several new
> warnings that got added over
From: Jérôme Pouiller
hif_tx_mib.c contains functions that format data to be sent to the
hardware. In this file, sometime the struct to be sent is named 'arg',
sometime 'val'. In some other function 'val' is used for the argument of
the function.
This patch uniformize the things and choose to ca
From: Jérôme Pouiller
The union hif_privacy_key_data is never used in the driver. So, it is
not necessary to declare it separately from hif_req_add_key.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 24 +++-
1 file changed, 11 insertions(+), 13 dele
From: Jérôme Pouiller
Struct hif_reset_flags has no reason to exist. Drop it and simplify
access to struct hif_req_reset.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +++---
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
From: Jérôme Pouiller
Enum hif_beacon is not used. Moreover, it is just another definition of
a boolean. Absolutely useless.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers
From: Jérôme Pouiller
The structs hif_capabilities, hif_otp_regul_sel_mode_info and
hif_otp_phy_info have no real reasons to exist. Drop them and simplify
access to fields of struct hif_ind_startup.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 32 +
From: Jérôme Pouiller
Struct hif_tx_result_flags has no reason to exist. Drop it and simplify
access to struct hif_cnf_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 +--
drivers/staging/wfx/hif_api_cmd.h | 16 ++--
2 files changed, 7 insertions(+), 1
From: Jérôme Pouiller
The maximum length of a SSID is defined by 802.11 specification. It is
already defined in mac80211: IEEE80211_MAX_SSID_LEN. Therefore, use this
generic definition.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 8 +++-
drivers/staging/wfx/h
From: Jérôme Pouiller
Struct hif_map_link_flags has no reason to exist. Drop it and simplify
access to struct hif_req_map_link.
Also rename the field 'map_direction' in 'unmap'. It is more
meaningful and allows to drop enum hif_sta_map_direction.
Signed-off-by: Jérôme Pouiller
---
drivers/sta
From: Jérôme Pouiller
Struct hif_rx_flags has no reason to exist. Drop it and simplify access
to struct hif_ind_rx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_rx.c | 2 +-
drivers/staging/wfx/hif_api_cmd.h | 25 ++---
2 files changed, 11 insertions(+),
From: Jérôme Pouiller
The structs hif_scan_type, hif_scan_flags and hif_auto_scan_param have
no real reasons to exist (apart maybe defining namespaces). Moreover,
the names of the fields within these structs are not all meaningful.
Drop the structs and rename the fields.
Signed-off-by: Jérôme P
From: Jérôme Pouiller
The device allows to filter multicast frames. The driver has the
necessary code to take advantage of this feature. However, some bugs
has been reported on this feature. So, it was temporary disabled.
Finally, the things work well as-is for more than one year now. So there
i
From: Jérôme Pouiller
The statements in wfx_bss_info_changed() has no particular order.
For better readability, group and sort the statements relative to the
association processing.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 53 +++
1 fi
From: Jérôme Pouiller
Since the code for multicast filtering has been dropped, the function
hif_set_data_filtering() is only called to disable multicast filtering.
In fact, the multicast filtering is already disabled by default. So,
this function is useless and can be dropped.
Signed-off-by: Jér
From: Jérôme Pouiller
The file hif_tx_mib.c expects to contain functions that format messages
for the hardware. It is unexpected to find function that manipulate
RCU and structures from mac80211.
Keep hif_set_association_mode() with the code necessary for message
formatting and relocate the smar
From: Jérôme Pouiller
The Secure Link (slk) feature allows to encrypt (and authenticate) the
traffic between the host and the device. The official implementation of
this feature relies on mbedTLS. For that reason, this implementation is
not included in the current driver. To be included, the impl
From: Jérôme Pouiller
Union hif_commands_ids is unused.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/staging/wfx/hif_api_cmd.h
index 75e8c2a7fdf9..c132d8e43b50 100644
-
From: Jérôme Pouiller
Hello folks,
This PR fixes most of the items of the TODO list associated to the wfx driver.
Normally, my next PR will ask to move the wfx driver out of the staging
area.
Jérôme Pouiller (31):
staging: wfx: improve readability of association processing
staging: wfx: rel
On Mon, Sep 07, 2020 at 03:05:03PM +0530, Naveen Panwar wrote:
> Fixing the codestyle related changes in the ralink-gdma driver
>
> Signed-off-by: Naveen Panwar
> ---
> drivers/staging/ralink-gdma/ralink-gdma.c | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
Fixing the codestyle related changes in the ralink-gdma driver
Signed-off-by: Naveen Panwar
---
drivers/staging/ralink-gdma/ralink-gdma.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c
b/drivers/staging/ral
On Thu, Aug 27, 2020 at 09:29:59AM -0400, Jim Quinlan wrote:
> On Thu, Aug 27, 2020 at 2:35 AM Christoph Hellwig wrote:
> >
> > On Tue, Aug 25, 2020 at 10:40:27AM -0700, Florian Fainelli wrote:
> > > Hi,
> > >
> > > On 8/24/2020 12:30 PM, Jim Quinlan wrote:
> > >>
> > >> Patchset Summary:
> > >>
On Mon, Sep 07, 2020 at 12:27:45PM +0530, Naveen Panwar wrote:
> Fixed checkpatch warnings two warnings still exits about DT
> compatible strings appers undocumented. Fixed the other codestyle
> errors, and some warnings about use of volatile and un-necessary
> out of memory errors.
>
> Signed-off
56 matches
Mail list logo
