RE: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-09-23 Thread Shubhrajyoti Datta
Hi , Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:48 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@driverdev.osuosl.org; robh...@kernel.org; > gre...

Re: [RFC PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic

2020-09-23 Thread Kees Cook
On Wed, Sep 23, 2020 at 09:31:34PM +0200, Greg KH wrote: > On Wed, Sep 23, 2020 at 12:04:58PM -0700, Kees Cook wrote: > > On Wed, Sep 23, 2020 at 07:10:27AM +0200, Greg KH wrote: > > > On Tue, Sep 22, 2020 at 07:43:36PM -0600, Shuah Khan wrote: > > > > struct binder_stats { > > > > - atomic_

Re: [RFC PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic

2020-09-23 Thread Greg KH
On Wed, Sep 23, 2020 at 12:04:58PM -0700, Kees Cook wrote: > On Wed, Sep 23, 2020 at 07:10:27AM +0200, Greg KH wrote: > > On Tue, Sep 22, 2020 at 07:43:36PM -0600, Shuah Khan wrote: > > > counter_atomic is introduced to be used when a variable is used as > > > a simple counter and doesn't guard obj

Re: [RFC PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic

2020-09-23 Thread Kees Cook
On Wed, Sep 23, 2020 at 07:10:27AM +0200, Greg KH wrote: > On Tue, Sep 22, 2020 at 07:43:36PM -0600, Shuah Khan wrote: > > counter_atomic is introduced to be used when a variable is used as > > a simple counter and doesn't guard object lifetimes. This clearly > > differentiates atomic_t usages that

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-23 Thread Dan Scally
Hi Sakari On 17/09/2020 11:33, Sakari Ailus wrote: >> +ret = software_node_register_nodes(nodes); >> +if (ret) { >> +dev_err(dev, >> +"Failed to register software nodes for %s\n", >> +supported_devi

RE: [PATCH 1/2] media: atomisp: fix gcc warnings

2020-09-23 Thread David Laight
From: Mauro Carvalho Chehab > Sent: 23 September 2020 09:22 > > Depending on the gcc version, after changeset > 72a9ff3bf7fb ("media: atomisp: get rid of -Wsuggest-attribute=format > warnings"), > we're now getting two warnings, which are breaking the Jenkins > CI instance at https://builder.linu

[PATCH 2/2] media: atomisp: cleanup __printf() atributes on printk messages

2020-09-23 Thread Mauro Carvalho Chehab
There are still some warnings produced by -Wsuggest-attribute=format, like this one: drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c: In function ‘dtrace_dot’: drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:2466:2: warning: function ‘dtrace

[PATCH 1/2] media: atomisp: fix gcc warnings

2020-09-23 Thread Mauro Carvalho Chehab
Depending on the gcc version, after changeset 72a9ff3bf7fb ("media: atomisp: get rid of -Wsuggest-attribute=format warnings"), we're now getting two warnings, which are breaking the Jenkins CI instance at https://builder.linuxtv.org: ../drivers/staging/media/atomisp/pci/atomisp_compat_css2