On Fri, Sep 25, 2020 at 10:57:27AM -0500, Alex Elder wrote:
On 9/25/20 9:07 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote:
On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote:
Use __8 to replace int and remove the unnecessary __bitwise type
attribu
Benötigen Sie finanzielle Unterstützung? Wurde Ihnen von Ihrer Bank oder Ihrem
Finanzunternehmen ein Darlehen verweigert? In diesem Fall stehen persönliche
oder geschäftliche Darlehensangebote mit einem erschwinglichen Zinssatz von 2%
zur Verfügung. kontaktiere uns jetzt.
Vollständiger Name:
La
On Fri, Sep 25, 2020 at 11:02:23AM -0500, Alex Elder wrote:
On 9/25/20 9:11 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote:
From: Coiby Xu
Sent: 24 September 2020 11:21
Use __8 to replace int and remove the unnecessary __bitwise type
attribute.
Found by spars
Good day,
You have been selected to receive my grant donation. Please, contact me for
further detail.reply to mrsveraael...@gmail.com
Best Regards,
Mrs. Vera Aellen.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverprojec
defconfig
mips allyesconfig
mips allmodconfig
powerpc allyesconfig
powerpc allmodconfig
powerpc allnoconfig
i386 randconfig-a002-20200925
i386
On 9/25/20 5:52 PM, Kees Cook wrote:
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
-- Addressed Kees's comments:
1. Non-atomic counters renamed to counter_simple32 and counter_simple64
to clearly indicate size.
2. Added warning for counter_simple* usage and it should
On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote:
> -- Addressed Kees's comments:
>1. Non-atomic counters renamed to counter_simple32 and counter_simple64
> to clearly indicate size.
>2. Added warning for counter_simple* usage and it should be used only
> when there is
counter_atomic* is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object lifetimes.
counter_atomic* variables will wrap around to 0 when it overflows and
should not be used to guard resour
This patch series is a result of discussion at the refcount_t BOF
the Linux Plumbers Conference. In this discussion, we identified
a need for looking closely and investigating atomic_t usages in
the kernel when it is used strictly as a counter without it
controlling object lifetimes and state chang
On Fri, 2020-09-25 at 18:30 +, Corentin Labbe wrote:
> Signed-off-by: Corentin Labbe
[]
> diff --git a/drivers/staging/media/zoran/zoran_device.c
> b/drivers/staging/media/zoran/zoran_device.c
[]
> @@ -198,15 +198,14 @@ void detect_guest_activity(struct zoran *zr)
[]
> for (i = 0; i < j
Adding vidioc_g_parm made v4l compliance happy.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zoran_driver.c
index bcbe2c78ea16..5
In fact, zoran does not support V4L2_STD_ALL, so let's enumerate what we
support.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/z
The slot 0 of guest is never initialized and so we print later random
data.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_devi
Hello
The zoran driver was removed in 5.3
The main reason of the removing was lack of motivation to convert it to
VB2
Since I need it, I worked on bringing it back.
So the plan to achieve it was:
- clean up the coding style.
- convert old usage/API
- clean unused code
- convert to VB2
I have tri
Instead of using hardcoded numbers, let's use some define for ZR NORM.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 4
drivers/staging/media/zoran/zoran_card.c | 8
drivers/staging/media/zoran/zoran_driver.c | 6 +++---
3 files changed, 11 insert
move function for avoiding forward declaration
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 44 +++---
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran
Let's use devm allocations for videocodec, this simplify code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/
The test_interrupts function is useless, remove it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 3 ---
drivers/staging/media/zoran/zoran_card.c | 27 --
drivers/staging/media/zoran/zoran_device.c | 16 -
3 files changed, 46 de
This patch converts all errors dprintk to pci_err/pr_err.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.c | 39 +--
drivers/staging/media/zoran/zoran_card.c | 96 ++
drivers/staging/media/zoran/zoran_device.c | 28 +-
drivers/staging/media/zoran/zoran_driver
As asked by checkpath, let's use udelay.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index 0ecb044f8e8
Update the TODO of the zoran driver
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/TODO | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/TODO b/drivers/staging/media/zoran/TODO
index 54464095d0d7..6992540d3e53
We need to get rid of zoran_fh, so move the jpg_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 -
drivers/staging/media/zoran/zoran_driver.c | 103 ++---
2 files changed, 47 insertions(+), 58 deletions(-
Using devm_ioremap simplify code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index f4639324bace..147bef1
Use pci_request_regions so now we can see zoran in /proc/iomem.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_car
The ns_to_timeval function is removed, so replace it with
v4l2_buffer_set_timestamp().
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/stagin
Add myself as maintainer.
Signed-off-by: Corentin Labbe
---
Documentation/media/v4l-drivers/zoran.rst | 22 +++---
MAINTAINERS| 10 ++
drivers/staging/media/zoran/zoran_card.c | 5 -
drivers/staging/media/zoran/zoran_card.h | 5 -
This patch adds the allocation of the stat_com buffer which be used
later.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h | 2 ++
drivers/staging/media/zoran/zoran_card.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/stagi
We need to get rid of zoran_fh, so move the overlay_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 1 -
drivers/staging/media/zoran/zoran_device.c | 8 ++---
drivers/staging/media/zoran/zoran_driver.c | 40 +--
Fix some typo in doc.
Signed-off-by: Corentin Labbe
---
Documentation/media/v4l-drivers/zoran.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/media/v4l-drivers/zoran.rst
b/Documentation/media/v4l-drivers/zoran.rst
index a0586514cd8a..2b82b9a47a71 100644
This is it! the ultimate last step, the vb2 conversion.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig|2 +-
drivers/staging/media/zoran/zoran.h| 83 +-
drivers/staging/media/zoran/zoran_card.c | 45 +-
drivers/staging/media/zoran/zoran_device.c |
This patchs removed the deprecated .vidioc_g_jpegcomp and replace it
with corresponding v4l2_ctrl_ops code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 22 ++
drivers/staging/media/zoran/zoran_driver.c | 49 --
2 files changed, 22 in
buffer_size was not set when it should be.
Furthermore, use it instead of recalculate it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 ++
drivers/staging/media/zoran/zoran_driver.c | 9 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/
The structure tvnorm could be consified.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/videocodec.h | 2 +-
drivers/staging/media/zoran/zoran.h| 4 ++--
drivers/staging/media/zoran/zoran_card.c | 24 +++---
drivers/staging/media/zoran/zoran_device.c
The framebuffer support is obsolete, so let's reduce code size.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 4 -
drivers/staging/media/zoran/zoran_card.c | 6 --
drivers/staging/media/zoran/zoran_driver.c | 85 --
3 files changed, 95 del
This patchs adds a vb_queue without using it.
This reduce the final VB2 conversion patch.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Kconfig| 1 +
drivers/staging/media/zoran/zoran.h| 30 +++
drivers/staging/media/zoran/zoran_card.c | 7 +
drivers/stagin
Add TODO for "TRY_FMT cannot handle an invalid pixelformat"
We need to set pixelformat in some case.
We should also handle some minimum requirement.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
d
The zoran device only supports 32bit DMA address.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index dbdb1c4b0515..0a193283
Using video_drvdata() is proper and shorter than using directly
fh pointers.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 40 --
1 file changed, 14 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/dri
The codec_name could be const.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index 79783cbb919a..49a1d9e084a
Allocate the zoran structure with devm_ functions permit to simplify
code.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zor
The zoran driver miss some sanity checks, and this made v4l compliance
happy.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zo
Zoran is picky about jpeg data it accepts. At least it seems to not support COM
and APPn.
So until a way to filter data will be done, disable output.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 ++
drivers/staging/media/zoran/zoran_driver.c | 20 +++
This patch enables compilation of the zoran driver.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
index 25910221b100..965a8b0e6cf2 100644
--- a/drivers/staging/m
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index 61b4cfccc168..e50153218f72 100644
--- a/drive
This patch convert dprintk(debug) to pci_dbg.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 30 --
drivers/staging/media/zoran/zoran_card.h | 6 -
drivers/staging/media/zoran/zoran_device.c | 2 +-
drivers/staging/media/zoran/zoran_dri
This patch convert zoran to pci_irq functions.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
index 8be7f8f0
We need to get rid of zoran_fh, so let's change function arguments.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_driver.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_driver.c
b/drivers/staging/media/zoran/zor
Instead of using a fragile virt_to_bus, let's use proper DMA coherent
for the stat_com entry.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 2 ++
drivers/staging/media/zoran/zoran_card.c | 22 +++---
drivers/staging/media/zoran/zoran_device.c |
We need to get rid of zoran_fh, so move the v4l_settings directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 1 -
drivers/staging/media/zoran/zoran_driver.c | 38 ++
2 files changed, 17 insertions(+), 22 deletions(-)
The zoran driver give some debug information in procfs, but this is not
the right place.
So let's remove them, we will use debugfs later.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/Makefile | 2 +-
drivers/staging/media/zoran/zoran.h| 5 -
drivers/staging/med
Simply remove this broken reference
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_device.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/zoran/zoran_device.c
b/drivers/staging/media/zoran/zoran_device.c
index 04162be80420..79da964c678b 100644
Supporting overlay is not necessary today, so let's reduce the code size
by removing it.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 16 -
drivers/staging/media/zoran/zoran_card.c | 6 -
drivers/staging/media/zoran/zoran_device.c | 143 +
drivers/s
The VFL_TYPE_GRABBER type was removed, so let's use the new type.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/zoran/zoran_card.c
b/drivers/staging/media/zoran/zoran_card.c
in
We need to get rid of zoran_fh, so move the buffer_size directly in the
zoran structure.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran.h| 3 +-
drivers/staging/media/zoran/zoran_device.c | 3 +-
drivers/staging/media/zoran/zoran_driver.c | 62 +++--
This patch convert dprintk(warn) to pci_warn.
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 18 --
drivers/staging/media/zoran/zoran_device.c | 13 +++---
drivers/staging/media/zoran/zoran_driver.c | 29 +-
3 files changed, 14
This patch convert dprintk(info) to pci_info (or pci_dbg if the message
is not important).
Signed-off-by: Corentin Labbe
---
drivers/staging/media/zoran/zoran_card.c | 46 +++---
drivers/staging/media/zoran/zoran_device.c | 27 -
drivers/staging/media/zoran/zoran_dr
On 9/25/20 9:11 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote:
From: Coiby Xu
Sent: 24 September 2020 11:21
Use __8 to replace int and remove the unnecessary __bitwise type
attribute.
Found by sparse,
...
diff --git a/include/uapi/sound/asound.h b/include
On 9/25/20 9:07 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote:
On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote:
Use __8 to replace int and remove the unnecessary __bitwise type
attribute.
Found by sparse,
. . .
diff --git a/include/uapi/so
On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote:
From: Coiby Xu
Sent: 24 September 2020 11:21
Use __8 to replace int and remove the unnecessary __bitwise type attribute.
Found by sparse,
...
diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index 535a7229e1d9
On Thu, Sep 24, 2020 at 07:50:57AM -0500, Alex Elder wrote:
On 9/24/20 5:20 AM, Coiby Xu wrote:
This patch fix the following warnings from sparse,
You need to address Greg's comment.
But in general this looks good. I have one comment below, which
you can address in v2. If you (or others) di
On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote:
On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote:
Use __8 to replace int and remove the unnecessary __bitwise type attribute.
Found by sparse,
$ make C=2 drivers/staging/greybus/
drivers/staging/greybus/audio_topology.
As found earlier, there is a problem in the create_pagelist() function
that takes a pointer argument that either points into vmalloc space or
into user space, with the pointer value controlled by user space allowing
a malicious user to trick the driver into accessing the kernel instead.
Avoid this
My earlier patches caused some new sparse warnings, but it turns out
that a number of those are actual bugs, or at least suspicous code.
Adding __user annotations to the data structures that are defined in
uapi headers helps avoid the new warnings, but that causes a different
set of warnings to sh
On Wed, Sep 23, 2020 at 7:44 AM Greg Kroah-Hartman
wrote:
> and so on...
>
> Care to try a v2?
I had a look now and found the problem, as there are two drivers that I did not
have enabled but that need a trivial change to match my other modifications.
I'll send the new version in a bit, changes
64 matches
Mail list logo