Re: [PATCH] media: atomisp: Fixed error handling path

2020-09-28 Thread Souptick Joarder
Hi Dan, On Mon, Sep 28, 2020 at 2:08 PM Dan Carpenter wrote: > > On Sun, Sep 27, 2020 at 08:38:04PM +0530, Souptick Joarder wrote: > > Inside alloc_user_pages() based on flag value either pin_user_pages() > > or get_user_pages_fast() will be called. However, these API might fail. > > > > But

Re: kernel BUG at fs/erofs/inode.c:LINE!

2020-09-28 Thread Chao Yu
Hi syzbot administrator, CONFIG_EROFS_DEBUG was introduced for debug purpose during development, this should not be enabled on release version. Can you please turn off this config, and retest with erofs module? Thanks, On 2020/9/29 4:36, Gao Xiang wrote: Hi, On Mon, Sep 28, 2020 at

[PATCH v3 -next] binder: simplify the return expression of binder_mmap

2020-09-28 Thread Liu Shixin
Simplify the return expression. Signed-off-by: Liu Shixin --- v3: Add the change description. v2: Get rid of the "ret" and "failure string" variables. v1: Simplify the return expression. --- drivers/android/binder.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff

Re: [PATCH] staging: most: don't access hdm_ch before checking it valid

2020-09-28 Thread Jing Xiangfeng
On 2020/9/28 19:48, Dan Carpenter wrote: On Mon, Sep 28, 2020 at 06:48:38PM +0800, Jing Xiangfeng wrote: In try_start_dim_transfer(), pointer hdm_ch is accessed before checking. This may lead to a potential null pointer dereference. Fix this by dereferencing hdm_ch after calling BUG_ON().

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Kees Cook
On Mon, Sep 28, 2020 at 04:41:47PM -0600, Shuah Khan wrote: > On 9/26/20 10:29 AM, Kees Cook wrote: > > On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: > > > 7. Verified that the test module compiles in kunit env. and test > > >module can be loaded to run the test. > > > >

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Shuah Khan
On 9/28/20 3:17 PM, Joel Fernandes wrote: On Mon, Sep 28, 2020 at 01:34:31PM -0700, Kees Cook wrote: On Sun, Sep 27, 2020 at 07:35:26PM -0400, Joel Fernandes wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: This patch series is a result of discussion at the refcount_t BOF

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Shuah Khan
On 9/26/20 10:33 AM, Kees Cook wrote: On Fri, Sep 25, 2020 at 06:13:37PM -0600, Shuah Khan wrote: On 9/25/20 5:52 PM, Kees Cook wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: -- Addressed Kees's comments: 1. Non-atomic counters renamed to counter_simple32 and

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Shuah Khan
On 9/26/20 10:22 AM, Kees Cook wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: This patch series is a result of discussion at the refcount_t BOF the Linux Plumbers Conference. In this discussion, we identified a need for looking closely and investigating atomic_t usages in

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Shuah Khan
On 9/26/20 10:29 AM, Kees Cook wrote: On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: 7. Verified that the test module compiles in kunit env. and test module can be loaded to run the test. I meant write it using KUnit interfaces (e.g. KUNIT_EXPECT*(),

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Joel Fernandes
On Mon, Sep 28, 2020 at 01:34:31PM -0700, Kees Cook wrote: > On Sun, Sep 27, 2020 at 07:35:26PM -0400, Joel Fernandes wrote: > > On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: > > > This patch series is a result of discussion at the refcount_t BOF > > > the Linux Plumbers Conference.

Re: kernel BUG at fs/erofs/inode.c:LINE!

2020-09-28 Thread Gao Xiang
Hi, On Mon, Sep 28, 2020 at 12:27:24AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:d1d2220c Add linux-next specific files for 20200924 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=166cb7d990 > kernel

Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters

2020-09-28 Thread Kees Cook
On Sun, Sep 27, 2020 at 07:35:26PM -0400, Joel Fernandes wrote: > On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: > > This patch series is a result of discussion at the refcount_t BOF > > the Linux Plumbers Conference. In this discussion, we identified > > a need for looking closely

Paul McCann

2020-09-28 Thread dewiariani1981
Good Day We are a registered Private Loan Investment Company in the United Kingdom, we also registered with the Turkish British Chamber of Commerce and Industry (TBCCI) we have operations in Europe and Asia. We are seeking for beneficiaries who source for fund to expand/relocating their

Re: [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-28 Thread Hans Verkuil
On 28/09/2020 15:53, Laurent Pinchart wrote: > Hi Hans, > > On Mon, Sep 28, 2020 at 03:45:03PM +0200, Hans Verkuil wrote: >> On 25/09/2020 20:30, Corentin Labbe wrote: >>> Hello >>> >>> The zoran driver was removed in 5.3 >>> The main reason of the removing was lack of motivation to convert it to

Re: [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-28 Thread Laurent Pinchart
Hi Hans, On Mon, Sep 28, 2020 at 03:45:03PM +0200, Hans Verkuil wrote: > On 25/09/2020 20:30, Corentin Labbe wrote: > > Hello > > > > The zoran driver was removed in 5.3 > > The main reason of the removing was lack of motivation to convert it to > > VB2 > > Since I need it, I worked on bringing

Re: [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver

2020-09-28 Thread Hans Verkuil
Hi Corentin, On 25/09/2020 20:30, Corentin Labbe wrote: > Hello > > The zoran driver was removed in 5.3 > The main reason of the removing was lack of motivation to convert it to > VB2 > Since I need it, I worked on bringing it back. > > So the plan to achieve it was: > - clean up the coding

Re: [PATCH] staging: most: don't access hdm_ch before checking it valid

2020-09-28 Thread Dan Carpenter
On Mon, Sep 28, 2020 at 06:48:38PM +0800, Jing Xiangfeng wrote: > In try_start_dim_transfer(), pointer hdm_ch is accessed before checking. > This may lead to a potential null pointer dereference. Fix this by > dereferencing hdm_ch after calling BUG_ON(). > > Signed-off-by: Jing Xiangfeng > --- >

Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

2020-09-28 Thread Dan Scally
On 17/09/2020 11:33, Sakari Ailus wrote: >> +sensor_props[3] = PROPERTY_ENTRY_U32_ARRAY_LEN("data-lanes", >> + data_lanes, >> + >> (int)ssdb->lanes); >> +

[PATCH] staging: most: don't access hdm_ch before checking it valid

2020-09-28 Thread Jing Xiangfeng
In try_start_dim_transfer(), pointer hdm_ch is accessed before checking. This may lead to a potential null pointer dereference. Fix this by dereferencing hdm_ch after calling BUG_ON(). Signed-off-by: Jing Xiangfeng --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> Anyway, those are some ideas. Thanks for your comments Dan, Addressed your comments and resubmitted in /net/wireless Thanks Srini ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> It would be more common just to check for CONFIG_PURELIFI_AP in the source > file(s) instead of adding a synonym for it. Thanks for your comments Randy, Addressed your comments and resubmitted in /net/wireless Thanks Srini ___ devel mailing list

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> There's nothing in the "how to submit a driver/patch" documentation that > mentions that it has to go through staging first, does it? If so, that > needs to be changed... Thanks for the feedback Greg, Addressed your comments and resubmitted in /net/wireless Regards Srini

[PATCH] staging: vchiq: Fix list_for_each exit tests

2020-09-28 Thread Dan Carpenter
This code code here used to be list_for_each() and after the loop then the "entry" pointer was non-NULL if we found the correct entry or NULL if we couldn't find it. Then we changed the code to use list_for_each_entry() and so now the "entry" pointer is always non-NULL when we exit the loop. I

Re: [PATCH] media: atomisp: Fixed error handling path

2020-09-28 Thread Dan Carpenter
On Sun, Sep 27, 2020 at 08:38:04PM +0530, Souptick Joarder wrote: > Inside alloc_user_pages() based on flag value either pin_user_pages() > or get_user_pages_fast() will be called. However, these API might fail. > > But free_user_pages() called in error handling path doesn't bother > about return

kernel BUG at fs/erofs/inode.c:LINE!

2020-09-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d1d2220c Add linux-next specific files for 20200924 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=166cb7d990 kernel config: https://syzkaller.appspot.com/x/.config?x=254e028a642027c dashboard