Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-02 Thread Benjamin Poirier
On 2020-10-03 07:59 +0800, Coiby Xu wrote: > This fixes commit 0107635e15ac > ("staging: qlge: replace pr_err with netdev_err") which introduced an > build breakage of missing `struct ql_adapter *qdev` for some functions > and a warning of type mismatch with dumping enabled, i.e., > > $ make CFLAG

[driver-core:driver-core-testing] BUILD SUCCESS ee4906770ee931394179bcd42cabb196bc952276

2020-10-02 Thread kernel test robot
allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201002 x86_64 randconfig-a001-20201002 x86_64

[PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-02 Thread Coiby Xu
This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning of type mismatch with dumping enabled, i.e., $ make CFLAGS_MODULE="-DQL_ALL_DUMP -DQL_OB_DUMP -DQL_CB_DUMP \

[PATCH v2 1/3] staging: greybus: fix warnings about endianness detected by sparse

2020-10-02 Thread Coiby Xu
This patch fix the following warnings from sparse, $ make C=2 drivers/staging/greybus/ drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in assignment (different base types) drivers/staging/greybus/audio_module.c:222:25:expected restricted __le16 [usertype] data_cport dr

[PATCH v2 2/3] staging: greybus: codecs: use SNDRV_PCM_FMTBIT_S16_LE for format bitmask

2020-10-02 Thread Coiby Xu
snd_soc_pcm_stream.formats should use the bitmask SNDRV_PCM_FMTBIT_* instead of the sequential integers SNDRV_PCM_FORMAT_* as explained by commit e712bfca1ac1f63f622f87c2f33b57608f2a4d19 ("ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask"). Found by sparse, $ make C=2 drivers/staging/greyb

[PATCH v2 3/3] staging: greybus: use __force when assigning __u8 value to snd_ctl_elem_type_t

2020-10-02 Thread Coiby Xu
(struct gb_audio_ctl_elem_info*)->type has the type of __u8 so there is no concern about the byte order. __force is safe to use. Found by sparse, $ make C=2 drivers/staging/greybus/ drivers/staging/greybus/audio_topology.c:185:24: warning: cast to restricted snd_ctl_elem_type_t Suggested-by: Al

Re: [PATCH v3 -next] binder: simplify the return expression of binder_mmap

2020-10-02 Thread Martijn Coenen
Thanks! On Tue, Sep 29, 2020 at 3:30 AM Liu Shixin wrote: > > Simplify the return expression. > > Signed-off-by: Liu Shixin Acked-by: Martijn Coenen > --- > v3: Add the change description. > v2: Get rid of the "ret" and "failure string" variables. > v1: Simplify the return expression. > --- >

Re: [GIT PULL] IIO driver fixes for 5.9-rc8

2020-10-02 Thread pr-tracker-bot
The pull request you sent on Fri, 2 Oct 2020 16:20:11 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.9-rc8 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cc8ad8fa844aeae64c10f002b97a7c56619f1f57 Thank you! -- Deet-doot-do

Re: [PATCH v3 -next] binder: simplify the return expression of binder_mmap

2020-10-02 Thread Christian Brauner
On Tue, Sep 29, 2020 at 09:52:16AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin > --- Thanks! Acked-by: Christian Brauner ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproje

[GIT PULL] IIO driver fixes for 5.9-rc8

2020-10-02 Thread Greg KH
The following changes since commit 856deb866d16e29bd65952e0289066f6078af773: Linux 5.9-rc5 (2020-09-13 16:06:00 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.9-rc8 for you to fetch changes up to 52a035235ed5a1

Re: [PATCH v3 -next] binder: simplify the return expression of binder_mmap

2020-10-02 Thread Greg Kroah-Hartman
On Tue, Sep 29, 2020 at 09:52:16AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin > --- > v3: Add the change description. > v2: Get rid of the "ret" and "failure string" variables. > v1: Simplify the return expression. > --- > drivers/android/binder.c |

Re: [PATCH v3] media: atomisp: fixes build breakage for ISP2400 due to a cleanup

2020-10-02 Thread Andy Shevchenko
On Thu, Oct 1, 2020 at 6:55 PM Mauro Carvalho Chehab wrote: > Em Thu, 1 Oct 2020 18:50:12 +0300 > Andy Shevchenko escreveu: > > > On Thu, Oct 1, 2020 at 2:17 PM Mauro Carvalho Chehab > > wrote: > > > > > > A temporary var needed for building with ISP2400 was removed > > > by accident on a cleanu

[PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful

2020-10-02 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pci_err error message. Fix this and make the error message a little more meaningful. Signed-off-by: Colin Ian King --- drivers/staging/media/zoran/zoran_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/st

Re: [PATCH 3/3] media: zoran: fix mixed case on vars

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:15AM +0200, Mauro Carvalho Chehab wrote: > Use this small script to replace CamelCase and wrong case > on vars: > > > FILES=$(find "$1" -type f|grep -e '.c$' -e '.h$') > CAMEL_VARS=$(cat tags|perl -ne 'print "$1\n" if > (m/^(\w*[A-Z]\w*[a-z]\w*)\s/)') > for i in $CA

Re: [PATCH 2/3] media: zoran: get rid of an unused var

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:14AM +0200, Mauro Carvalho Chehab wrote: > The jpeg_error in lowercase is not used anywhere. Drop it. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/staging/media/zoran/zoran.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/