[staging:staging-testing] BUILD SUCCESS e1f13c879a7c21bd207dc6242455e8e3a1e88b40

2020-10-10 Thread kernel test robot
allnoconfig i386 randconfig-a005-20201010 i386 randconfig-a006-20201010 i386 randconfig-a001-20201010 i386 randconfig-a003-20201010 i386 randconfig-a004-20201010 i386 randconfig-a002-20201010 x86_64

Re: [PATCH RFC PKS/PMEM 09/58] drivers/gpu: Utilize new kmap_thread()

2020-10-10 Thread Ira Weiny
On Sat, Oct 10, 2020 at 12:03:49AM +0200, Daniel Vetter wrote: > On Fri, Oct 09, 2020 at 12:49:44PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > These kmap() calls in the gpu stack are localized to a single thread. > > To avoid the over head of global PKRS updates use the new kma

[PATCH] staging: comedi: ni_mio_common: Fix newline after dereference operator

2020-10-10 Thread Vasily Utkin
Fix newline after dereference operator detected by checkpatch. Signed-off-by: Vasily Utkin --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_

Re: [PATCH 2/8] staging: wfx: check memory allocation

2020-10-10 Thread Dan Carpenter
On Sat, Oct 10, 2020 at 04:18:11PM +0300, Dan Carpenter wrote: > On Sat, Oct 10, 2020 at 02:07:13PM +0200, Jérôme Pouiller wrote: > > On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or open att

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:24 +0800, Coiby Xu wrote: > On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote: > > On 2020-10-08 19:58 +0800, Coiby Xu wrote: > > > Initialize devlink health dump framework for the dlge driver so the > > > coredump could be done via devlink. > > > > > > Signed-off-b

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:00 +0800, Coiby Xu wrote: [...] > > > > Please also update drivers/staging/qlge/TODO accordingly. There is still > > a lot of debugging code IMO (the netif_printk statements - kernel > > tracing can be used instead of those) but this patch is a substantial > > improvement. > > Th

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Jérôme Pouiller
On Saturday 10 October 2020 14:40:34 CEST Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote: > > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > > > Jerome Pouiller writes: > > > > > > > From: Jérôme Pouiller > > > > > > > > Smatch complains: >

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:02 +0800, Coiby Xu wrote: [...] > > > + do { \ > > > + err = fill_seg_(fmsg, &dump->seg_hdr, dump->seg_regs); \ > > > + if (err) { \ > > > + kvfree(

Re: [PATCH 2/8] staging: wfx: check memory allocation

2020-10-10 Thread Dan Carpenter
On Sat, Oct 10, 2020 at 02:07:13PM +0200, Jérôme Pouiller wrote: > On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is s

Re: [PATCH 2/8] staging: wfx: check memory allocation

2020-10-10 Thread Jérôme Pouiller
On Friday 9 October 2020 20:51:01 CEST Kalle Valo wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > >

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote: > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > > Jerome Pouiller writes: > > > > > From: Jérôme Pouiller > > > > > > Smatch complains: > > > > > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() war

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Jérôme Pouiller
On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Smatch complains: > > > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn: > > potential NULL parameter dereference 'wvif' > >drivers/staging/wfx/da

Re: [PATCH RFC PKS/PMEM 10/58] drivers/rdma: Utilize new kmap_thread()

2020-10-10 Thread Bernard Metzler
-ira.we...@intel.com wrote: - >To: "Andrew Morton" , "Thomas Gleixner" >, "Ingo Molnar" , "Borislav >Petkov" , "Andy Lutomirski" , "Peter >Zijlstra" >From: ira.we...@intel.com >Date: 10/09/2020 09:52PM >Cc: "Ira Weiny" , "Mike Marciniszyn" >, "Dennis Dalessandro" >, "Doug Ledford" , >"Jas

Re: [PATCH v3 00/11] Introduce Simple atomic counters

2020-10-10 Thread Peter Zijlstra
On Fri, Oct 09, 2020 at 01:45:43PM -0700, Kees Cook wrote: > On Fri, Oct 09, 2020 at 09:37:46PM +0200, Peter Zijlstra wrote: > > On Fri, Oct 09, 2020 at 09:55:55AM -0600, Shuah Khan wrote: > > > Simple atomic counters api provides interfaces for simple atomic counters > > > that just count, and don

Re: [PATCH v3] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2020 at 11:35:19AM +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2020 at 01:59:32PM +0530, Anant Thazhemadam wrote: > > While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if > > wMaxPacketSize = 0 for the endpoints found. > > > > Some devices have isochronous

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Kconfig| 1 + drivers/

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 04:48:09PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: $ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 05:01:26PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: The debugging code in the following ifdef land - QL_ALL_DUMP - QL_REG_DUMP - QL_DEV_DUMP - QL_CB_DUMP - QL_IB_DUMP - QL_OB_DUMP becomes unnecessary because, - Device status and ge

Re: [PATCH v3] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2020 at 01:59:32PM +0530, Anant Thazhemadam wrote: > While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if > wMaxPacketSize = 0 for the endpoints found. > > Some devices have isochronous endpoints that have wMaxPacketSize = 0 > (as required by the USB-2 spec). > Ho

[PATCH v3] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Anant Thazhemadam
While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if wMaxPacketSize = 0 for the endpoints found. Some devices have isochronous endpoints that have wMaxPacketSize = 0 (as required by the USB-2 spec). However, since this doesn't apply here, wMaxPacketSize = 0 can be considered to b

Re: [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Anant Thazhemadam
On 10/10/20 1:39 pm, Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2020 at 07:29:13AM +0530, Anant Thazhemadam wrote: >> Hi, >> >> On 10-10-2020 12:30, Greg Kroah-Hartman wrote: >>> On Fri, Oct 09, 2020 at 09:50:29PM +0530, Anant Thazhemadam wrote: While finding usb endpoints in vmk80xx_find_u

Re: [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2020 at 07:29:13AM +0530, Anant Thazhemadam wrote: > Hi, > > On 10-10-2020 12:30, Greg Kroah-Hartman wrote: > > On Fri, Oct 09, 2020 at 09:50:29PM +0530, Anant Thazhemadam wrote: > >> While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if > >> wMaxPacketSize = 0 for

Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > The debugging code in the following ifdef land > - QL_ALL_DUMP > - QL_REG_DUMP > - QL_DEV_DUMP > - QL_CB_DUMP > - QL_IB_DUMP > - QL_OB_DUMP > > becomes unnecessary because, > - Device status and general registers can be obtained by ethtool. > -

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > $ devlink health dump show DEVICE reporter coredump -p -j > { > "Core Registers": { > "segment": 1, > "values": [ > 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Kconfig| 1 + > drivers/staging/qlge/Makefile | 2 +- > drivers/staging/

Re: [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Anant Thazhemadam
Hi, On 10-10-2020 12:30, Greg Kroah-Hartman wrote: > On Fri, Oct 09, 2020 at 09:50:29PM +0530, Anant Thazhemadam wrote: >> While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if >> wMaxPacketSize = 0 for the endpoints found. >> >> Some devices have isochronous endpoints that have w

Re: [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found

2020-10-10 Thread Greg Kroah-Hartman
On Fri, Oct 09, 2020 at 09:50:29PM +0530, Anant Thazhemadam wrote: > While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if > wMaxPacketSize = 0 for the endpoints found. > > Some devices have isochronous endpoints that have wMaxPacketSize = 0 > (as required by the USB-2 spec). > Ho