Re: [PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues

2020-10-28 Thread Greg KH
On Wed, Oct 28, 2020 at 09:28:37PM +, Manuel Palenzuela wrote: > Fixed two cases where the if-statement coding style wasn't following the > guidelines. (rtw_cmd.c) > Please properly wrap your changelog comments at 72 columns like your editor asked you to :) And what is with the file name in

Re: [PATCH v2] staging: fieldbus: Use %pM format specifier for MAC addresses

2020-10-28 Thread Sven Van Asbroeck
Hi Andy, thank you for the patch ! On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko wrote: > > + return snprintf(buf, max_size, "%pM\n", response.addr); Judging from a few Outreachy patches that have hit my inbox, snprintf() is considered unsafe in a sysfs_get callback. It should be replace

[PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues

2020-10-28 Thread Manuel Palenzuela
Fixed two cases where the if-statement coding style wasn't following the guidelines. (rtw_cmd.c) Signed-off-by: Manuel Palenzuela --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/driv

[staging:staging-testing] BUILD SUCCESS c2ec4a6e5410096d41bec795008a76770d9962dc

2020-10-28 Thread kernel test robot
-a002-20201026 i386 randconfig-a003-20201026 i386 randconfig-a005-20201026 i386 randconfig-a001-20201026 i386 randconfig-a006-20201026 i386 randconfig-a004-20201026 i386 randconfig-a002-20201028 i386

Re: [RFC] wimax: move out to staging

2020-10-28 Thread Arnd Bergmann
On Wed, Oct 28, 2020 at 11:34 AM Dan Carpenter wrote: > On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > There are no known users of this driver as of October 2020, and it will > > be removed unless someone turns out to still need it in future release

[PATCH -next] staging: rtl8192u: fix wrong judgement in rtl8192_rx_isr

2020-10-28 Thread Zhang Qilong
The 'EPERM' cannot appear in the previous path, we should use '-EPERM' to check it. For example: Call trace: ->rtl8192_rx_isr ->usb_submit_urb ->usb_hcd_submit_urb ->rh_urb_enqueue ->rh_queue_status ->usb_hcd_link_urb_to_ep Signed-off-by: Zh

Re: [RFC] wimax: move out to staging

2020-10-28 Thread Dan Carpenter
On Tue, Oct 27, 2020 at 10:20:13PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > There are no known users of this driver as of October 2020, and it will > be removed unless someone turns out to still need it in future releases. > > According to https://en.wikipedia.org/wiki/List_of_WiMAX

[PATCH] staging: ks7010: fix missing destroy_workqueue() on error in ks7010_sdio_probe

2020-10-28 Thread Qinglang Miao
Add the missing destroy_workqueue() before return from ks7010_sdio_probe in the error handling case. Signed-off-by: Qinglang Miao --- drivers/staging/ks7010/ks7010_sdio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/stagin