Re: [PATCH v2 1/2] dt-bindings: pinctrl: rt2880: add binding document

2020-12-10 Thread Sergio Paracuellos
Hi Rob, On Thu, Dec 10, 2020 at 2:47 PM Rob Herring wrote: > > On Tue, Dec 08, 2020 at 08:55:22AM +0100, Sergio Paracuellos wrote: > > The commit adds rt2880 compatible node in binding document. > > > > Signed-off-by: Sergio Paracuellos > > --- > > .../pinctrl/ralink,rt2880-pinmux.yaml

[driver-core:driver-core-testing] BUILD SUCCESS WITH WARNING 2a0387e8128ae0c3de9ff976bc25afaae3d4a916

2020-12-10 Thread kernel test robot
randconfig-a004-20201209 i386 randconfig-a005-20201209 i386 randconfig-a001-20201209 i386 randconfig-a002-20201209 i386 randconfig-a006-20201209 i386 randconfig-a003-20201209 i386 randconfig-a001-20201210

Re: [PATCH v2 16/19] dt-bindings: media: Add A83T MIPI CSI-2 bindings documentation

2020-12-10 Thread Rob Herring
On Sat, 28 Nov 2020 15:28:36 +0100, Paul Kocialkowski wrote: > This introduces YAML bindings documentation for the A83T MIPI CSI-2 > controller. > > Signed-off-by: Paul Kocialkowski > --- > .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 147 ++ > 1 file changed, 147

Re: [PATCH v1 2/2] Staging: silabs si4455 serial driver: docs device tree binding

2020-12-10 Thread Rob Herring
On Thu, 10 Dec 2020 12:21:56 +, József Horváth wrote: > add: device tree binding schema > > Signed-off-by: József Horváth > --- > .../bindings/serial/silabs,si4455.yaml| 53 +++ > MAINTAINERS | 2 +- > 2 files changed, 54

Re: [PATCH v1 2/2] Staging: silabs si4455 serial driver: docs device tree binding

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 12:21:56PM +, József Horváth wrote: > add: device tree binding schema For the subject, follow conventions of the directory. Something like: dt-bindings: serial: Add SiLabs SI4455 schema > Signed-off-by: József Horváth > --- > .../bindings/serial/silabs,si4455.yaml

Re: [PATCH v1 1/2] Staging: silabs si4455 serial driver: fix directory structure and coding style

2020-12-10 Thread Dan Carpenter
On Thu, Dec 10, 2020 at 12:20:59PM +, József Horváth wrote: > fix: coding style > fix: error checking > remove: doc silabs,si4455.txt > > Signed-off-by: József Horváth Just fold (combine) this check in with the first. This is much better but there are still 54 checkpatch warnins. total: 0

Re: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi I do not have rtl8712 hardware So that I would remain this code and give up my patch Thank you ! -原始邮件- 发件人: "Dan Carpenter" 发送时间: 2020-12-10 23:16:31 (星期四) 收件人: shaojie.d...@isrc.iscas.ac.cn 抄送: larry.fin...@lwfinger.net, florian.c.schilha...@googlemail.com,

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread Dan Carpenter
On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.d...@isrc.iscas.ac.cn wrote: > Hi > > > This function should not be calling register_netdev(). What does that > have to do with firmware? It should also not free_netdev() because > that will just lead to a use after free in the caller. > >

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi Thanks ! I will modify sign name correctly later Sorry to say that I have no rtl8712 hardware, so that I could not test it. From Dan Carpenter's email reply, "free_netdev(adapter-pnetdev)" function may cause use after free issue So that I reply email to ensure if this return value should

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi This function should not be calling register_netdev(). What does that have to do with firmware? It should also not free_netdev() because that will just lead to a use after free in the caller. -- check code history author changed synchronous firmware loading to asynchronous firmware

Re: [PATCH v2 1/2] dt-bindings: pinctrl: rt2880: add binding document

2020-12-10 Thread Rob Herring
On Tue, Dec 08, 2020 at 08:55:22AM +0100, Sergio Paracuellos wrote: > The commit adds rt2880 compatible node in binding document. > > Signed-off-by: Sergio Paracuellos > --- > .../pinctrl/ralink,rt2880-pinmux.yaml | 70 +++ > 1 file changed, 70 insertions(+) > create

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread 'Greg Kroah-Hartman'
On Thu, Dec 10, 2020 at 12:20:10PM +, József Horváth wrote: > I send this again, because my original mail content was corrupted. > > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. > > Signed-off-by: József Horváth > --- >

Re: [PATCH v1 1/2] Staging: silabs si4455 serial driver: fix directory structure and coding style

2020-12-10 Thread 'Greg Kroah-Hartman'
On Thu, Dec 10, 2020 at 12:20:59PM +, József Horváth wrote: > fix: coding style > fix: error checking > remove: doc silabs,si4455.txt What does all of this mean? Please read the documentation for how to write an effective changelog text, and where to put the "changes from the first version"

[PATCH v1 2/2] Staging: silabs si4455 serial driver: docs device tree binding

2020-12-10 Thread József Horváth
add: device tree binding schema Signed-off-by: József Horváth --- .../bindings/serial/silabs,si4455.yaml| 53 +++ MAINTAINERS | 2 +- 2 files changed, 54 insertions(+), 1 deletion(-) create mode 100644

[PATCH v1 1/2] Staging: silabs si4455 serial driver: fix directory structure and coding style

2020-12-10 Thread József Horváth
fix: coding style fix: error checking remove: doc silabs,si4455.txt Signed-off-by: József Horváth --- .../bindings/staging/serial/silabs,si4455.txt | 39 - MAINTAINERS | 7 + drivers/staging/Kconfig | 2 - drivers/staging/Makefile

[PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread József Horváth
I send this again, because my original mail content was corrupted. This is a serial port driver for Silicon Labs Si4455 Sub-GHz transciver. Signed-off-by: József Horváth --- .../bindings/staging/serial/silabs,si4455.txt | 39 + drivers/staging/Kconfig |2 +

Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 10:06:57AM +, Chris Bloomfield wrote: > Fix a coding style issue as identified by checkpatch.pl > > Signed-off-by: Chris Bloomfield > --- > drivers/staging/ralink-gdma/ralink-gdma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue

2020-12-10 Thread Chris Bloomfield
Fix a coding style issue as identified by checkpatch.pl Signed-off-by: Chris Bloomfield --- drivers/staging/ralink-gdma/ralink-gdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c index

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread Dan Carpenter
On Wed, Dec 09, 2020 at 07:41:53PM +, József Horváth wrote: > > > +static int si4455_get_part_info(struct uart_port *port, > > > + struct si4455_part_info *result) > > > +{ > > > + int ret; > > > + u8 dataOut[] = { SI4455_CMD_ID_PART_INFO }; > > > +