Re: [PATCH v3 08/15] dt-bindings: media: Add A31 MIPI CSI-2 bindings documentation

On Mon, Dec 14, 2020 at 12:35:09PM +0100, Maxime Ripard wrote: > On Fri, Dec 11, 2020 at 04:57:01PM +0100, Paul Kocialkowski wrote: > > This introduces YAML bindings documentation for the A31 MIPI CSI-2 > > controller. > > > > Signed-off-by: Paul Kocialkowski > > --- > > .../media/allwinner,sun6

Re: [PATCH v3 06/15] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port

On Fri, 11 Dec 2020 16:56:59 +0100, Paul Kocialkowski wrote: > The A31 CSI controller supports two distinct input interfaces: > parallel and an external MIPI CSI-2 bridge. The parallel interface > is often connected to a set of hardware pins while the MIPI CSI-2 > bridge is an internal FIFO-ish lin

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

On Mon, Dec 14, 2020 at 08:06:25AM -0500, Konstantin Ryabitsev wrote: On Mon, Dec 14, 2020 at 02:07:11PM +0300, Dan Carpenter wrote: On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > Hi Sasha, > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > From: "Andrea Parri

Re: [PATCH] media: allegro: Fix use after free on error

On Mon, 14 Dec 2020 14:54:47 +0300, Dan Carpenter wrote: > The "channel" is added to the "dev->channels" but then if > v4l2_m2m_ctx_init() fails then we free "channel" but it's still on the > list so it could lead to a use after free. Let's not add it to the > list until after v4l2_m2m_ctx_init()

Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

On Mon, Dec 14, 2020 at 11:53:04AM +, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:02 > > > > Logical continuations should be on the previous line > > > > Co-developed-by: Andrey Khlopkov > > Signed-off-by: Andrey Khlopkov > > Signed-off-by: Philipp Gerlesbe

Re: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

On Mon, Dec 14, 2020 at 11:49:56AM +, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:04 > > > > You can sum up the two lines, because the maximum line length of > > 100 columns is not exceeded. > > IIRC the 80 column limit is preferred. Not anymore, checkpatch

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

On Mon, Dec 14, 2020 at 02:07:11PM +0300, Dan Carpenter wrote: > On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > > Hi Sasha, > > > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > > From: "Andrea Parri (Microsoft)" > > > > > > [ Upstream commit 3b8c72d076c42bf27

[PATCH] media: allegro: Fix use after free on error

The "channel" is added to the "dev->channels" but then if v4l2_m2m_ctx_init() fails then we free "channel" but it's still on the list so it could lead to a use after free. Let's not add it to the list until after v4l2_m2m_ctx_init() succeeds. Fixes: cc62c74749a3 ("media: allegro: add missed check

[PATCH] media: atomisp: Fix use after free in atomisp_alloc_css_stat_bufs()

The "s3a_buf" is freed along with all the other items on the "asd->s3a_stats" list. It leads to a double free and a use after free. Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"") Signed-off-by: Dan Carpenter --- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 4 +---

RE: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

From: Philipp Gerlesberger > Sent: 14 December 2020 11:02 > > Logical continuations should be on the previous line > > Co-developed-by: Andrey Khlopkov > Signed-off-by: Andrey Khlopkov > Signed-off-by: Philipp Gerlesberger > --- > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4

RE: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

From: Philipp Gerlesberger > Sent: 14 December 2020 11:04 > > You can sum up the two lines, because the maximum line length of > 100 columns is not exceeded. IIRC the 80 column limit is preferred. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK

Re: [PATCH v3 13/15] media: sunxi: Add support for the A83T MIPI CSI-2 controller

On Fri, Dec 11, 2020 at 04:57:06PM +0100, Paul Kocialkowski wrote: > The A83T supports MIPI CSI-2 with a composite controller, covering > both the protocol logic and the D-PHY implementation. This controller > seems to be found on the A83T only and probably was abandoned since. > > This implementa

Re: [PATCH v3 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

On Fri, Dec 11, 2020 at 04:57:02PM +0100, Paul Kocialkowski wrote: > +#define sun6i_mipi_csi2_subdev_video(subdev) \ > + container_of(subdev, struct sun6i_mipi_csi2_video, subdev) > + > +#define sun6i_mipi_csi2_video_dev(video) \ > + container_of(video, struct sun6i_mipi_csi2_dev, video) I

Re: [PATCH v3 08/15] dt-bindings: media: Add A31 MIPI CSI-2 bindings documentation

On Fri, Dec 11, 2020 at 04:57:01PM +0100, Paul Kocialkowski wrote: > This introduces YAML bindings documentation for the A31 MIPI CSI-2 > controller. > > Signed-off-by: Paul Kocialkowski > --- > .../media/allwinner,sun6i-a31-mipi-csi2.yaml | 149 ++ > 1 file changed, 149 inserti

Re: [PATCH v3 07/15] media: sun6i-csi: Add support for MIPI CSI-2 bridge input

On Fri, Dec 11, 2020 at 04:57:00PM +0100, Paul Kocialkowski wrote: > The A31 CSI controller supports a MIPI CSI-2 bridge input, which has > its own dedicated port in the fwnode graph. > > Support for this input is added with this change: > - two pads are defined for the media entity instead of one

[PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH v2 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- ...

[PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 inserti

[PATCH v2 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- ...

[PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 inserti

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > Hi Sasha, > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > From: "Andrea Parri (Microsoft)" > > > > [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] > > FYI, we found that this commit introduced a re

[PATCH v2 08/12] media: atomisp: Delete braces

WARNING:BRACES: braces {} are not necessary for single statement blocks Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drive

[PATCH v2 05/12] media: atomisp: Fix overlong line

Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/m

[PATCH v2 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning

Use the automatically defined __func__ macro instead of the function name, so it stays correct when the function is renamed. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8 +++

[PATCH v2 07/12] media: atomisp: Fix funciton decleration

Write return_type, function_name and parameters in one line because lines should not end with a '(' [OPEN_ENDED_LINE] Write open brace ’{’ on the next line to fix OPEN_BRACE Error Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/st

[PATCH v2 06/12] media: atomisp: Remove defines

Remov defines, they don't make sense. The programmer should know what things need to be static and what not. Also leave "inline" out and let the compiler decide Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime

[PATCH v2 02/12] media: atomisp: Fix Block Comments

Block comments should use * on subsequent lines and should use a trailing */ on a separate line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++-- 1 file changed, 3 ins

[PATCH v2 04/12] media: atomisp: Fix OPEN_ENDED_LINE

Lines should not end with a '(' Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/ato

[PATCH v2 01/12] media: atomisp: Convert comments to C99 initializers

The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Also remove all the false, 0, and NULL members. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src/rmgr

[PATCH v2 00/12] media: atomisp: Codingstyle

Hello! This series fix some codingstyle errors in the files rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c in the drivers/staging/media area. V2: [Patch 1/12] Also remove NULL, 0 and false members to make it C99 standard comform. [Patch 6/12] Checkpatch throws COMPLEX_MAC

Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls

On Fri, Dec 11, 2020 at 08:29:22PM +0800, wanghai (M) wrote: > > 在 2020/12/8 17:35, Johan Hovold 写道: > > On Sat, Dec 05, 2020 at 06:38:27PM +0800, Wang Hai wrote: > >> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an > >> error > >> will be returned directly, which will cau

Re: [PATCH 0/8] pinctrl: ralink: rt2880: Some minimal clean ups

On Mon, Dec 14, 2020 at 10:02 AM Linus Walleij wrote: > > On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos > wrote: > > > After this driver was moved from staging into pinctrl subsytems > > some reviews for bindigns and driver itself comes from Ron Herring > > and Dan Carpenter. Get rid of all

Re: [PATCH 0/8] pinctrl: ralink: rt2880: Some minimal clean ups

On Sun, Dec 13, 2020 at 5:17 PM Sergio Paracuellos wrote: > After this driver was moved from staging into pinctrl subsytems > some reviews for bindigns and driver itself comes from Ron Herring > and Dan Carpenter. Get rid of all the comments to properly be in > a good shape before merge window.