Re: [PATCH v6 3/7] phy: phy-hi3670-usb3: move driver from staging into phy

2021-02-03 Thread Vinod Koul
On 27-01-21, 20:08, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. I guess Greg will pick this, so: Acked-By: Vinod Koul -- ~Vinod

Re: [PATCH v4 0/5] Promote Hikey 970 USB phy out of staging

2021-02-03 Thread Vinod Koul
On 26-01-21, 18:49, Greg Kroah-Hartman wrote: > On Tue, Jan 19, 2021 at 11:44:38AM +0100, Mauro Carvalho Chehab wrote: > > Hi Vinod/Rob, > > > > This series moves the Hikey 970 USB PHY driver out of staging. > > > > Patches 1 to 4 contain the fixes from staging. Patch 5 moves the > > driver

Re: [PATCH v4 5/5] phy: phy-hi3670-usb3: move driver from staging into phy

2021-02-03 Thread Vinod Koul
On 19-01-21, 11:44, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. Acked-By: Vinod Koul I think it makes sense if Greg applies this as well -- ~Vinod

[PATCH] media: atomisp: Remove unneeded return variable

2021-02-03 Thread Yang Li
This patch removes unneeded return variables, using only '0' instead. It fixes the following warning detected by coccinelle: ./drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8: Unneeded variable: "err". Return "0" on line 44 Reported-by: Abaci Robot Signed-off-by: Yang Li ---

[driver-core:readfile 2/4] arch/arm64/include/asm/unistd32.h:894:23: error: array index in initializer exceeds array bounds

2021-02-03 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git readfile head: 79053a7818bb1c1bdf529d5961094421fa2f2ff0 commit: df9ec8350df39afbf14483bb65e9f80d829d037f [2/4] arch: wire up the readfile syscall config: arm64-randconfig-r026-20210202 (attached as .config)

Re: [bug report] staging: qlge: Initialize devlink health dump framework

2021-02-03 Thread Coiby Xu
On Wed, Feb 03, 2021 at 05:36:01PM +0300, Dan Carpenter wrote: On Wed, Feb 03, 2021 at 09:45:51PM +0800, Coiby Xu wrote: Hi Dan, On Wed, Feb 03, 2021 at 12:42:50PM +0300, Dan Carpenter wrote: > Hello Coiby Xu, > > The patch 953b94009377: "staging: qlge: Initialize devlink health > dump

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
> Do you really not have a last name, like Cher? Exactly, my legal name only has first name. > > We generally want people to send these as separate patches. > > But in this case, we're just going to delete the driver. Don't bother > sending cleanups for this because it will be deleted soon. >

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
> > - Your patch did many different things all at once, making it difficult > to review. All Linux kernel patches need to only do one thing at a > time. If you need to do multiple things (such as clean up all coding > style issues in a file/driver), do it in a sequence of patches, each > one doing

[PATCH v3 6/7] drivers/staging/rtl8188eu: convert event_seq to use seqnum_ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert it to use seqnum_ops. event_seq atomic_t variables are atomic counters. Convert them to use seqnum_ops. Signed-off-by: Shuah Khan ---

[PATCH v3 5/7] drivers/staging/rtl8723bs: convert event_seq to use seqnum_ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert it to use seqnum_ops. event_seq atomic_t variables are atomic counters. Convert them to use seqnum_ops. Signed-off-by: Shuah Khan ---

[PATCH v3 7/7] kobject: convert uevent_seqnum to seqnum_ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert uevent_seqnum atomic counter to use seqnum_ops. Signed-off-by: Shuah Khan --- include/linux/kobject.h | 3 ++- kernel/ksysfs.c | 3 ++-

[PATCH v3 4/7] drivers/acpi/apei: convert seqno to seqnum_ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert seqno atomic counter to use seqnum_ops. Signed-off-by: Shuah Khan --- drivers/acpi/apei/ghes.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 2/7] selftests: lib:test_seqnum_ops: add new test for seqnum_ops

2021-02-03 Thread Shuah Khan
Add a new selftest for testing seqnum_ops. This test loads test_seqnum_ops test module and unloads it. The test module runs tests and prints results to dmesg. Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. There are a

[PATCH v3 3/7] drivers/acpi: convert seqno to use seqnum_ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters leveraging atomic_t and atomic64_t ops underneath. Convert seqno atomic counter to use seqnum_ops. Signed-off-by: Shuah Khan --- drivers/acpi/acpi_extlog.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters. There are a number of atomic_t usages in the kernel where atomic_t api is used for counting sequence numbers and other statistical counters. Several of these usages, convert atomic_read() and atomic_inc_return() return

[PATCH v3 0/7] Introduce Sequence Number Ops

2021-02-03 Thread Shuah Khan
Sequence Number api provides interfaces for unsigned atomic up counters. There are a number of atomic_t usages in the kernel where atomic_t api is used for counting sequence numbers and other statistical counters. Several of these usages, convert atomic_read() and atomic_inc_return() return

[PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
- fix "multiple blank lines" issues. - fix a couple of parenthesis alignment issues. - fix no space before parenthesis issue. - fix no blank line after declaration. compile tested only (on next-20210202). Signed-off-by: Ayush --- drivers/staging/wimax/i2400m/debugfs.c | 20 +---

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 03:40:06PM +, Ayush wrote: > > > > - Your patch did many different things all at once, making it difficult > > to review. All Linux kernel patches need to only do one thing at a > > time. If you need to do multiple things (such as clean up all coding > > style issues in

Re: [bug report] staging: qlge: Initialize devlink health dump framework

2021-02-03 Thread Dan Carpenter
On Wed, Feb 03, 2021 at 09:45:51PM +0800, Coiby Xu wrote: > Hi Dan, > > > On Wed, Feb 03, 2021 at 12:42:50PM +0300, Dan Carpenter wrote: > > Hello Coiby Xu, > > > > The patch 953b94009377: "staging: qlge: Initialize devlink health > > dump framework" from Jan 23, 2021, leads to the following

Re:read

2021-02-03 Thread Ms. Reem
Hello, My name is Ms. Reem Ebrahim Al-Hashimi, I am the "Minister of state and Petroleum" also "Minister of State for International Cooperation" in UAE. I write to you on behalf of my other "three (3) colleagues" who has approved me to solicit for your "partnership in claiming of {us$47=Million}"

Re: [PATCH][next] staging: qlge: fix read of an uninitialized pointer

2021-02-03 Thread Coiby Xu
On Wed, Feb 03, 2021 at 01:38:34PM +, Colin King wrote: From: Colin Ian King Currently the pointer 'reporter' is not being initialized and is being read in a netdev_warn message. The pointer is not used and is redundant, fix this by removing it and replacing the reference to it with

Re: [bug report] staging: qlge: Initialize devlink health dump framework

2021-02-03 Thread Coiby Xu
Hi Dan, On Wed, Feb 03, 2021 at 12:42:50PM +0300, Dan Carpenter wrote: Hello Coiby Xu, The patch 953b94009377: "staging: qlge: Initialize devlink health dump framework" from Jan 23, 2021, leads to the following static checker warning: drivers/staging/qlge/qlge_devlink.c:163

[PATCH][next] staging: qlge: fix read of an uninitialized pointer

2021-02-03 Thread Colin King
From: Colin Ian King Currently the pointer 'reporter' is not being initialized and is being read in a netdev_warn message. The pointer is not used and is redundant, fix this by removing it and replacing the reference to it with priv->reporter instead. Addresses-Coverity: ("Uninitialized

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Dan Carpenter
Do you really not have a last name, like Cher? On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote: > - fix "multiple blank lines" issues. > - fix a couple of parenthesis alignment issues. > - fix no space before parenthesis issue. > - fix no blank line after declaration. > We generally want

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote: > - fix "multiple blank lines" issues. > - fix a couple of parenthesis alignment issues. > - fix no space before parenthesis issue. > - fix no blank line after declaration. > > compile tested only (on next-20210202). > > Signed-off-by: Ayush

Re: [PATCH 05/13] staging: nvec: Switch from strlcpy to strscpy

2021-02-03 Thread Marc Dietrich
Hi Kumar, On Sun, 31 Jan 2021, Kumar Kartikeya Dwivedi wrote: strlcpy is marked as deprecated in Documentation/process/deprecated.rst, and there is no functional difference when the caller expects truncation (when not checking the return value). strscpy is relatively better as it also avoids

[bug report] staging: qlge: Initialize devlink health dump framework

2021-02-03 Thread Dan Carpenter
Hello Coiby Xu, The patch 953b94009377: "staging: qlge: Initialize devlink health dump framework" from Jan 23, 2021, leads to the following static checker warning: drivers/staging/qlge/qlge_devlink.c:163 qlge_health_create_reporters() error: uninitialized symbol 'reporter'.