Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Masahiro Yamada
On Fri, Feb 5, 2021 at 6:54 PM Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:15PM +0800, Yicong Yang wrote: > > From: Junhao He > > > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > > settings from Kconfig when traversing subdirectories. > > Again, explain _why_. > > Please

Re: [PATCH] staging: rtl8188eu: Add Edimax EW-7811UN V2 to device table

2021-02-05 Thread Larry Finger
On 2/4/21 2:52 AM, Martin Kaiser wrote: The Edimax EW-7811UN V2 uses an RTL8188EU chipset and works with this driver. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c

Re: [PATCH v4 18/21] mfd: hi6421-spmi-pmic: move driver from staging

2021-02-05 Thread Rob Herring
On Tue, Jan 19, 2021 at 05:10:44PM +0100, Mauro Carvalho Chehab wrote: > This driver is ready for mainstream. So, move it out of staging. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 135 + > MAINTAINERS

Re: [PATCH v4 18/21] mfd: hi6421-spmi-pmic: move driver from staging

2021-02-05 Thread Rob Herring
On Tue, Jan 19, 2021 at 05:10:44PM +0100, Mauro Carvalho Chehab wrote: > This driver is ready for mainstream. So, move it out of staging. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 135 + > MAINTAINERS

Re: [PATCH v4 17/21] spmi: hisi-spmi-controller: move driver from staging

2021-02-05 Thread Rob Herring
On Tue, Jan 19, 2021 at 05:10:43PM +0100, Mauro Carvalho Chehab wrote: > The Hisilicon 6421v600 SPMI driver is ready for mainstream. > > So, move it from staging. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../spmi/hisilicon,hisi-spmi-controller.yaml | 75 > MAINTAINERS

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-05 Thread Luck, Tony
On Fri, Feb 05, 2021 at 01:03:18PM -0700, Shuah Khan wrote: > On 2/5/21 2:58 AM, Greg KH wrote: > > On Wed, Feb 03, 2021 at 11:11:57AM -0700, Shuah Khan wrote: > > > +static inline u32 seqnum32_inc(struct seqnum32 *seq) > > > +{ > > > + atomic_t val = ATOMIC_INIT(seq->seqnum); > > > + > > > + seq->

Re: [PATCH v4 5/5] phy: phy-hi3670-usb3: move driver from staging into phy

2021-02-05 Thread Rob Herring
On Tue, 19 Jan 2021 11:44:43 +0100, Mauro Carvalho Chehab wrote: > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > for mainstream. Mode it from staging into the main driver's > phy/ directory. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../bindings/phy/hisilicon,hi3670-usb3.yaml

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Bjorn Helgaas
On Fri, Feb 05, 2021 at 10:28:32AM -0800, Guenter Roeck wrote: > On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: > > From: Junhao He > > > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > > settings from Kconfig when traversing subdirectories. > > > > Suggested-by:

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-05 Thread Shuah Khan
On 2/5/21 2:58 AM, Greg KH wrote: On Wed, Feb 03, 2021 at 11:11:57AM -0700, Shuah Khan wrote: +static inline u32 seqnum32_inc(struct seqnum32 *seq) +{ + atomic_t val = ATOMIC_INIT(seq->seqnum); + + seq->seqnum = (u32) atomic_inc_return(&val); + if (seq->seqnum >= UINT_MAX) +

Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Guenter Roeck
On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang Wh

[PATCH] media: intel-ipu3: Specify CCM values precision

2021-02-05 Thread Jean-Michel Hautbois
When trying to convert a CCM matrix for IPU3, extreme values for the Color Correction Matrix. Specify the precision to ease userspace integration. Signed-off-by: Jean-Michel Hautbois --- drivers/staging/media/ipu3/include/intel-ipu3.h | 14 -- 1 file changed, 8 insertions(+), 6 delet

Re: [PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread kernel test robot
Hi Mayank, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Mayank-Suman/staging-fbtft-replaced-udelay-with-usleep_range/20210205-171807 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

2021-02-05 Thread Robert Foss
Hey Xin, On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > Add MIPI rx DPI input support > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 326 > -- > drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +- > 2

Re: [PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value

2021-02-05 Thread Xin Ji
On Thu, Feb 04, 2021 at 01:28:30PM +0100, Robert Foss wrote: > Hi Xin, > > On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > > > At some time, the original code may return non zero value, force return 0 > > if operation finished > > Missing "." at end of line. Hi Rob, OK, thanks, I'll add it in th

Re: [PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread kernel test robot
Hi Mayank, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Mayank-Suman/staging-fbtft-replaced-udelay-with-usleep_range/20210205-171807 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-05 Thread Xin Ji
On Fri, Feb 05, 2021 at 12:30:45PM +0100, Robert Foss wrote: > Hey Xin, > > Thanks for the quick response. I think this is ok. > > But going forward it is easier for maintainers to keep track of > patches if they're submitted with a version tag. [PATCH] -> [PATCH v2] > -> [PATCH v3] etc. > > git

[PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-05 Thread Xin Ji
Enable DSI EOTP feature for fixing some panel screen constant shift issue. Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-05 Thread Xin Ji
On Fri, Feb 05, 2021 at 10:43:14AM +0100, Robert Foss wrote: > On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss >

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-05 Thread Greg KH
On Wed, Feb 03, 2021 at 11:11:57AM -0700, Shuah Khan wrote: > +static inline u32 seqnum32_inc(struct seqnum32 *seq) > +{ > + atomic_t val = ATOMIC_INIT(seq->seqnum); > + > + seq->seqnum = (u32) atomic_inc_return(&val); > + if (seq->seqnum >= UINT_MAX) > + pr_info("Sequence N

Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:15PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. Again, explain _why_. Please read the section entitled "The canonical patch format" in the ke

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. That says what you do, but not _why_ you are doing it. What does this offer in benefit of the

[PATCH 0/4] Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
Few drivers use ccflags-* in their top directory to enable -DDEBUG, but don't have config options to enable debug in the sub-directories. They should want the subdirectories inherit the debug flag from the top. Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig wh

[PATCH 3/4] pps: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas Signed-off-by: Junhao He Signed-off-by: Yicong Yang --- drivers/pps/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas Signed-off-by: Junhao He Signed-off-by: Yicong Yang --- drivers/staging/comedi/Makefile | 2 +- drivers/staging/comed

[PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas Signed-off-by: Junhao He Signed-off-by: Yicong Yang --- drivers/hwmon/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Yicong Yang
From: Junhao He Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas Signed-off-by: Junhao He Signed-off-by: Yicong Yang --- drivers/base/Makefile | 2 +- drivers/base/power/Makefile | 2 -- 2 f

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

2021-02-05 Thread Robert Foss
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > > >> > > >> Thanks for the patch. > > >> > > >> On Th

Re: [PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 02:41:13PM +0530, Mayank Suman wrote: > According to Documentation/timers/timers-howto.rst, usleep_range is > preffered over udelay for >=10us delay. > > Signed-off-by: Mayank Suman ALWAYS test build your patches before sending them out to the world for review. You don't

[PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread Mayank Suman
According to Documentation/timers/timers-howto.rst, usleep_range is preffered over udelay for >=10us delay. Signed-off-by: Mayank Suman --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- drivers/staging/fbtft/fb_tinylcd.c | 4 ++-- drivers/

[PATCH v2] staging: qlge/qlge_main: Use min_t instead of min

2021-02-05 Thread ameynarkhede02
From: Amey Narkhede Use min_t instead of min function in qlge/qlge_main.c Fixes following checkpatch.pl warning: WARNING: min() should probably be min_t(int, MAX_CPUS, num_online_cpus()) Signed-off-by: Amey Narkhede --- Changes in v2: - Remove superfluous int cast from num_online_cpus

Re: [PATCH] staging: qlge/qlge_main: Use min_t instead of min

2021-02-05 Thread Amey Narkhede
On 21/02/04 03:58PM, Nathan Chancellor wrote: > On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhed...@gmail.com wrote: > > From: Amey Narkhede > > > > Use min_t instead of min function in qlge/qlge_main.c > > Fixes following checkpatch.pl warning: > > WARNING: min() should probably be min_t(int