Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote: > > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by > drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be > declared static in emxx_udc.c and removed from emxx_udc.h? > Either would be correct. I

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

Hi Kumar, On Sun, 7 Feb 2021 05:30:31 +0530 Kumar Kartikeya Dwivedi wrote: > > The global gpio_desc pointer and int were defined in the header, > instead put the definitions in the translation unit and add an extern > declaration for consumers of the header (currently only one, which is > perha

[PATCH] staging: emxx_udc: Fix incorrectly defined global

The global gpio_desc pointer and int were defined in the header, instead put the definitions in the translation unit and add an extern declaration for consumers of the header (currently only one, which is perhaps why the linker didn't complain about symbol collisions). This fixes sparse related wa

[PATCH] staging: octeon: remove braces from single-line block

This removes the braces from the if statement that checks the physical node return value in cvm_oct_phy_setup_device, as this block contains only one statement. Fixes a style warning. Signed-off-by: Phillip Potter --- drivers/staging/octeon/ethernet-mdio.c | 3 +-- 1 file changed, 1 insertion(+)

[no subject]

-- Korisnik fonda čestitanja, Vaša sredstva za naknadu od 850.000,00 američkih dolara odobrila je Međunarodna monetarna organizacija (MMF) u suradnji s (FBI) nakon mnogo istraga. Čekamo da se obratimo za dodatne informacije Advokat: Daven Bango Telefon: +22891667276 (URED MMF-a LOME TOGO) ___