Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

On Sat, Feb 20, 2021 at 03:54:05PM +, William Durand wrote: > Fixes a checkpatch CHECK issue. > All these patches have the same vague commit message. It's okay if the commit message basically restates the commit one line summary. It should say something like: Fix a checkpatch warning

Re: [PATCH] drivers: staging: comedi: Fixed side effects from macro definition.

A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PATCH] staging: rt8192u: Move constant in comparison to the RHS

Fixes checkpatch warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Simone Serra --- drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_wx.c

[PATCH 13/13] staging: rtl8192e: reformat bss_ht struct

This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 12/13] staging: rtl8192e: rename bdHT1R to bd_ht_1r in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 11/13] staging: rtl8192e: rename RT2RT_HT_Mode to rt2rt_ht_mode in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 8 drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 4 files

[PATCH 10/13] staging: rtl8192e: rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 4 files

[PATCH 09/13] staging: rtl8192e: rename bdRT2RTAggregation to bd_rt2rt_aggregation in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 08/13] staging: rtl8192e: rename bdBandWidth to bd_bandwidth in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 04/13] staging: rtl8192e: rename bdHTCapLen to bd_ht_cap_len in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 drivers/staging/rtl8192e/rtllib_rx.c | 12 ++-- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4 files

[PATCH 07/13] staging: rtl8192e: rename bdHTSpecVer to bd_ht_spec_ver in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 10 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 06/13] staging: rtl8192e: rename bdHTInfoLen to bd_ht_info_len in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++--- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4

[PATCH 02/13] staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++--- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 4 files

[PATCH 03/13] staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 17 + drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-

[PATCH 05/13] staging: rtl8192e: rename bdHTInfoBuf to bd_ht_info_buf in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- drivers/staging/rtl8192e/rtllib_rx.c | 13 +++-- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4 files

[PATCH 00/13] bss_ht struct cleanups

This patchset fixes the checkpatch issues related to the `bss_ht` struct defined in `rtl8192e/rtl819x_HT.h` (avoid camelcase). The first patch removes a blank line and the last patch reformats the struct a bit to be more consistent with the other types defined in the same file. William Durand

[PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 11269fe6b395..1bbb9ed18e6d 100644 ---

[staging:staging-testing] BUILD SUCCESS 7e65b3022dab7d753cabbc88a124d0a9d6b140c1

allnoconfig i386 randconfig-a005-20210223 i386 randconfig-a006-20210223 i386 randconfig-a004-20210223 i386 randconfig-a003-20210223 i386 randconfig-a001-20210223 i386 randconfig-a002-20210223 x86_64

[PATCH 14/14] staging: comedi: pcl726: Use 16-bit 0 for interrupt data

The pcl726 driver has an "interrupt" subdevice that supports Comedi asynchronous commands, placing a value in the Comedi buffer for each interrupt. The subdevice uses Comedi's 16-bit sample format but the interrupt handler is calling `comedi_buf_write_samples()` with the address of a 32-bit

[PATCH 13/14] staging: comedi: ni_65xx: Use 16-bit 0 for interrupt data

The ni_65xx driver has an "interrupt" subdevice that supports Comedi asynchronous commands, placing a value in the Comedi buffer for each interrupt. The subdevice uses Comedi's 16-bit sample format but the interrupt handler is calling `comedi_buf_write_samples()` with the address of a 32-bit

[PATCH 12/14] staging: comedi: ni_6527: Use 16-bit 0 for interrupt data

The ni_6527 driver has an "interrupt" subdevice that supports Comedi asynchronous commands, placing a value in the Comedi buffer for each interrupt. The subdevice uses Comedi's 16-bit sample format but the interrupt handler is calling `comedi_buf_write_samples()` with the address of a 32-bit

[PATCH 11/14] staging: comedi: comedi_parport: Use 16-bit 0 for interrupt data

The comedi_parport driver has an "interrupt" subdevice that supports Comedi asynchronous commands, placing a value in the Comedi buffer for each interrupt. The subdevice uses Comedi's 16-bit sample format but the interrupt handler is calling `comedi_buf_write_samples()` with the address of a

[PATCH 10/14] staging: comedi: amplc_pc236_common: Use 16-bit 0 for interrupt data

The Amplicon PC36AT/PCI236 common driver has an "interrupt" subdevice that supports Comedi asynchronous commands, placing a value in the Comedi buffer for each interrupt. The subdevice uses Comedi's 16-bit sample format but the interrupt handler is calling `comedi_buf_write_samples()` with the

[PATCH 09/14] staging: comedi: pcl818: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer parameter. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 08/14] staging: comedi: pcl711: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 07/14] staging: comedi: me4000: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the calls to `comedi_buf_write_samples()` are passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 06/14] staging: comedi: dmm32at: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 04/14] staging: comedi: das6402: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 02/14] staging: comedi: addi_apci_1500: Fix endian problem for command sample

The digital input subdevice supports Comedi asynchronous commands that read interrupt status information. This uses 16-bit Comedi samples (of which only the bottom 8 bits contain status information). However, the interrupt handler is calling `comedi_buf_write_samples()` with the address of a

[PATCH 05/14] staging: comedi: das800: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the call to `comedi_buf_write_samples()` is passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 03/14] staging: comedi: adv_pci1710: Fix endian problem for AI command data

The analog input subdevice supports Comedi asynchronous commands that use Comedi's 16-bit sample format. However, the calls to `comedi_buf_write_samples()` are passing the address of a 32-bit integer variable. On bigendian machines, this will copy 2 bytes from the wrong end of the 32-bit value.

[PATCH 01/14] staging: comedi: addi_apci_1032: Fix endian problem for COS sample

The Change-Of-State (COS) subdevice supports Comedi asynchronous commands to read 16-bit change-of-state values. However, the interrupt handler is calling `comedi_buf_write_samples()` with the address of a 32-bit integer `>state`. On bigendian architectures, it will copy 2 bytes from the wrong

[PATCH 00/14] staging: comedi: Fix some command data endian problems

The `comedi_buf_read_samples()` and `comedi_buf_write_samples()` functions can read/write either 16-bit or 32-bit values from/to the Comedi buffer used for Comedi asynchonous command data. The width of the value depends on whether the subdevice sets the `SDF_LSAMPL` flag (indicating 32-bit