Re: [PATCH v6 4/5] drm/bridge: anx7625: add HDCP support

2021-03-25 Thread Sean Paul
On Fri, Mar 19, 2021 at 2:35 AM Xin Ji wrote: > > Add HDCP feature, enable HDCP function through chip internal key > and downstream's capability. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 147 ++ > drivers/gpu/drm/bridge/analogix/anx7625.h

Re: [PATCH] staging: gasket: remove it from the kernel

2021-03-25 Thread Jan Kiszka
On 25.03.21 15:52, Greg KH wrote: > On Thu, Mar 25, 2021 at 03:46:10PM +0100, Jan Kiszka wrote: >> On 15.03.21 17:10, Rob Springer wrote: >>> Acked-by: Rob Springer >>> >>> >>> On Mon, Mar 15, 2021 at 8:44 AM wrote: From: Greg Kroah-Hartman As none of the proposed things

Re: [PATCH] staging: gasket: remove it from the kernel

2021-03-25 Thread Jan Kiszka
On 15.03.21 17:10, Rob Springer wrote: > Acked-by: Rob Springer > > > On Mon, Mar 15, 2021 at 8:44 AM wrote: >> >> From: Greg Kroah-Hartman >> >> As none of the proposed things that need to be changed in the gasket >> drivers have ever been done, and there has not been any forward progress >>

Re: [PATCH] staging: gasket: remove it from the kernel

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 03:46:10PM +0100, Jan Kiszka wrote: > On 15.03.21 17:10, Rob Springer wrote: > > Acked-by: Rob Springer > > > > > > On Mon, Mar 15, 2021 at 8:44 AM wrote: > >> > >> From: Greg Kroah-Hartman > >> > >> As none of the proposed things that need to be changed in the gasket

Re: [PATCH v4 17/21] spmi: hisi-spmi-controller: move driver from staging

2021-03-25 Thread Mauro Carvalho Chehab
Em Fri, 5 Feb 2021 16:19:47 -0600 Rob Herring escreveu: > On Tue, Jan 19, 2021 at 05:10:43PM +0100, Mauro Carvalho Chehab wrote: > > The Hisilicon 6421v600 SPMI driver is ready for mainstream. > > > > So, move it from staging. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > >

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 07:03:39PM +0800, Jian Dong wrote: > On Thu, 25 Mar 2021 11:29:06 +0100 > Greg KH wrote: > > > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > > From: Jian Dong > > > > > > fixes coccicheck Error: > > > > > >

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Jian Dong
On Thu, 25 Mar 2021 11:29:06 +0100 Greg KH wrote: > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > From: Jian Dong > > > > fixes coccicheck Error: > > > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > > fw is NULL but dereferenced. > > > > if procedure goto label

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Viresh Kumar
On 25-03-21, 18:19, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nefative, so the fw is NULL > and the if(condition) end with

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Dan Carpenter
The commit description is not clear but this patch doesn't change how the code works, it just silences a static checker false positive. Just ignore the false positive. Always just ignore static checkers when they are wrong. regards, dan carpenter ___

[PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Jian Dong
From: Jian Dong fixes coccicheck Error: drivers/staging/greybus/bootrom.c:301:41-45: ERROR: fw is NULL but dereferenced. if procedure goto label directly, ret will be nefative, so the fw is NULL and the if(condition) end with dereferenced fw. let's fix it. Signed-off-by: Jian Dong ---

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nefative, so the fw is NULL > and the