[PATCH v5 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2021-09-10 Thread lichenyang
From: Chenyang Li This patch adds an initial DRM driver for the Loongson LS7A1000 bridge chip(LS7A). The LS7A bridge chip contains two display controllers, support dual display output. The maximum support for each channel display is to 1920x1080@60Hz. At present, DC device detection and DRM drive

[PATCH v5 2/3] drm/loongson: Add GPIO and I2C driver for loongson drm.

2021-09-10 Thread lichenyang
Implement use GPIO and I2C driver to detect connector and fetch EDID via DDC. v4: - Delete the gpioo_chip subsystem call. - Delete some redundant prints. v3: - Change some driver log to the drm_ version. v2: - Optimize the error handling process. - Delete loongson_i2c_bus_match and loongson_i2c_

[PATCH v5 3/3] drm/loongson: Add interrupt driver for LS7A

2021-09-10 Thread lichenyang
Add LS7A DC vsync interrupt enable and close function, and register irq_handler function interface. Add vbrank event processing flow. v4: - Replace drm_irq_install with devm_request_irq. - Delete the irq_ hooks in drm_driver. v3: - Improve code readability. - Use the to_pci_dev function to get pc

Re: [PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 07:12:28PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:57:43 CEST Kari Argillander wrote: > > > > On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > Function arguments must be aligned with left parent

Re: [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 19:07:41 CEST Kari Argillander wrote: > > On Fri, Sep 10, 2021 at 06:04:33PM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > Hi, > > > > The following PR contains now usual maintenance for the wfx driver. I have > > more-or-less sorted the patches by im

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 19:01:05 CEST Kari Argillander wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Fri, Sep 10, 2021 at 06:54:36PM +0200, Jérôme Po

Re: [PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 18:57:43 CEST Kari Argillander wrote: > > On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > Function arguments must be aligned with left parenthesis. Apply that > > rule. > > To my eyes something still go wrong with thi

Re: [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:33PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Hi, > > The following PR contains now usual maintenance for the wfx driver. I have > more-or-less sorted the patches by importance: > - the first ones are fixes for a few corner-cases reported by use

Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:49:30PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:27:18 CEST Kari Argillander wrote: > > On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > Comments after the last #endif of header files don't bri

Re: [PATCH 13/31] staging: wfx: update with API 3.8

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 18:43:26 CEST Kari Argillander wrote: > > On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > API 3.8 introduces new statistic counters. These changes are backward > > compatible. > > It will be obvious to some what API 3

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:54:36PM +0200, Jérôme Pouiller wrote: > On Friday 10 September 2021 18:31:00 CEST Kari Argillander wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the con

Re: [PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:05:04PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Function arguments must be aligned with left parenthesis. Apply that > rule. To my eyes something still go wrong with this patch. Might be my email fault, but every other patch looks ok. Now these are to

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 18:31:00 CEST Kari Argillander wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Fri, Sep 10, 2021 at 06:04:35PM +0200, Jerome Po

Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Jérôme Pouiller
On Friday 10 September 2021 18:27:18 CEST Kari Argillander wrote: > On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > Comments after the last #endif of header files don't bring any > > information and are redundant with the name of the file. Drop th

Re: [PATCH 13/31] staging: wfx: update with API 3.8

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:46PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > API 3.8 introduces new statistic counters. These changes are backward > compatible. It will be obvious to some what API 3.8 is. But at least me can rise my hand and admit that I do not. Probably wfx api

[PATCH v3 1/1] binder: fix freeze race

2021-09-10 Thread Li Li
From: Li Li Currently cgroup freezer is used to freeze the application threads, and BINDER_FREEZE is used to freeze the corresponding binder interface. There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any existing transactions to drain out before actually freezing the binder interf

[PATCH v3 0/1] binder: fix freeze race

2021-09-10 Thread Li Li
From: Li Li As there isn't an atomic operation to freeze the main thread and binder interface together, it's possible the main thread initiates a new binder transaction while the binder interfaces are already frozen. This race issue will result in failed binder transaction and unexpectedly crash

Re: [PATCH 17/31] staging: wfx: simplify hif_join()

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:50PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > The new code is smaller. > > Signed-off-by: Jérôme Pouiller > --- > drivers/staging/wfx/hif_tx.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/wfx/hif_tx

Re: [PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:04:35PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > During the scan requests, the Tx traffic is suspended. This lock is > shared by all the network interfaces. So, a scan request on one > interface will block the traffic on a second interface. This causes

Re: [PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Kari Argillander
On Fri, Sep 10, 2021 at 06:05:02PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Comments after the last #endif of header files don't bring any > information and are redundant with the name of the file. Drop them. How so? You see right away that this indeed is header guard and not so

[PATCH 31/31] staging: wfx: indent functions arguments

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Function arguments must be aligned with left parenthesis. Apply that rule. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx_mib.c | 2 +- drivers/staging/wfx/key.c| 26 +- 2 files changed, 14 insertions(+), 14 deletions(-) di

[PATCH 30/31] staging: wfx: explain the purpose of wfx_send_pds()

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller On first look, the goal of wfx_send_pds() is not obvious. A small explanation is welcomed. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/main.c b/driver

[PATCH 29/31] staging: wfx: remove useless comments after #endif

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Comments after the last #endif of header files don't bring any information and are redundant with the name of the file. Drop them. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.h | 2 +- drivers/staging/wfx/data_rx.h | 2 +- drivers/staging/wfx/data_tx.h

[PATCH 27/31] staging: wfx: avoid c99 comments

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The wfx driver is a network driver. C99 comments are prohibited in this part of the kernel. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 18 +++--- drivers/staging/wfx/bus_sdio.c| 8 +-- drivers/staging/wfx/bus_spi.c | 12 ++-

[PATCH 28/31] staging: wfx: fix comments styles

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Unify all comments of the wfx driver to use the same comment style. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 11 +++ drivers/staging/wfx/bus_spi.c | 6 ++ drivers/staging/wfx/fwio.c| 3 +-- drivers/staging/wfx/main.h| 3 +--

[PATCH 26/31] staging: wfx: reformat comment

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The new comment takes only one line instead of three. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index d64476b48881..0f48dab105e9

[PATCH 25/31] staging: wfx: update files descriptions

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Each file of the driver contains a short description of its purpose. These description were a bit outdated. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.h | 2 +- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_rx.h | 2 +- drivers/staging

[PATCH 24/31] staging: wfx: remove references to WFxxx in comments

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The WF200 is the only representative of the WFxxx series and the development of any successor is not expected. So, for clarity, replace occurrences of "WFxxx" with "WF200". Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 4 ++-- drivers/staging

[PATCH 23/31] staging: wfx: fix space after cast operator

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller checkpatch.pl reports that cast operators should not been followed by a space. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index a8ef

[PATCH 22/31] staging: wfx: remove useless debug statement

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller In the early age, it was unexpected to access a VIF that did not exist. With current code, this happens frequently. Having a trace associated on this event brings absolutely no informations. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wfx.h | 5 + 1 file ch

[PATCH 21/31] staging: wfx: remove unused definition

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The enum hif_fw_type is never used in the driver. Drop it. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_general.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wfx/hif_api_general.h b/drivers/staging/wfx/hif_api_general.h inde

[PATCH 20/31] staging: wfx: apply naming rules in hif_tx_mib.c

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller All the functions of hif_tx_mib.c format data to be sent to the hardware. In this file, the struct to be sent is always named 'arg'. Also applies this rule to hif_set_macaddr(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx_mib.c | 6 +++--- 1 file change

[PATCH 19/31] staging: wfx: fix error names

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller ENOTSUP is an alias of EOPNOTSUPP. However, EOPNOTSUPP is preferred. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 464a67a9b41c..

[PATCH 18/31] staging: wfx: reorder function for slightly better eye candy

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller For a code more eye candy, group all the unconditional assignments together. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data

[PATCH 17/31] staging: wfx: simplify hif_join()

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The new code is smaller. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 6ffbae32028b..aea0ed55edc6 100644 --- a/drive

[PATCH 16/31] staging: wfx: declare variables at beginning of functions

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller For better code, we prefer to declare all the local variables at beginning of the functions. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/driver

[PATCH 15/31] staging: wfx: fix misleading 'rate_id' usage

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The driver sometime use the term 'rate_id' to identify a retry policy (which is in fact a series of rate IDs). This is misleading. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff

[PATCH 14/31] staging: wfx: uniformize counter names

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The device provide some internal statistic counters. However, the names of counter were not very meaningful. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/debug.c | 45 - drivers/staging/wfx/hif_api_mib.h | 82 +++

[PATCH 13/31] staging: wfx: update with API 3.8

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller API 3.8 introduces new statistic counters. These changes are backward compatible. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/debug.c | 3 +++ drivers/staging/wfx/hif_api_mib.h | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 12/31] staging: wfx: simplify API coherency check

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The 'channel' argument of hif_join() should never be NULL. hif_join() does not have the responsibility to recover bug of caller. A call to WARN() at the beginning of the function reminds this constraint to the developer. In current code, if the argument channel is NULL, mem

[PATCH 11/31] staging: wfx: relax the PDS existence constraint

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The PDS file contains antenna parameters. The file is specific to each hardware design. Normally, the board designer should add a line in the of_device_id table with his own antenna parameters. Until, now the absence of PDS file is a hard fatal error. However, during the de

[PATCH 10/31] staging: wfx: fix support for CSA

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The WF200 is able to filter beacons. However, it uses a positive filter: any change to an IE not listed won't be reported. In current code, the changes in Channel Switch Announcement (CSA) are not reported to the host. Thus, it fixes the support for CSA in station mode. Si

[PATCH 09/31] staging: wfx: declare support for TDLS

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Since API 3.8, the device is able to support TDLS. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index 4b9fdf99981b..0a9d02d1af2f 100644 --- a/dr

[PATCH 08/31] staging: wfx: take advantage of wfx_tx_queue_empty()

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller wfx_tx_queues_check_empty() can be slightly simplified by calling wfx_tx_queue_empty(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/queue.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wfx/queue.c b

[PATCH 07/31] staging: wfx: fix atomic accesses in wfx_tx_queue_empty()

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Checking if a skb_queue is empty is not an atomic operation. We should take some precautions to do it. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/queue.c b/driver

[PATCH 06/31] staging: wfx: drop unused argument from hif_scan()

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller It is no more necessary to compute the expected duration of the scan request. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 9 + drivers/staging/wfx/hif_tx.h | 2 +- drivers/staging/wfx/scan.c | 2 +- 3 files changed, 3 insertions(+), 10 dele

[PATCH 05/31] staging: wfx: avoid possible lock-up during scan

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller If the environment is noisy, the device may take time to send scan requests. Thus, scan requests durations > 5s have already been observed. During the scan, traffic is neither received, neither sent. From the user point-of-view, the traffic is frozen for a long time. This p

[PATCH 04/31] staging: wfx: wait for SCAN_CMPL after a SCAN_STOP

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller When the device has finished a scan request, it send a scan complete ("SCAN_COMPL") indication. It is also possible to abort a scan request with a "SCAN_STOP" message. A SCAN_COMPL is also send in this case. The driver limits the delay to make a scan request. A timeout happ

[PATCH 03/31] staging: wfx: ignore PS when STA/AP share same channel

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller When multiple interface are in use. One is always AP while the other is always station. When the two interface use the same channel, it makes no sense to enabled Power Saving (PS) on the station. Indeed, because of the AP, the device will be kept awake on this channel anyway

[PATCH 02/31] staging: wfx: do not send CAB while scanning

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller During the scan requests, the Tx traffic is suspended. This lock is shared by all the network interfaces. So, a scan request on one interface will block the traffic on a second interface. This causes trouble when the queued traffic contains CAB (Content After DTIM Beacon) si

[PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller Hi, The following PR contains now usual maintenance for the wfx driver. I have more-or-less sorted the patches by importance: - the first ones are fixes for a few corner-cases reported by users - the patches 9 and 10 add support for CSA and TDLS - then the end o

[PATCH 01/31] staging: wfx: use abbreviated message for "incorrect sequence"

2021-09-10 Thread Jerome Pouiller
From: Jérôme Pouiller The wfx driver checks carefully the coherency of of the DTIM notifications. We have noticed several times some small inconsistencies from the firmware on these notification. They have never been critical. However on the driver side they lead to big fat warnings. Worse, if t

Good Day,

2021-09-10 Thread Mr.James Khmalo
Good Day, I know this email might come to you as a surprise as first coming from one you haven’t met with before. I am Mr. James Khmalo, the bank manager with ABSA bank of South Africa, and a personal banker of Dr.Mohamed Farouk Ibrahim, an Egyptian who happened to be a medical contractor att

Re: [PATCH v2 1/1] binder: fix freeze race

2021-09-10 Thread Greg KH
On Thu, Sep 09, 2021 at 11:17:42PM -0700, Li Li wrote: > On Thu, Sep 9, 2021 at 10:38 PM Greg KH wrote: > > > > On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote: > > > struct binder_frozen_status_info { > > > __u32pid; > > > + > > > + /* process received sync transactio

Re: [PATCH v1 1/1] binder: fix freeze race

2021-09-10 Thread Li Li
On Thu, Sep 9, 2021 at 11:03 PM Dan Carpenter wrote: > > On Thu, Sep 09, 2021 at 04:21:41PM -0700, Li Li wrote: > > @@ -4648,6 +4647,22 @@ static int binder_ioctl_get_node_debug_info(struct > > binder_proc *proc, > > return 0; > > } > > > > +static int binder_txns_pending(struct binder_pro