allmodconfig
i386 randconfig-c001-20210913
powerpc motionpro_defconfig
arm axm55xx_defconfig
powerpc mpc8540_ads_defconfig
m68km5307c3_defconfig
powerpc ppc6xx_defconfig
mips
On Fri, Sep 10, 2021 at 9:42 AM Li Li wrote:
>
> From: Li Li
>
> Currently cgroup freezer is used to freeze the application threads, and
> BINDER_FREEZE is used to freeze the corresponding binder interface.
> There's already a mechanism in ioctl(BINDER_FREEZE) to wait for any
> existing
allmodconfig
i386 randconfig-c001-20210913
arm aspeed_g4_defconfig
m68kq40_defconfig
armkeystone_defconfig
powerpc canyonlands_defconfig
mipse55_defconfig
powerpc
allmodconfig
i386 randconfig-c001-20210913
s390 debug_defconfig
powerpc bluestone_defconfig
powerpc mpc8560_ads_defconfig
mips rs90_defconfig
arm pxa168_defconfig
On Fri, Sep 10, 2021 at 12:15 AM Greg KH wrote:
>
> On Thu, Sep 09, 2021 at 11:17:42PM -0700, Li Li wrote:
> > On Thu, Sep 9, 2021 at 10:38 PM Greg KH wrote:
> > >
> > > On Thu, Sep 09, 2021 at 08:53:16PM -0700, Li Li wrote:
> > > > struct binder_frozen_status_info {
> > > > __u32
On Mon, Sep 13, 2021 at 03:01:31PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Hi,
>
> The following PR contains now usual maintenance for the wfx driver. I have
> more-or-less sorted the patches by importance:
> - the first ones and the two last ones are fixes for a few
From: Jérôme Pouiller
Since commit 5561770f80b1 ("staging: wfx: repair external IRQ for
SDIO"), wfx_sdio_irq_subscribe() enforce the device to use IRQs.
However, there is currently a race in this code. An IRQ may happen
before the IRQ has been registered.
The problem has observed during debug
From: Jérôme Pouiller
Function arguments must be aligned with first argument. Apply that
rule.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 2 +-
drivers/staging/wfx/key.c| 26 +-
2 files changed, 14 insertions(+), 14 deletions(-)
From: Jérôme Pouiller
On first look, the goal of wfx_send_pds() is not obvious. A small
explanation is welcomed.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/main.c
From: Jérôme Pouiller
Comments after the last #endif of header files don't bring any
information and are redundant with the name of the file. Drop them.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.h | 2 +-
drivers/staging/wfx/data_rx.h | 2 +-
drivers/staging/wfx/data_tx.h
From: Jérôme Pouiller
The wfx driver is a network driver. C99 comments are prohibited in this
part of the kernel.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 22
drivers/staging/wfx/bus_sdio.c| 8 +--
drivers/staging/wfx/bus_spi.c | 12
From: Jérôme Pouiller
Unify all comments of the wfx driver to use the same comment style.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 11 +++
drivers/staging/wfx/bus_spi.c | 6 ++
drivers/staging/wfx/fwio.c| 3 +--
drivers/staging/wfx/main.h| 3
From: Jérôme Pouiller
Each file of the driver contains a short description of its purpose.
These description were a bit outdated.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.h | 2 +-
drivers/staging/wfx/data_rx.c | 2 +-
drivers/staging/wfx/data_rx.h | 2 +-
From: Jérôme Pouiller
The new comment takes only one line instead of three.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index
From: Jérôme Pouiller
The WF200 is the only representative of the WFxxx series and the
development of any successor is not expected. So, for clarity, replace
occurrences of "WFxxx" with "WF200".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 4 ++--
From: Jérôme Pouiller
checkpatch.pl reports that cast operators should not been followed by a
space.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/wfx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h
index
From: Jérôme Pouiller
In the early age, it was unexpected to access a VIF that did not exist.
With current code, this happens frequently. Having a trace associated on
this event brings absolutely no informations.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/wfx.h | 5 +
1 file
From: Jérôme Pouiller
The enum hif_fw_type is never used in the driver. Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_general.h
b/drivers/staging/wfx/hif_api_general.h
From: Jérôme Pouiller
All the functions of hif_tx_mib.c format data to be sent to the
hardware. In this file, the struct to be sent is always named 'arg'.
Also applies this rule to hif_set_macaddr().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 6 +++---
1 file
From: Jérôme Pouiller
ENOTSUP is an alias of EOPNOTSUPP. However, EOPNOTSUPP is preferred.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index
From: Jérôme Pouiller
For a code more eye candy, group all the unconditional assignments
together.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
The new code is smaller.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index fcce78bb3005..c5ab1c2e1e07 100644
---
From: Jérôme Pouiller
For better code, we prefer to declare all the local variables at
beginning of the functions.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
The driver sometime use the term 'rate_id' to identify a retry policy
(which is in fact a series of rate IDs). This is misleading.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
From: Jérôme Pouiller
The device provide some internal statistic counters. However, the names
of counter were not very meaningful.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/debug.c | 45 -
drivers/staging/wfx/hif_api_mib.h | 82
From: Jérôme Pouiller
The firmware API 3.8 introduces new statistic counters. These changes
are backward compatible.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/debug.c | 3 +++
drivers/staging/wfx/hif_api_mib.h | 5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff
From: Jérôme Pouiller
The 'channel' argument of hif_join() should never be NULL. hif_join()
does not have the responsibility to recover bug of caller.
In current code, if the argument channel is NULL, memory leaks. The new
code just emit a warning and does not give the illusion that it is
From: Jérôme Pouiller
The PDS file contains antenna parameters. The file is specific to each
hardware design. Normally, the board designer should add a line in the
of_device_id table with his own antenna parameters.
Until, now the absence of PDS file is a hard fatal error. However,
during the
From: Jérôme Pouiller
The WF200 is able to filter beacons. However, it uses a positive filter:
any change to an IE not listed won't be reported.
In current code, the changes in Channel Switch Announcement (CSA) are
not reported to the host. Thus, it fixes the support for CSA in station
mode.
From: Jérôme Pouiller
Since the firmware API 3.8, the device is able to support TDLS.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 4b9fdf99981b..0a9d02d1af2f
From: Jérôme Pouiller
wfx_tx_queues_check_empty() can be slightly simplified by calling
wfx_tx_queue_empty().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wfx/queue.c
From: Jérôme Pouiller
Checking if a skb_queue is empty is not an atomic operation. We should
take some precautions to do it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/queue.c
From: Jérôme Pouiller
It is no more necessary to compute the expected duration of the scan
request.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 9 +
drivers/staging/wfx/hif_tx.h | 2 +-
drivers/staging/wfx/scan.c | 2 +-
3 files changed, 3 insertions(+), 10
From: Jérôme Pouiller
If the environment is noisy, the device may take time to send scan
requests. Thus, scan requests durations > 5s have already been observed.
During the scan, traffic is neither received, neither sent. From the
user point-of-view, the traffic is frozen for a long time.
This
From: Jérôme Pouiller
When the device has finished a scan request, it send a scan complete
("SCAN_COMPL") indication. It is also possible to abort a scan request
with a "SCAN_STOP" message. A SCAN_COMPL is also send in this case.
The driver limits the delay to make a scan request. A timeout
From: Jérôme Pouiller
When multiple interface are in use. One is always AP while the other is
always station. When the two interface use the same channel, it makes no
sense to enabled Power Saving (PS) on the station. Indeed, because of
the AP, the device will be kept awake on this channel
From: Jérôme Pouiller
During the scan requests, the Tx traffic is suspended. This lock is
shared by all the network interfaces. So, a scan request on one
interface will block the traffic on a second interface. This causes
trouble when the queued traffic contains CAB (Content After DTIM Beacon)
From: Jérôme Pouiller
Hi,
The following PR contains now usual maintenance for the wfx driver. I have
more-or-less sorted the patches by importance:
- the first ones and the two last ones are fixes for a few corner-cases
reported by users
- the patches 9 and 10 add support for CSA
From: Jérôme Pouiller
The wfx driver checks carefully the coherency of of the DTIM
notifications. We have noticed several times some small inconsistencies
from the firmware on these notification. They have never been critical.
However on the driver side they lead to big fat warnings. Worse, if
On Mon, Sep 13, 2021 at 12:36:25PM +0200, Jérôme Pouiller wrote:
> On Monday 13 September 2021 11:33:28 CEST Dan Carpenter wrote:
> > On Mon, Sep 13, 2021 at 10:30:15AM +0200, Jerome Pouiller wrote:
> > > diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> > > index
On Monday 13 September 2021 11:33:28 CEST Dan Carpenter wrote:
> On Mon, Sep 13, 2021 at 10:30:15AM +0200, Jerome Pouiller wrote:
> > diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> > index 5de9ccf02285..aff0559653bf 100644
> > --- a/drivers/staging/wfx/sta.c
> > +++
On Mon, Sep 13, 2021 at 10:30:25AM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> The firmware API 3.8 introduces new statistic counters. These changes
> are backward compatible.
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/staging/wfx/debug.c | 3 +++
>
On Mon, Sep 13, 2021 at 10:30:24AM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> The 'channel' argument of hif_join() should never be NULL. hif_join()
> does not have the responsibility to recover bug of caller. A call to
> WARN() at the beginning of the function reminds this
On Mon, Sep 13, 2021 at 10:30:23AM +0200, Jerome Pouiller wrote:
> @@ -395,9 +395,7 @@ int wfx_probe(struct wfx_dev *wdev)
>
> dev_dbg(wdev->dev, "sending configuration file %s\n",
> wdev->pdata.file_pds);
> - err = wfx_send_pdata_pds(wdev);
> - if (err < 0)
> -
On Mon, Sep 13, 2021 at 10:30:15AM +0200, Jerome Pouiller wrote:
> diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> index 5de9ccf02285..aff0559653bf 100644
> --- a/drivers/staging/wfx/sta.c
> +++ b/drivers/staging/wfx/sta.c
> @@ -154,18 +154,26 @@ static int
From: Jérôme Pouiller
If PDS data is not correct, the device is unlikely to work. Worse, the
pinmux maybe it misconfigured and it can generate IRQ-storms. Therefore,
do not try to start-up the device if PDS is invalid.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 4 +++-
1
From: Jérôme Pouiller
Since commit 5561770f80b1 ("staging: wfx: repair external IRQ for
SDIO"), wfx_sdio_irq_subscribe() enforce the device to use IRQs.
However, there is currently a race in this code. An IRQ may happen
before the IRQ has been registered.
The problem has observed during debug
From: Jérôme Pouiller
Function arguments must be aligned with first argument. Apply that
rule.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 2 +-
drivers/staging/wfx/key.c| 26 +-
2 files changed, 14 insertions(+), 14 deletions(-)
From: Jérôme Pouiller
On first look, the goal of wfx_send_pds() is not obvious. A small
explanation is welcomed.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/main.c
From: Jérôme Pouiller
The wfx driver is a network driver. C99 comments are prohibited in this
part of the kernel.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 18 ---
drivers/staging/wfx/bus_sdio.c| 8 +--
drivers/staging/wfx/bus_spi.c | 12
From: Jérôme Pouiller
Unify all comments of the wfx driver to use the same comment style.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 11 +++
drivers/staging/wfx/bus_spi.c | 6 ++
drivers/staging/wfx/fwio.c| 3 +--
drivers/staging/wfx/main.h| 3
From: Jérôme Pouiller
Comments after the last #endif of header files don't bring any
information and are redundant with the name of the file. Drop them.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.h | 2 +-
drivers/staging/wfx/data_rx.h | 2 +-
drivers/staging/wfx/data_tx.h
From: Jérôme Pouiller
Each file of the driver contains a short description of its purpose.
These description were a bit outdated.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.h | 2 +-
drivers/staging/wfx/data_rx.c | 2 +-
drivers/staging/wfx/data_rx.h | 2 +-
From: Jérôme Pouiller
The new comment takes only one line instead of three.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index
From: Jérôme Pouiller
The WF200 is the only representative of the WFxxx series and the
development of any successor is not expected. So, for clarity, replace
occurrences of "WFxxx" with "WF200".
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/bh.c | 4 ++--
From: Jérôme Pouiller
checkpatch.pl reports that cast operators should not been followed by a
space.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/wfx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h
index
From: Jérôme Pouiller
All the functions of hif_tx_mib.c format data to be sent to the
hardware. In this file, the struct to be sent is always named 'arg'.
Also applies this rule to hif_set_macaddr().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx_mib.c | 6 +++---
1 file
From: Jérôme Pouiller
The enum hif_fw_type is never used in the driver. Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_general.h
b/drivers/staging/wfx/hif_api_general.h
From: Jérôme Pouiller
In the early age, it was unexpected to access a VIF that did not exist.
With current code, this happens frequently. Having a trace associated on
this event brings absolutely no informations.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/wfx.h | 5 +
1 file
From: Jérôme Pouiller
For a code more eye candy, group all the unconditional assignments
together.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
ENOTSUP is an alias of EOPNOTSUPP. However, EOPNOTSUPP is preferred.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index
From: Jérôme Pouiller
The new code is smaller.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index 6ffbae32028b..aea0ed55edc6 100644
---
From: Jérôme Pouiller
The driver sometime use the term 'rate_id' to identify a retry policy
(which is in fact a series of rate IDs). This is misleading.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff
From: Jérôme Pouiller
The device provide some internal statistic counters. However, the names
of counter were not very meaningful.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/debug.c | 45 -
drivers/staging/wfx/hif_api_mib.h | 82
From: Jérôme Pouiller
For better code, we prefer to declare all the local variables at
beginning of the functions.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wfx/data_tx.c
From: Jérôme Pouiller
The firmware API 3.8 introduces new statistic counters. These changes
are backward compatible.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/debug.c | 3 +++
drivers/staging/wfx/hif_api_mib.h | 5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff
From: Jérôme Pouiller
The 'channel' argument of hif_join() should never be NULL. hif_join()
does not have the responsibility to recover bug of caller. A call to
WARN() at the beginning of the function reminds this constraint to the
developer.
In current code, if the argument channel is NULL,
From: Jérôme Pouiller
The PDS file contains antenna parameters. The file is specific to each
hardware design. Normally, the board designer should add a line in the
of_device_id table with his own antenna parameters.
Until, now the absence of PDS file is a hard fatal error. However,
during the
From: Jérôme Pouiller
Since the firmware API 3.8, the device is able to support TDLS.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
index 4b9fdf99981b..0a9d02d1af2f
From: Jérôme Pouiller
If the environment is noisy, the device may take time to send scan
requests. Thus, scan requests durations > 5s have already been observed.
During the scan, traffic is neither received, neither sent. From the
user point-of-view, the traffic is frozen for a long time.
This
From: Jérôme Pouiller
The WF200 is able to filter beacons. However, it uses a positive filter:
any change to an IE not listed won't be reported.
In current code, the changes in Channel Switch Announcement (CSA) are
not reported to the host. Thus, it fixes the support for CSA in station
mode.
From: Jérôme Pouiller
wfx_tx_queues_check_empty() can be slightly simplified by calling
wfx_tx_queue_empty().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wfx/queue.c
From: Jérôme Pouiller
Checking if a skb_queue is empty is not an atomic operation. We should
take some precautions to do it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/queue.c
From: Jérôme Pouiller
It is no more necessary to compute the expected duration of the scan
request.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_tx.c | 9 +
drivers/staging/wfx/hif_tx.h | 2 +-
drivers/staging/wfx/scan.c | 2 +-
3 files changed, 3 insertions(+), 10
From: Jérôme Pouiller
When the device has finished a scan request, it send a scan complete
("SCAN_COMPL") indication. It is also possible to abort a scan request
with a "SCAN_STOP" message. A SCAN_COMPL is also send in this case.
The driver limits the delay to make a scan request. A timeout
From: Jérôme Pouiller
When multiple interface are in use. One is always AP while the other is
always station. When the two interface use the same channel, it makes no
sense to enabled Power Saving (PS) on the station. Indeed, because of
the AP, the device will be kept awake on this channel
From: Jérôme Pouiller
During the scan requests, the Tx traffic is suspended. This lock is
shared by all the network interfaces. So, a scan request on one
interface will block the traffic on a second interface. This causes
trouble when the queued traffic contains CAB (Content After DTIM Beacon)
From: Jérôme Pouiller
The wfx driver checks carefully the coherency of of the DTIM
notifications. We have noticed several times some small inconsistencies
from the firmware on these notification. They have never been critical.
However on the driver side they lead to big fat warnings. Worse, if
From: Jérôme Pouiller
Hi,
The following PR contains now usual maintenance for the wfx driver. I have
more-or-less sorted the patches by importance:
- the first ones and the two last ones are fixes for a few corner-cases
reported by users
- the patches 9 and 10 add support for CSA
79 matches
Mail list logo
