Hi Lee
Sorry for bother you, but I still can't see this patch applied.
Is there something wrong?
Regards.
micky.
On 07/08/2015 03:38 PM, Lee Jones wrote:
> On Wed, 08 Jul 2015, 敬锐 wrote:
>
>>
>> On 07/07/2015 07:46 PM, Lee Jones wrote:
>>> On Mon, 29 Jun 2015, micky
On 07/07/2015 07:46 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227.
Add it to file mfd/rts5227.c to support this chip.
Signed-off-by: Micky
On 02/16/2015 10:28 PM, Lee Jones wrote:
+static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
+{
+ int err;
+
+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
+ D3_DELINK_MODE_EN, 0x00);
+ if (err 0)
+ return err;
+
+
Hi Lee,
do you have reviewed this patchset?
regards.
micky.
On 01/22/2015 03:30 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
add support for new chip rts524A.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
drivers/mfd/rts5249.c|
On 01/22/2015 05:01 PM, Nicholas Mc Guire wrote:
sorry - that was a typo - should this be
resubmitted for traceability or is that not
necessary ?
resubmit, thanks.
___
devel mailing list
de...@linuxdriverproject.org
the title should be 5208.
On 01/19/2015 03:25 PM, Nicholas Mc Guire wrote:
This is only an API consolidation and should make things more readable
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
---
Converting milliseconds to jiffies by val * HZ / 1000 is technically
not wrong but
On 01/19/2015 03:47 PM, Lee Jones wrote:
On Mon, 19 Jan 2015, 敬锐 wrote:
On 01/18/2015 08:29 PM, Lee Jones wrote:
On Thu, 15 Jan 2015,micky_ch...@realsil.com.cn wrote:
From: Micky Chingmicky_ch...@realsil.com.cn
update phy register value and using direct value instead of macros
On 01/18/2015 08:29 PM, Lee Jones wrote:
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
update phy register value and using direct value instead of macros.
It is much easier to debug using constant value than a lot of macros.
We usually
On 01/18/2015 08:20 PM, Lee Jones wrote:
+static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
+{
+ int err;
+
+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
+ D3_DELINK_MODE_EN, 0x00);
+ if (err 0)
+ return err;
if (err)
err value will never be
On 01/18/2015 08:20 PM, Lee Jones wrote:
@@ -72,8 +72,10 @@ static void rts5249_fetch_vendor_settings(struct rtsx_pcr
*pcr)
rtsx_pci_read_config_dword(pcr, PCR_SETTING_REG1, reg);
dev_dbg((pcr-pci-dev), Cfg 0x%x: 0x%x\n, PCR_SETTING_REG1, reg);
- if
On 01/18/2015 08:20 PM, Lee Jones wrote:
+};
+
+void rts524a_init_params(struct rtsx_pcr *pcr)
+{
+ rts5249_init_params(pcr);
+
+ pcr-ops = rts524a_pcr_ops;
+}
I see a couple of these now. Why don't you make 'ops' a parameter of
*_init_params().
*_init_params() is called from
On 01/18/2015 07:13 PM, Lee Jones wrote:
@@ -97,7 +97,7 @@ static void rts5249_force_power_down(struct rtsx_pcr *pcr,
u8 pm_state)
rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0);
if (pm_state == HOST_ENTER_S3) {
- if (PCI_PID(pcr) == 0x524A)
+
On 01/18/2015 08:28 PM, Lee Jones wrote:
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
To enable/disable ASPM we should find LINK CONTROL register
in PCI config space. All old chip use 0x80 address, but new
chip may use another address,
On 01/18/2015 08:39 PM, Lee Jones wrote:
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Re-format coding-style, using uniform SPC after #define keyword
instead of mixing using TAB and SPC.
Tabs and spaces in this context usually have
On 12/08/2014 04:49 PM, Lee Jones wrote:
diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
index 74346d5..9234449 100644
--- a/include/linux/mfd/rtsx_pci.h
+++ b/include/linux/mfd/rtsx_pci.h
@@ -558,6 +558,7 @@
#define SD_SAMPLE_POINT_CTL 0xFDA7
On 12/08/2014 05:57 PM, Lee Jones wrote:
On Mon, 08 Dec 2014, 敬锐 wrote:
On 12/08/2014 04:49 PM, Lee Jones wrote:
diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
index 74346d5..9234449 100644
--- a/include/linux/mfd/rtsx_pci.h
+++ b/include/linux/mfd/rtsx_pci.h
Hi Lee,
this patch can be applied if you think it is ok, it doesn't depends
other patches.
regards.
micky.
On 12/05/2014 01:54 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Add helper function to write u32 to registers, if we want to put u32
value to 4
On 12/04/2014 09:52 PM, Ulf Hansson wrote:
v3:
rtsx_pci_sdmmc.c:
- dump_reg_range
- remove unused pointer check
- fix start index
I can't find v3.
Kind regards
Uffe
Sorry for mistake, This is v3, but subject is wrong.
___
On 11/27/2014 11:43 PM, Dan Carpenter wrote:
+int stat_idx = sd_status_index(rsp_type);
I have always hated this terrible pointer math. 5 is relative to
pcr-host_cmds_ptr + 1. It's a mess...
5 mean CRC7 offset of Response R1, see SD spec V3.01 Page 82.
4.9.1 R1 (normal response command).
On 11/27/2014 11:23 PM, Dan Carpenter wrote:
+static inline void rtsx_pci_write_be32(struct rtsx_pcr *pcr, u16 reg, u32
val)
+{
+ rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg, 0xFF, val 24);
+ rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 1, 0xFF, val 16);
+ rtsx_pci_add_cmd(pcr,
20 matches
Mail list logo
